NLA animated time strip with a driver displays a wrong frame when going back in time #86107

Open
opened 2021-02-28 23:34:13 +01:00 by Emilien Colombier · 6 comments

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.79

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-02-25 05:34, hash: 0e1c6a29cb

  • version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: 02948a2cab
    Worked: never

Short description of error
When using a driver on the "animated time strip" property of an NLA track, the animation is offseted when going backward in time, with the arrow keys. This makes the animation review process very hard.

Exact steps for others to reproduce the error
(see video attached)

#86107.blend

animate the default cube (example : revolution on Z axis, from frame 1 to 250
create an empty, add a custom property, set the max to 250
keyframe the custom property as : frame 1 value 1.00 ; frame 250 value 250.00.
tweak the animation curve of the custom property to get a nice S shape
copy the custom property as a new driver
go to the NLA, push down the cube action, go to it's strip option and check "animated time strips"
paste the driver on the "animated time strips" value
now if you go forward and backward with the arrowkeys, you'll see that the animation is doing some weird frame offset

bugreport_wrongframe.mp4

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.79 **Blender Version** Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-02-25 05:34, hash: `0e1c6a29cb` + version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: `02948a2cab` Worked: never **Short description of error** When using a driver on the "animated time strip" property of an NLA track, the animation is offseted when going backward in time, with the arrow keys. This makes the animation review process very hard. **Exact steps for others to reproduce the error** (see video attached) [#86107.blend](https://archive.blender.org/developer/F9855913/T86107.blend) animate the default cube (example : revolution on Z axis, from frame 1 to 250 create an empty, add a custom property, set the max to 250 keyframe the custom property as : frame 1 value 1.00 ; frame 250 value 250.00. tweak the animation curve of the custom property to get a nice S shape copy the custom property as a new driver go to the NLA, push down the cube action, go to it's strip option and check "animated time strips" paste the driver on the "animated time strips" value now if you go forward and backward with the arrowkeys, you'll see that the animation is doing some weird frame offset [bugreport_wrongframe.mp4](https://archive.blender.org/developer/F9853764/bugreport_wrongframe.mp4)

Added subscriber: @Peine_Perdue

Added subscriber: @Peine_Perdue
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

I can confirm the behavior.

However, as stated in #86109 (driver on an NLA animated time strip isn't purple and cannot be removed), I think this is due to the fact that this is not supposed to be driven in the first place:

In #86109#1121015, @lichtwerk wrote:
NLA control curves seem to get special handling in BKE_fcurve_find_by_rna_context_ui

See the following two comments:

/* Special case for NLA Control Curves... */
    /* Set the special flag, since it cannot be a normal action/driver
     * if we've been told to start looking here...
     */

If it is not supposed to be supported, I guess it would be good to prevent adding drivers in the first place.

related: b617dec065

Will confirm for now.

#86107.blend

I can confirm the behavior. However, as stated in #86109 (driver on an NLA animated time strip isn't purple and cannot be removed), I think this is due to the fact that this is not supposed to be driven in the first place: > In #86109#1121015, @lichtwerk wrote: > NLA control curves seem to get special handling in `BKE_fcurve_find_by_rna_context_ui` > > See the following two comments: > > > ``` > /* Special case for NLA Control Curves... */ > ``` > > ``` > /* Set the special flag, since it cannot be a normal action/driver > * if we've been told to start looking here... > */ > ``` > If it is not supposed to be supported, I guess it would be good to prevent adding drivers in the first place. > > related: b617dec065 Will confirm for now. [#86107.blend](https://archive.blender.org/developer/F9855913/T86107.blend)

If it is not supposed to be supported, I guess it would be good to prevent adding drivers in the first place.

Using a driver on this value is essantial when you want the same time remapping on multiple object on your scene. Removing it would be a huge error in my opinion

> If it is not supposed to be supported, I guess it would be good to prevent adding drivers in the first place. Using a driver on this value is essantial when you want the same time remapping on multiple object on your scene. Removing it would be a huge error in my opinion
Member

Added subscriber: @wbmoss_dev

Added subscriber: @wbmoss_dev
Philipp Oeser removed the
Interest
Animation & Rigging
label 2023-02-09 14:35:53 +01:00
Nathan Vegdahl self-assigned this 2023-05-23 12:27:26 +02:00
Nathan Vegdahl removed their assignment 2024-02-05 11:14:16 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#86107
No description provided.