Find solution to unify color picking methods with options for sample space #86196

Open
opened 2021-03-02 16:13:39 +01:00 by Simon Thommes · 10 comments
Member

Reopened as, though the initial issue is invalid, the current solution, as it is, is problematic.
The sample_color paint operator {key S} has a problem with discoverability and is separate from both the general UI color picker and the sample tool. This needs a better design solution.

Old Description (resolved by sample_color operator)

Right now all color picking is using the display space, which usually makes it (almost) impossible to accurately pick colors from an image that is not sRGB for texture painting.
Similarly, for texture painting in the 3D viewport the picked color is that after shading and display transformation. This can be useful, but it should be optional. In a lot of cases the user wants to pick and draw a color from within the same image texture, without any additional color space conversion.

The View mode of the image editor already has a sample tool, which has the functionality to show the color data in image space without additional color management. So simply using this tool in paint mode for picking color with the option to select the color space would already be a huge benefit.

Further, having a similar tool for 3D texture painting would be even better, but I assume that this might have more difficult implications for the implementation. Tackling this for the image editor first using the Sample tool, might me a good trade-off for investing a small amount of work for maximum impact.

color_picker_behaviour-2021-03-02_15.50.34.mp4
non-color_picker.blend

Reopened as, though the initial issue is invalid, the current solution, as it is, is problematic. The sample_color paint operator {key S} has a problem with discoverability and is separate from both the general UI color picker and the sample tool. This needs a better design solution. **Old Description** (resolved by sample_color operator) Right now all color picking is using the display space, which usually makes it (almost) impossible to accurately pick colors from an image that is not sRGB for texture painting. Similarly, for texture painting in the 3D viewport the picked color is that after shading and display transformation. This can be useful, but it should be optional. In a lot of cases the user wants to pick and draw a color from within the same image texture, without any additional color space conversion. The View mode of the image editor already has a sample tool, which has the functionality to show the color data in image space without additional color management. So simply using this tool in paint mode for picking color with the option to select the color space would already be a huge benefit. Further, having a similar tool for 3D texture painting would be even better, but I assume that this might have more difficult implications for the implementation. Tackling this for the image editor first using the Sample tool, might me a good trade-off for investing a small amount of work for maximum impact. [color_picker_behaviour-2021-03-02_15.50.34.mp4](https://archive.blender.org/developer/F9860531/color_picker_behaviour-2021-03-02_15.50.34.mp4) [non-color_picker.blend](https://archive.blender.org/developer/F9860533/non-color_picker.blend)
Sebastian Parborg was assigned by Simon Thommes 2021-03-02 16:13:39 +01:00
Author
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Author
Member

Added subscriber: @SimonThommes

Added subscriber: @SimonThommes
Member

Added subscriber: @Jeroen-Bakker

Added subscriber: @Jeroen-Bakker
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Similarly, for texture painting in the 3D viewport the picked color is that after shading and display transformation.

Doesnt {key S} Sample Color work for you? (Sample Merged ON is with shading information, OFF is without)

> Similarly, for texture painting in the 3D viewport the picked color is that after shading and display transformation. Doesnt {key S} Sample Color work for you? (Sample Merged ON is with shading information, OFF is without)
Author
Member

@lichtwerk

Wow.. I actually was not aware this feature existed. Thank you! Where is this exposed? I can't find any indication of this other than searching for the operator and the hotkey. This should be easier to find...

@lichtwerk Wow.. I actually was not aware this feature existed. Thank you! Where is this exposed? I can't find any indication of this other than searching for the operator and the hotkey. This should be easier to find...
Sebastian Parborg was unassigned by Simon Thommes 2021-03-02 17:41:24 +01:00
Author
Member

Added subscriber: @ZedDB

Added subscriber: @ZedDB
Author
Member

Changed status from 'Confirmed' to: 'Archived'

Changed status from 'Confirmed' to: 'Archived'
Simon Thommes changed title from Accurate color picking in image space to Find solution to unify color picking methods with options for sample space 2021-03-02 18:01:03 +01:00
Author
Member

Changed status from 'Archived' to: 'Confirmed'

Changed status from 'Archived' to: 'Confirmed'
Member

Added subscriber: @EAW

Added subscriber: @EAW
Philipp Oeser removed the
Interest
Sculpt, Paint & Texture
label 2023-02-10 09:12:01 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#86196
No description provided.