Pie menu: PIE_OT_SetObjectModePie() in space_view3d_pie_menus is not adding an undo step when executed #86707

New Issue

Henrik Berglund · 2021-03-18T16:23:42+01:00

Henrik Berglund commented

2021-03-18 16:23:42 +01:00

System Information
Operating system: Win10 64
Graphics card: GTX1070

Blender Version
Broken:
2.93 Alpha d7fb38ddd4af (and likely before)

Short description of error
PIE_OT_SetObjectModePie() in space_view3d_pie_menus is not adding an undo step when executed. For example used by gpencil mode switching and armature pose/object mode switching. This leads to the annoying behavior where if you switch a mode using a pie menu, do something (for example sculpt) and undo directly after, the mode switch is undone as well.

I fixed it temporarily by adding 'UNDO' to the operator bl_options but there's probably a nicer way since this makes the undo history say "Set the object interactive mode" instead of showing the actual mode.

Exact steps for others to reproduce the error
From startup blend: (assuming pie menus are enabled)

Add a GP Monkey.
Mode switch from Object mode to Sculpt mode using the pie menu.
Show undo history to display it without actually undoing, no mode change information is shown.
Sculpt a bit on the GP object.
Press undo.
You are in object mode again.

Expected:

Add a GP Monkey.
Mode switch from Object mode to Sculpt mode using the pie menu.
Show undo history to display it without actually undoing, "Toggle Sculpt Mode" or something similar is shown.
Sculpt a bit on the GP object.
Press undo.
You are in sculpt mode before you sculpted.

**System Information** Operating system: Win10 64 Graphics card: GTX1070 **Blender Version** Broken: 2.93 Alpha d7fb38ddd4af (and likely before) **Short description of error** PIE_OT_SetObjectModePie() in space_view3d_pie_menus is not adding an undo step when executed. For example used by gpencil mode switching and armature pose/object mode switching. This leads to the annoying behavior where if you switch a mode using a pie menu, do something (for example sculpt) and undo directly after, the mode switch is undone as well. I fixed it temporarily by adding 'UNDO' to the operator bl_options but there's probably a nicer way since this makes the undo history say "Set the object interactive mode" instead of showing the actual mode. **Exact steps for others to reproduce the error** From startup blend: (assuming pie menus are enabled) 1. Add a GP Monkey. 2. Mode switch from Object mode to Sculpt mode using the pie menu. 3. Show undo history to display it without actually undoing, no mode change information is shown. 4. Sculpt a bit on the GP object. 5. Press undo. 6. You are in object mode again. Expected: 1. Add a GP Monkey. 2. Mode switch from Object mode to Sculpt mode using the pie menu. 3. Show undo history to display it without actually undoing, "Toggle Sculpt Mode" or something similar is shown. 4. Sculpt a bit on the GP object. 5. Press undo. 6. You are in sculpt mode before you sculpted.

Henrik Berglund commented

2021-03-18 16:23:42 +01:00

Added subscriber: @cyaoeu

Omar Emara commented

2022-03-21 16:44:06 +01:00

Added subscriber: @OmarEmaraDev

Omar Emara commented

2022-03-21 16:44:06 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Omar Emara commented

2022-03-21 16:44:06 +01:00

An undo step is only necessary if the ID data are changed, so this is not considered a bug, but I will let the developer make a more informed decision.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Pie menu: PIE_OT_SetObjectModePie() in space_view3d_pie_menus is not adding an undo step when executed #86707