Page MenuHome
Create Task
Maniphest T86868

Image Editor "Erase Alpha" brush erases all channels of float images
Confirmed, NormalPublicBUG
Actions

Description

System Information
Linux 64-bit

Blender Version
Broken: 2.92
Note: In versions 2.83 and earlier, Alpha was not premultiplied (this started in rB4212b6528afb: Image Editor: Enable New Drawing, unsure if this should be the case if we are only looking at the Color without Alpha?).

Short description of error
Erasing the alpha on float images erase the RGB channels as well.

Exact steps for others to reproduce the error

  1. Open the attached file. (Left image is a Non-float while right image is Float, both have Alpha channel. We are seeing only the RGB channels).
  2. Use the brush "Erase Alpha" to erase part of the non-floating-point image (on the left).
  3. Use shift-click to sample the pixel-values of this image. The RGB channels have NOT actually been affected and the image only appears to have been premultiplied.
  4. Use the brush "Erase Alpha" on the floating-point image (on the right).
  5. Use shift-click to sample the pixel-values of this image. ALL channels were erased!

It may look like the same bug as T86866 but it isn't! The brush works as expected; it's the RGB display that's wrong.

image editor bug.blend1 MBDownload

Revisions and Commits

rB Blender
Needs ReviewD14190 Fix T86868: Image Editor "Erase/Add Alpha" brush erase/add all channels

Related Objects

Event Timeline

Sam Brubaker (rocketman) created this task.Mar 24 2021, 1:15 AM
Germano Cavalcante (mano-wii) updated the task description. (Show Details)Mar 26 2021, 4:45 PM
Germano Cavalcante (mano-wii) changed the task status from Needs Triage to Confirmed.Mar 26 2021, 4:58 PM
Germano Cavalcante (mano-wii) triaged this task as High priority.
Germano Cavalcante (mano-wii) added projects: Sculpt, Paint & Texture, Images & Movies.
Germano Cavalcante (mano-wii) changed the subtype of this task from "Report" to "Bug".
Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).

Thanks for the report, I can confirm the problem.

I don't know what the industry standard is but I think the other channels shouldn't be erased when you use an "Erase Alpha" brush.
In any case, this should be consistent across different image formats.

For the number of related reports I dare to set this bug as a high priority (for now).

(Personally, I think the pre-multiplication should be optional).
(I also mentioned about this on T86764).

Germano Cavalcante (mano-wii) added a comment.EditedMar 26 2021, 5:20 PM

@Sam Brubaker (rocketman), with the edits I made, I would say that this report was even more similar to the T86866 (sorry about that).
But the idea of the pre-multiplied alpha has already been described in other reports.
So I'll merge then.

Germano Cavalcante (mano-wii) renamed this task from Image Editor appears to multiply the RGB channels by the Alpha channels when non-float images are displayed in RGB to Image Editor "Erase Alpha" brush erases all channels.Mar 26 2021, 5:22 PM
Germano Cavalcante (mano-wii) merged a task: T86866: Image Editor "Erase Alpha" brush blending mode affects all channels.
Sam Brubaker (rocketman) added a comment.Mar 26 2021, 5:38 PM

It's a funny issue because the behavior of the Erase Alpha brush appears to be ONE bug when in fact there are two different bugs. And now I don't know which bug report is which! This is exactly what I was afraid would happen, lol

Julien Kaspar (JulienKaspar) moved this task from Backlog to Bugs on the Sculpt, Paint & Texture board.Apr 20 2021, 12:58 PM
Yuki Hashimoto (hzuika) added a subscriber: Yuki Hashimoto (hzuika).Jul 1 2021, 3:54 AM
Philipp Oeser (lichtwerk) mentioned this in T91207: In Texture Paint, "Erase Alpha" also erases colors..Sep 6 2021, 10:46 AM
Philipp Oeser (lichtwerk) merged a task: T91207: In Texture Paint, "Erase Alpha" also erases colors..
Philipp Oeser (lichtwerk) added subscribers: Tiger Y (CoderTiger), Philipp Oeser (lichtwerk).
ZYC (fatboyzz) added a subscriber: ZYC (fatboyzz).Dec 26 2021, 10:03 AM
Bastien Montagne (mont29) added a project: Core.Jan 25 2022, 11:54 AM
Bastien Montagne (mont29) removed projects: Core, Images & Movies.Jan 25 2022, 12:13 PM
Yuki Hashimoto (hzuika) added a revision: D14190: Fix T86868: Image Editor "Erase/Add Alpha" brush erase/add all channels.Feb 24 2022, 7:05 AM
Yuki Hashimoto (hzuika) added a comment.Feb 24 2022, 1:03 PM

I have submitted a patch to fix this problem.
However, I don't know if this is a bug or the default behavior.
For your information, this brush function seems to have been implemented in rB8f9150871c5f.

Yuki Hashimoto (hzuika) mentioned this in D14190: Fix T86868: Image Editor "Erase/Add Alpha" brush erase/add all channels.Feb 24 2022, 5:54 PM
Evan Wilson (EAW) added a subscriber: Evan Wilson (EAW).Feb 25 2022, 12:08 PM
Philipp Oeser (lichtwerk) updated the task description. (Show Details)Mar 25 2022, 3:04 PM
Philipp Oeser (lichtwerk) added a project: EEVEE & Viewport.
Philipp Oeser (lichtwerk) added a subscriber: Jeroen Bakker (jbakker).

CC @Jeroen Bakker (jbakker)

Jeroen Bakker (jbakker) removed a project: EEVEE & Viewport.May 9 2022, 2:52 PM

This requires a design. For images I think it should do what it says erase alpha. This means for premultiplied images it should only effect the alpha channel.
Currently it does not. There has been some discussions lately about this brush and would like the Sculpt, paint, texturing project to determine what should be done.

The image editor didn't change this behavior it only made it visible. Will remove the eevee/viewport from this issue as it isn't related to that module.

Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).May 11 2022, 3:18 PM

This is a result of float images always being associated alpha by convention. I think that given that convention, the erase brush affecting all channels is correct. If you make it affect just alpha it will be more consistent when looking at just the RGB channels, but less consistent when looking at the full RGBA channels.

It would be good to support unassociated alpha for float images, but I don't think we should change the behavior for associated alpha images.

Sam Brubaker (rocketman) added a comment.May 11 2022, 5:01 PM
In T86868#1356811, @Brecht Van Lommel (brecht) wrote:

If you make it affect just alpha it will be more consistent when looking at just the RGB channels, but less consistent when looking at the full RGBA channels.

I disagree; there are numerous cases where I am editing an image with associated alpha and would still like only to affect the alpha channel. What brush would I use then, besides "Erase Alpha"?

Julien Kaspar (JulienKaspar) lowered the priority of this task from High to Normal.May 12 2022, 10:25 AM
Julien Kaspar (JulienKaspar) added a subscriber: Julien Kaspar (JulienKaspar).

We agreed to lower the priority since this doesn't need urged fixing and has been high priority for a long time. But discussion on the issue and working towards a fix can continue.

Evan Wilson (EAW) renamed this task from Image Editor "Erase Alpha" brush erases all channels to Image Editor "Erase Alpha" brush erases all channels of float images.May 20 2022, 7:05 AM
Evan Wilson (EAW) updated the task description. (Show Details)
Julien Kaspar (JulienKaspar) mentioned this in T98590: Paint Mode: Eraser Tool.Sat, Jun 4, 4:36 PM