Replace #ifdef COM_Debug with constexpr function. #87035

New Issue

Jeroen Bakker · 2021-03-30T09:25:40+02:00

Jeroen Bakker commented

2021-03-30 09:25:40 +02:00

Currently this part of the compositor is only compiled when COM_Debug is defined. Often when we want to use it we first need to update the code to match the latest changes. When using a constexpr function this could be checked when making changes so it keeps up to date.

Goal:

Remove COM_Debug from COM_defines.h.
Add static constexr bool COM_export_graphviz() to COM_Debug.cc.

Currently this part of the compositor is only compiled when `COM_Debug` is defined. Often when we want to use it we first need to update the code to match the latest changes. When using a `constexpr` function this could be checked when making changes so it keeps up to date. Goal: * Remove `COM_Debug` from `COM_defines.h`. * Add `static constexr bool COM_export_graphviz()` to `COM_Debug.cc`.

Jeroen Bakker commented

2021-03-30 09:25:40 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jeroen Bakker commented

2021-03-30 09:25:40 +02:00

Added subscriber: @Jeroen-Bakker

Hyunseo Cho commented

2021-03-31 04:57:25 +02:00

Added subscriber: @AshleyCho

Hyunseo Cho commented

2021-03-31 04:57:25 +02:00

Hi! I managed to build Blender and I would love to contribute in any way possible. This seems like something I could handle and I would like to give it a go.
sorry- I misunderstood scope and will try to find another contribution.

Hi! I managed to build Blender and I would love to contribute in any way possible. This seems like something I could handle and I would like to give it a go. <edit> sorry- I misunderstood scope and will try to find another contribution.

Hyunseo Cho commented

2021-03-31 14:57:17 +02:00

Removed subscriber: @AshleyCho

Tyler commented

2021-04-24 19:54:04 +02:00

Added subscriber: @tsjordan

Tyler self-assigned this 2021-04-24 19:54:04 +02:00

Tyler commented

2021-04-24 19:54:04 +02:00

I think I have a good patch for this. I'll push soon.

Tyler commented

2021-04-25 01:33:03 +02:00

https://developer.blender.org/D11068
There are several ways to do this (creating a debug/nodebug object based on the constexpr), but I think this is what you're looking for. Let me know @Jeroen-Bakker

https://developer.blender.org/D11068 There are several ways to do this (creating a debug/nodebug object based on the constexpr), but I think this is what you're looking for. Let me know @Jeroen-Bakker

blender-admin commented

2021-04-28 07:56:11 +02:00

This issue was referenced by a5bb028e78

This issue was referenced by a5bb028e785c093593c270d8dcb004cb374d83cc

Jeroen Bakker commented

2021-04-28 08:04:23 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue

2021-04-28 08:04:23 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Replace #ifdef COM_Debug with constexpr function. #87035

Replace `#ifdef COM_Debug` with constexpr function. #87035