Pose bone ID property driver causes dependency cycle #87039

New Issue

Closed

opened 2021-03-30 12:20:46 +02:00 by Lukas Tönne · 10 comments

Lukas Tönne commented

2021-03-30 12:20:46 +02:00

Member

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71

Blender Version
Broken: version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: 02948a2cab
Worked: n/a

Short description of error
Two bones with ID properties of same name cause dependency cycle when one drives the other.
Workaround exists by prefixing property names.

Exact steps for others to reproduce the error

Add armature with 2 bones
In pose mode, give each bone a custom property with the same name (!)
Add a driver to one of the properties
Use "Single Property" variable and enter the data path of the other bone's property (e.g. pose.bones["Bone1"]["prop"])
Depsgraph will report a dependency cycle, apparently it cannot distinguish between bones:

Dependency cycle detected:
  OBArmature1/Parameters Component/DRIVER(pose.bones["Bone2"]["prop"]) depends on
  OBArmature1/Parameters Component/ID_PROPERTY(prop) via 'RNA Target -> Driver'
  OBArmature1/Parameters Component/DRIVER(pose.bones["Bone2"]["prop"]) via 'Driver -> Driven Property'
Detected 1 dependency cycles

Using unique property names can be used to work around this, e.g. by prefixing each property with the bone name.

Example file:
IDPropDepCycle.blend

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71 **Blender Version** Broken: version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: `02948a2cab` Worked: n/a **Short description of error** Two bones with ID properties *of same name* cause dependency cycle when one drives the other. Workaround exists by prefixing property names. **Exact steps for others to reproduce the error** * Add armature with 2 bones * In pose mode, give each bone a custom property **with the same name** (!) * Add a driver to one of the properties * Use "Single Property" variable and enter the data path of the other bone's property (e.g. `pose.bones["Bone1"]["prop"]`) Depsgraph will report a dependency cycle, apparently it cannot distinguish between bones: ``` Dependency cycle detected: OBArmature1/Parameters Component/DRIVER(pose.bones["Bone2"]["prop"]) depends on OBArmature1/Parameters Component/ID_PROPERTY(prop) via 'RNA Target -> Driver' OBArmature1/Parameters Component/DRIVER(pose.bones["Bone2"]["prop"]) via 'Driver -> Driven Property' Detected 1 dependency cycles ``` Using unique property names can be used to work around this, e.g. by prefixing each property with the bone name. Example file: [IDPropDepCycle.blend](https://archive.blender.org/developer/F9914402/IDPropDepCycle.blend)

Lukas Tönne commented

2021-03-30 12:20:46 +02:00

Author

Member

Added subscriber: @LukasTonne

Added subscriber: @LukasTonne

Germano Cavalcante commented

2021-04-01 22:58:28 +02:00

Member

Added subscriber: @mano-wii

Added subscriber: @mano-wii

Germano Cavalcante commented

2021-04-01 22:58:28 +02:00

Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2021-04-01 22:58:28 +02:00

Member

I can confirm.
Since the property is specific to the bone, its name should not conflict with the other's property name.

I can confirm. Since the property is specific to the bone, its name should not conflict with the other's property name.

Lukas Tönne self-assigned this 2021-04-02 13:07:30 +02:00

Christoph Lendenfeld commented

2022-11-24 16:30:52 +01:00

Member

Added subscribers: @dr.sybren, @ChrisLend

Added subscribers: @dr.sybren, @ChrisLend

Christoph Lendenfeld commented

2022-11-24 16:30:52 +01:00

Member

This is solved in 3.3.1 but not in 2.93.11 @dr.sybren

This is solved in 3.3.1 but not in 2.93.11 @dr.sybren

Sybren A. Stüvel commented

2022-11-28 14:54:07 +01:00

Member

This is weird, being fixed with the patch that would fix it still open & under review. @LukasTonne could you figure out which commit fixed this?

This is weird, being fixed with the patch that would fix it still open & under review. @LukasTonne could you figure out which commit fixed this?

Lukas Tönne commented

2022-11-28 16:20:50 +01:00

Author

Member

Looks like 7bcf21e66e
This is only in 3.1.0 and upwards.

Looks like 7bcf21e66e This is only in 3.1.0 and upwards.

Sybren A. Stüvel commented

2022-12-02 12:07:12 +01:00

Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'

Sybren A. Stüvel closed this issue

2022-12-02 12:07:12 +01:00

Sybren A. Stüvel commented

2022-12-02 12:07:12 +01:00

Member

Thanks for looking that up Lukas. I think it's safe enough, so I cherrypicked the commit to the blender-v2.93-release branch.

Thanks for looking that up Lukas. I think it's safe enough, so I cherrypicked the commit to the `blender-v2.93-release` branch.

Falk David referenced this issue

2023-02-10 13:03:22 +01:00

Blender LTS: Maintenance Task 2.93 #88449

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#87039

No description provided.