Page MenuHome
Create Task
Maniphest T87417

Crash when adding an object to asset with geometry nodes modifier
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: Intel(R) HD Graphics 630 Intel 4.5.0 - Build 25.20.100.6471

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-04-11 20:10, hash: rB09d7d88cc42a
Caused by rBc6ff722a1fcc: Spreadsheet: support showing data of specific node

Short description of error
Crash when adding an object to asset.
I cleaned the file and it looks like there is still something in it what make it crash. I did not manage to reproduce the crash with a new file. Don't know what can be the reason of it but without geometry node modifier it stops crashing.

Exact steps for others to reproduce the error

test.blend894 KBDownload

  1. Open the file
  2. In Outliner editor RMB on the Test object -> ID Data -> Mark Asset
  3. Crash

Revisions and Commits

rB Blender
D11240rB16bcf7dc8e70 Fix T87417: crash when evaluating geo nodes without window manager

Related Objects

Event Timeline

Sergey (randum) created this task.Apr 12 2021, 12:38 PM
Falk David (filedescriptor) changed the task status from Needs Triage to Confirmed.Apr 14 2021, 9:00 AM
Falk David (filedescriptor) added a subscriber: Falk David (filedescriptor).

I can confirm this crash on the latest 2.93.0 Alpha, branch: master, commit date: 2021-04-14 06:18, hash: rBa425b2b25c0f.
Will take a look.

Falk David (filedescriptor) added a comment.Apr 14 2021, 2:45 PM

So this crashes sometimes because the assert BLI_assert(imm->shader == nullptr); in void immBindShader(GPUShader *shader) fails. imm->shader is populated. But I think that this might just be some memory that got overwritten, so the issue might be somewhere else.

libc.so.6!__GI_raise(int sig) (raise.c:49)
libc.so.6!__GI_abort() (abort.c:79)
_BLI_assert_abort() (/blender/source/blender/blenlib/intern/BLI_assert.c:56)
immBindShader(GPUShader * shader) (/blender/source/blender/gpu/intern/gpu_immediate.cc:62)
immBindBuiltinProgram(eGPUBuiltinShader shader_id) (/blender/source/blender/gpu/intern/gpu_immediate.cc:80)
DRW_draw_cursor() (/blender/source/blender/draw/intern/draw_view.c:144)
DRW_draw_region_info() (/blender/source/blender/draw/intern/draw_view.c:56)
DRW_draw_callbacks_post_scene() (/blender/source/blender/draw/intern/draw_manager.c:1450)
DRW_draw_render_loop_ex(struct Depsgraph * depsgraph, RenderEngineType * engine_type, ARegion * region, View3D * v3d, GPUViewport * viewport, const bContext * evil_C) (/blender/source/blender/draw/intern/draw_manager.c:1644)
DRW_draw_view(const bContext * C) (/blender/source/blender/draw/intern/draw_manager.c:1513)
view3d_draw_view(const bContext * C, ARegion * region) (/blender/source/blender/editors/space_view3d/view3d_draw.c:1560)
view3d_main_region_draw(const bContext * C, ARegion * region) (/blender/source/blender/editors/space_view3d/view3d_draw.c:1582)
ED_region_do_draw(bContext * C, ARegion * region) (/blender/source/blender/editors/screen/area.c:558)
wm_draw_window_offscreen(bContext * C, wmWindow * win, _Bool stereo) (/blender/source/blender/windowmanager/intern/wm_draw.c:724)
wm_draw_window(bContext * C, wmWindow * win) (/blender/source/blender/windowmanager/intern/wm_draw.c:864)
wm_draw_update(bContext * C) (/blender/source/blender/windowmanager/intern/wm_draw.c:1065)
WM_main(bContext * C) (/blender/source/blender/windowmanager/intern/wm.c:652)
main(int argc, const char ** argv) (/blender/source/creator/creator.c:520)
Andrew Pluzhnikov (andrew_p) added a subscriber: Andrew Pluzhnikov (andrew_p).EditedMon, Apr 26, 1:50 AM

Using Windows 10 build from current ToT (hash: c204e0c38531), blender crashes every time with consistent stack trace:

blender.exe         :0x00007FF69014F900  find_sockets_to_preview C:\Users\Andrew\blender-all\blender\source\blender\modifiers\intern\MOD_nodes.cc:1193
blender.exe         :0x00007FF69014D160  compute_geometry C:\Users\Andrew\blender-all\blender\source\blender\modifiers\intern\MOD_nodes.cc:1314
blender.exe         :0x00007FF690150D50  modifyGeometry C:\Users\Andrew\blender-all\blender\source\blender\modifiers\intern\MOD_nodes.cc:1419
blender.exe         :0x00007FF68FF43540  modifier_modify_mesh_and_geometry_set C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\DerivedMesh.cc:955
blender.exe         :0x00007FF68FF42160  mesh_calc_modifiers C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\DerivedMesh.cc:1304
blender.exe         :0x00007FF68FF41E60  mesh_build_data C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\DerivedMesh.cc:1941
blender.exe         :0x00007FF68FF44730  makeDerivedMesh C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\DerivedMesh.cc:2072
blender.exe         :0x00007FF68FF20060  BKE_object_handle_data_update C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\object_update.c:204
blender.exe         :0x00007FF68FF1FD90  BKE_object_eval_uber_data C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\object_update.c:389
blender.exe         :0x00007FF6944B4CA0  blender::deg::`anonymous namespace'::evaluate_node C:\Users\Andrew\blender-all\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:115
blender.exe         :0x00007FF6944B4C50  blender::deg::`anonymous namespace'::deg_task_run_func C:\Users\Andrew\blender-all\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:127
tbb.dll             :0x00007FFC562C54A0  tbb::interface7::internal::isolate_within_arena
blender.exe         :0x00007FF69493CDF0  tbb::internal::function_task<Task>::execute C:\Users\Andrew\blender-all\lib\win64_vc15\tbb\include\tbb\task.h:1059
tbb.dll             :0x00007FFC562D54D0  tbb::recursive_mutex::scoped_lock::internal_try_acquire
tbb.dll             :0x00007FFC562D54D0  tbb::recursive_mutex::scoped_lock::internal_try_acquire
tbb.dll             :0x00007FFC562C54A0  tbb::interface7::internal::isolate_within_arena
tbb.dll             :0x00007FFC562CAA50  tbb::task_scheduler_init::terminate
tbb.dll             :0x00007FFC562D36F0  tbb::thread_bound_filter::try_process_item
tbb.dll             :0x00007FFC562D36F0  tbb::thread_bound_filter::try_process_item
ucrtbase.dll        :0x00007FFC88E40F70  beginthreadex
KERNEL32.DLL        :0x00007FFC8AB97C10  BaseThreadInitThunk
ntdll.dll           :0x00007FFC8BE6D700  RtlUserThreadStart

test.crash.txt31 KBDownload

Andrew Pluzhnikov (andrew_p) added a comment.Mon, Apr 26, 2:16 AM

Possible fix. Not sure if correct.

T87417.patch.txt1 KBDownload

Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).EditedSat, May 1, 11:28 AM

crash caused by c6ff722a1fcc632eacebcfc94417df466742ce5f

@Andrew Pluzhnikov (andrew_p) , if you want to contribute the code, refer https://wiki.blender.org/wiki/Process/Contributing_Code to submit a patch :)

Philipp Oeser (lichtwerk) updated the task description. (Show Details)Mon, May 3, 10:51 AM
Philipp Oeser (lichtwerk) triaged this task as High priority.Mon, May 3, 10:53 AM
Philipp Oeser (lichtwerk) added projects: Nodes & Physics, User Interface.
Pratik Borhade (PratikPB2123) claimed this task.Wed, May 12, 3:53 PM

Will take a look.
Single check can fix the problem, I guess

Pratik Borhade (PratikPB2123) added a revision: D11240: Fix T87417: Crash when adding an object to asset with geometry nodes modifier.Wed, May 12, 5:42 PM
Jacques Lucke (JacquesLucke) closed this task as Resolved by committing rB16bcf7dc8e70: Fix T87417: crash when evaluating geo nodes without window manager.Fri, May 14, 1:45 PM
Jacques Lucke (JacquesLucke) added a commit: rB16bcf7dc8e70: Fix T87417: crash when evaluating geo nodes without window manager.