Crash when current frame is used as driver #87688

New Issue

Lloyd · 2021-04-21T20:50:20+02:00

Lloyd commented

2021-04-21 20:50:20 +02:00

System Information
Operating system: Linux-4.15.0-142-generic-x86_64-with-glibc2.27 64 Bits
Graphics card: Mesa DRI Intel(R) HD Graphics 3000 (SNB GT2) Intel Open Source Technology Center 3.3 (Core Profile) Mesa 20.0.8

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-04-19 20:49, hash: 795f024558
Worked: 2.93 FrameDriverBug.blend

Caused by eb06ccc324

Short description of error
Blender crashes when #frame is used as driver in Geometry Nodes.

Exact steps for others to reproduce the error

Add a Geometry Node modifier to an object
Switch to the Geometry Node editor and add a Value node
Type #frame into the input field
Play the animation or change the current frame

**System Information** Operating system: Linux-4.15.0-142-generic-x86_64-with-glibc2.27 64 Bits Graphics card: Mesa DRI Intel(R) HD Graphics 3000 (SNB GT2) Intel Open Source Technology Center 3.3 (Core Profile) Mesa 20.0.8 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-04-19 20:49, hash: `795f024558` Worked: 2.93 [FrameDriverBug.blend](https://archive.blender.org/developer/F10031612/FrameDriverBug.blend) Caused by eb06ccc324 **Short description of error** Blender crashes when `#frame` is used as driver in Geometry Nodes. **Exact steps for others to reproduce the error** - Add a Geometry Node modifier to an object - Switch to the Geometry Node editor and add a *Value* node - Type `#frame` into the input field - Play the animation or change the current frame

Lloyd commented

2021-04-21 20:50:20 +02:00

Added subscriber: @LloydAlmeida

blender-admin commented

2021-04-21 20:50:20 +02:00

#87695 was marked as duplicate of this issue

Robert Guetzkow commented

2021-04-21 21:11:14 +02:00

Added subscriber: @rjg

Robert Guetzkow commented

2021-04-21 21:11:14 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Robert Guetzkow commented

2021-04-21 21:11:14 +02:00

The const AnimData *adt = BKE_animdata_from_id(id); is NULL and is dereferenced in if (adt->driver_array).

BKE_animsys_eval_driver(Depsgraph * depsgraph, ID * id, int driver_index, FCurve * fcu_orig) (/home/dev/01-data/01-git/blender-git/blender/source/blender/blenkernel/intern/anim_sys.c:3074)
blender::deg::DepsgraphNodeBuilder::<lambda(Depsgraph*)>::operator()(Depsgraph *) const(const blender::deg::DepsgraphNodeBuilder::<lambda(Depsgraph*)> * const __closure, Depsgraph * depsgraph) (/home/dev/01-data/01-git/blender-git/blender/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc:1038)
std::_Function_handler<void(Depsgraph*), blender::deg::DepsgraphNodeBuilder::build_driver(ID*, FCurve*, int)::<lambda(Depsgraph*)> >::_M_invoke(const std::_Any_data &, Depsgraph *&&)(const std::_Any_data & __functor,  __args#0) (/usr/include/c++/9/bits/std_function.h:300)
std::function<void (Depsgraph*)>::operator()(Depsgraph*) const(const std::function<void(Depsgraph*)> * const this,  __args#0) (/usr/include/c++/9/bits/std_function.h:688)
blender::deg::(anonymous namespace)::evaluate_node(const blender::deg::(anonymous namespace)::DepsgraphEvalState * state, blender::deg::OperationNode * operation_node) (/home/dev/01-data/01-git/blender-git/blender/source/blender/depsgraph/intern/eval/deg_eval.cc:113)
blender::deg::(anonymous namespace)::deg_task_run_func(TaskPool * pool, void * taskdata) (/home/dev/01-data/01-git/blender-git/blender/source/blender/depsgraph/intern/eval/deg_eval.cc:124)
Task::operator()() const::{lambda()#1}::operator()() const(const Task::<lambda()> * const __closure) (/home/dev/01-data/01-git/blender-git/blender/source/blender/blenlib/intern/task_pool.cc:118)
tbb::interface7::internal::delegated_function<Task::operator()() const::{lambda()#1} const, void>::operator()() const(const tbb::interface7::internal::delegated_function<const Task::operator()() const::<lambda()>, void> * const this) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/task_arena.h:96)
tbb::interface7::internal::isolate_within_arena(tbb::interface7::internal::delegate_base&, long) (Unknown Source:0)
tbb::interface7::internal::isolate_impl<void, Task::operator()() const::{lambda()#1} const>(Task::operator()() const::{lambda()#1} const&)(const Task::<lambda()> & f) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/task_arena.h:216)
tbb::interface7::this_task_arena::isolate<Task::operator()() const::{lambda()#1}>(tbb::interface7::internal::return_type_or_void const&)(const Task::<lambda()> & f) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/task_arena.h:472)
Task::operator()(const Task * const this) (/home/dev/01-data/01-git/blender-git/blender/source/blender/blenlib/intern/task_pool.cc:118)
tbb::internal::function_task<Task>::execute(tbb::internal::function_task<Task> * const this) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/task.h:1059)
tbb::internal::custom_scheduler<tbb::internal::IntelSchedulerTraits>::process_bypass_loop(tbb::internal::context_guard_helper<false>&, tbb::task*, long) (Unknown Source:0)
tbb::internal::custom_scheduler<tbb::internal::IntelSchedulerTraits>::local_wait_for_all(tbb::task&, tbb::task*) (Unknown Source:0)
tbb::task::wait_for_all(tbb::task * const this) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/task.h:820)
tbb::internal::task_group_base::wait(tbb::internal::task_group_base * const this) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/task_group.h:168)
tbb_task_pool_work_and_wait(TaskPool * pool) (/home/dev/01-data/01-git/blender-git/blender/source/blender/blenlib/intern/task_pool.cc:253)
BLI_task_pool_work_and_wait(TaskPool * pool) (/home/dev/01-data/01-git/blender-git/blender/source/blender/blenlib/intern/task_pool.cc:502)
blender::deg::deg_evaluate_on_refresh(blender::deg::Depsgraph * graph) (/home/dev/01-data/01-git/blender-git/blender/source/blender/depsgraph/intern/eval/deg_eval.cc:397)

The `const AnimData *adt = BKE_animdata_from_id(id);` is `NULL` and is dereferenced in `if (adt->driver_array)`. ```lines BKE_animsys_eval_driver(Depsgraph * depsgraph, ID * id, int driver_index, FCurve * fcu_orig) (/home/dev/01-data/01-git/blender-git/blender/source/blender/blenkernel/intern/anim_sys.c:3074) blender::deg::DepsgraphNodeBuilder::<lambda(Depsgraph*)>::operator()(Depsgraph *) const(const blender::deg::DepsgraphNodeBuilder::<lambda(Depsgraph*)> * const __closure, Depsgraph * depsgraph) (/home/dev/01-data/01-git/blender-git/blender/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc:1038) std::_Function_handler<void(Depsgraph*), blender::deg::DepsgraphNodeBuilder::build_driver(ID*, FCurve*, int)::<lambda(Depsgraph*)> >::_M_invoke(const std::_Any_data &, Depsgraph *&&)(const std::_Any_data & __functor, __args#0) (/usr/include/c++/9/bits/std_function.h:300) std::function<void (Depsgraph*)>::operator()(Depsgraph*) const(const std::function<void(Depsgraph*)> * const this, __args#0) (/usr/include/c++/9/bits/std_function.h:688) blender::deg::(anonymous namespace)::evaluate_node(const blender::deg::(anonymous namespace)::DepsgraphEvalState * state, blender::deg::OperationNode * operation_node) (/home/dev/01-data/01-git/blender-git/blender/source/blender/depsgraph/intern/eval/deg_eval.cc:113) blender::deg::(anonymous namespace)::deg_task_run_func(TaskPool * pool, void * taskdata) (/home/dev/01-data/01-git/blender-git/blender/source/blender/depsgraph/intern/eval/deg_eval.cc:124) Task::operator()() const::{lambda()#1}::operator()() const(const Task::<lambda()> * const __closure) (/home/dev/01-data/01-git/blender-git/blender/source/blender/blenlib/intern/task_pool.cc:118) tbb::interface7::internal::delegated_function<Task::operator()() const::{lambda()#1} const, void>::operator()() const(const tbb::interface7::internal::delegated_function<const Task::operator()() const::<lambda()>, void> * const this) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/task_arena.h:96) tbb::interface7::internal::isolate_within_arena(tbb::interface7::internal::delegate_base&, long) (Unknown Source:0) tbb::interface7::internal::isolate_impl<void, Task::operator()() const::{lambda()#1} const>(Task::operator()() const::{lambda()#1} const&)(const Task::<lambda()> & f) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/task_arena.h:216) tbb::interface7::this_task_arena::isolate<Task::operator()() const::{lambda()#1}>(tbb::interface7::internal::return_type_or_void const&)(const Task::<lambda()> & f) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/task_arena.h:472) Task::operator()(const Task * const this) (/home/dev/01-data/01-git/blender-git/blender/source/blender/blenlib/intern/task_pool.cc:118) tbb::internal::function_task<Task>::execute(tbb::internal::function_task<Task> * const this) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/task.h:1059) tbb::internal::custom_scheduler<tbb::internal::IntelSchedulerTraits>::process_bypass_loop(tbb::internal::context_guard_helper<false>&, tbb::task*, long) (Unknown Source:0) tbb::internal::custom_scheduler<tbb::internal::IntelSchedulerTraits>::local_wait_for_all(tbb::task&, tbb::task*) (Unknown Source:0) tbb::task::wait_for_all(tbb::task * const this) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/task.h:820) tbb::internal::task_group_base::wait(tbb::internal::task_group_base * const this) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/task_group.h:168) tbb_task_pool_work_and_wait(TaskPool * pool) (/home/dev/01-data/01-git/blender-git/blender/source/blender/blenlib/intern/task_pool.cc:253) BLI_task_pool_work_and_wait(TaskPool * pool) (/home/dev/01-data/01-git/blender-git/blender/source/blender/blenlib/intern/task_pool.cc:502) blender::deg::deg_evaluate_on_refresh(blender::deg::Depsgraph * graph) (/home/dev/01-data/01-git/blender-git/blender/source/blender/depsgraph/intern/eval/deg_eval.cc:397) ```

Robert Guetzkow changed title from ~~blender crashes when #frame used as Driver in Geo Nodes~~ to Crash when current frame is used as driver in Geometry Nodes

2021-04-21 21:14:22 +02:00

Lloyd commented

2021-04-21 22:04:46 +02:00

Just built master locally and it works ??

Robert Guetzkow commented

2021-04-21 22:48:40 +02:00

I've checked again and it is still broken. Dereferencing a NULL-pointer is undefined behavior, so it doesn't necessarily have to result in a crash.

Philipp Oeser commented

2021-04-22 09:34:14 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-04-22 09:34:14 +02:00

It is not just Geometry nodes, this is broken everywhere.

Philipp Oeser changed title from ~~Crash when current frame is used as driver in Geometry Nodes~~ to Crash when current frame is used as driver

2021-04-22 09:34:21 +02:00

Robert Guetzkow commented

2021-04-22 09:51:44 +02:00

Added subscriber: @zanqdo

blender-admin commented

2021-04-22 19:01:37 +02:00

This issue was referenced by bbb52a462e

This issue was referenced by bbb52a462ef91c9f84f673102b851a897b5968ac

Falk David commented

2021-04-22 19:03:30 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Falk David closed this issue

2021-04-22 19:03:30 +02:00

Falk David self-assigned this 2021-04-22 19:03:30 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash when current frame is used as driver #87688