After updated, offset broken in video editing #88263

New Issue

Ahryeom HAN · 2021-05-13T19:01:46+02:00

Ahryeom HAN commented

2021-05-13 19:01:46 +02:00

System Information
Operating system: Fedora 33
Graphics card: Nvidia

Blender Version
Broken: (example: 2.80, edbf15d3c0, master, 2018-11-28, as found on the splash screen) 2.92.0
Worked: (newest version of Blender that worked as expected) 2.83.14

Short description of error
After updated, on Video editing, on strip input panel, Image offset check box has disappeared. ( https://docs.blender.org/manual/en/2.79/editors/vse/sequencer/properties/input.html )

My old files are now broken. I was heavily relying on this option with images bigger than display. How can I fix them?

Exact steps for others to reproduce the error

temp.zip
1/ Open the attached blender file in 2.83.14. It looks fine.

2/ Open the same file in 2.92.0. Offset is broken.

**System Information** Operating system: Fedora 33 Graphics card: Nvidia **Blender Version** Broken: (example: 2.80, edbf15d3c044, master, 2018-11-28, as found on the splash screen) 2.92.0 Worked: (newest version of Blender that worked as expected) 2.83.14 **Short description of error** After updated, on Video editing, on strip input panel, Image offset check box has disappeared. ( https://docs.blender.org/manual/en/2.79/editors/vse/sequencer/properties/input.html ) My old files are now broken. I was heavily relying on this option with images bigger than display. How can I fix them? **Exact steps for others to reproduce the error** [temp.zip](https://archive.blender.org/developer/F10096848/temp.zip) 1/ Open the attached blender file in 2.83.14. It looks fine. ![Screenshot from 2021-05-13 18-58-59.png](https://archive.blender.org/developer/F10095149/Screenshot_from_2021-05-13_18-58-59.png) 2/ Open the same file in 2.92.0. Offset is broken. ![Screenshot from 2021-05-13 18-07-49.png](https://archive.blender.org/developer/F10094884/Screenshot_from_2021-05-13_18-07-49.png)

Ahryeom HAN commented

2021-05-13 19:01:46 +02:00

Added subscriber: @Aryeom

Richard Antalik commented

2021-05-13 19:25:27 +02:00

Added subscriber: @iss

Richard Antalik commented

2021-05-13 19:25:27 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Richard Antalik commented

2021-05-13 19:25:27 +02:00

In 2.92 strip transform properties were changed. Your files should be converted to this new system though. In some cases (when information about strip source resolution is missing) this is not possible.

When I open file that you have provided in 2.83 and enable offset, I get same result as you see in 2.92. in frame 9, Y position is set to -402 which is different to what you show in first image. Can you check if you uploaded correct file?

I can see small difference between 2.83 and 2.92 so that I can correct, but not as significant as you show in images here.

In 2.92 strip transform properties were changed. Your files should be converted to this new system though. In some cases (when information about strip source resolution is missing) this is not possible. When I open file that you have provided in 2.83 and enable offset, I get same result as you see in 2.92. in frame 9, Y position is set to -402 which is different to what you show in first image. Can you check if you uploaded correct file? I can see small difference between 2.83 and 2.92 so that I can correct, but not as significant as you show in images here.

Jehan Pagès commented

2021-05-13 23:24:27 +02:00

Added subscriber: @jehan

Ahryeom HAN commented

2021-05-13 23:28:15 +02:00

Thank you for answering.

Sorry, maybe I made a mistake when I copy the file.
I re-copied file and rendered expected result as a video. (s1c22.avi).
temp.zip

And I checked on 2.91.2 and it works, too.
This is the screenshot on opening this file in 2.91.2

and in 2.92.0

Thank you.

Thank you for answering. Sorry, maybe I made a mistake when I copy the file. I re-copied file and rendered expected result as a video. (s1c22.avi). [temp.zip](https://archive.blender.org/developer/F10096848/temp.zip) And I checked on 2.91.2 and it works, too. This is the screenshot on opening this file in 2.91.2 ![2.91.2.png](https://archive.blender.org/developer/F10096859/2.91.2.png) and in 2.92.0 ![2.92.0.png](https://archive.blender.org/developer/F10096864/2.92.0.png) Thank you.

Richard Antalik commented

2021-05-17 16:21:41 +02:00

Changed status from 'Needs User Info' to: 'Confirmed'

Richard Antalik commented

2021-05-17 16:21:41 +02:00

@Aryeom Thank you for new file.

Edit: 2.91 is working fine and 2.92 is not so this will be probably bug in transform properties change

@Aryeom Thank you for new file. Edit: 2.91 is working fine and 2.92 is not so this will be probably bug in transform properties change

Ahryeom HAN commented

2021-05-19 23:10:40 +02:00

@iss Ok. Thank you. :)

Richard Antalik commented

2021-05-24 07:12:44 +02:00

@Aryeom, I have looked into why there is difference and it is mainly to preserve existing animation, but I have noticed, that it was never converted anyway.

In 2.91 version, your strip has animated offset, but it is disabled.
in 2.92 offset can not be disabled anymore, therefore old animation is used and strip position is broken.

I can fix this in versioning, but that is by removing offset animation, when offset checkbox is disabled. Will this solution be OK for you?

@Aryeom, I have looked into why there is difference and it is mainly to preserve existing animation, but I have noticed, that it was never converted anyway. - In 2.91 version, your strip has animated offset, but it is disabled. - in 2.92 offset can not be disabled anymore, therefore old animation is used and strip position is broken. I can fix this in versioning, but that is by removing offset animation, when offset checkbox is disabled. Will this solution be OK for you?

Ahryeom HAN commented

2021-05-24 12:42:18 +02:00

Actually I couldn't understand your proposed choices. If I can get the same result as before, this is what I want. This way we don't have to redo all the work, right?
I didn't really understand the offset option so I didn't like the concept. So thank you for the change.

Actually I couldn't understand your proposed choices. If I can get the same result as before, this is what I want. This way we don't have to redo all the work, right? I didn't really understand the offset option so I didn't like the concept. So thank you for the change.

Richard Antalik commented

2021-05-25 04:15:56 +02:00

I have proposed only one choice, that is removing animation if it wasn't used when converting files. Animation could have been just temporarily disabled in some cases, so I did not really want to just remove elements from files without consent. That I will have to discuss more broadly though.

Since picture is worth a 1000 words, can you download experimental build temp-vse-fix-#88263 from https://builder.blender.org/download/experimental/ and check if such fix will work for you?

I have proposed only one choice, that is removing animation if it wasn't used when converting files. Animation could have been just temporarily disabled in some cases, so I did not really want to just remove elements from files without consent. That I will have to discuss more broadly though. Since picture is worth a 1000 words, can you download experimental build `temp-vse-fix-#88263` from https://builder.blender.org/download/experimental/ and check if such fix will work for you?

Ahryeom HAN commented

2021-05-28 12:26:00 +02:00

Thank you for your working. But it doesn't work ;-/
I checked with another files what I made but they are not working, neither.
I attached screen shots.

the other files

Thank you for your working. But it doesn't work ;-/ I checked with another files what I made but they are not working, neither. I attached screen shots. ![Screenshot from 2021-05-28 12-24-33.png](https://archive.blender.org/developer/F10146377/Screenshot_from_2021-05-28_12-24-33.png) the other files ![Screenshot from 2021-05-28 12-20-41.png](https://archive.blender.org/developer/F10146380/Screenshot_from_2021-05-28_12-20-41.png) ![Screenshot from 2021-05-28 12-19-52.png](https://archive.blender.org/developer/F10146379/Screenshot_from_2021-05-28_12-19-52.png)

Jehan Pagès commented

2021-05-28 12:30:59 +02:00

Hi! If I may intervene: I work with @aryeom. Basically if she worked on an animation (sometimes for many hours) and she reopens the file in a newer Blender, she needs it to be the same animation. I.e. the result must be exactly the same if she hits "Render animation" with the old and new Blender.

We don't mind if some technical logics changed, simply the old animation must be converted to new internal logics so that the result is the same.

Hi! If I may intervene: I work with @aryeom. Basically if she worked on an animation (sometimes for many hours) and she reopens the file in a newer Blender, she needs it to be the same animation. I.e. the result must be exactly the same if she hits "Render animation" with the old and new Blender. We don't mind if some technical logics changed, simply the old animation must be converted to new internal logics so that the result is the same.

Richard Antalik commented

2021-05-28 12:45:44 +02:00

In #88263#1167660, @Aryeom wrote:
Thank you for your working. But it doesn't work ;-/

I hve forgot to mention, provided file was already saveds in version 2.92, so code thinks that files were created in that version and don't need correction. If file is still broken, re-save it with version 2.91 and then open in new version.

Can you check if saving files in version 2.91 and opening in provided build will work?

> In #88263#1167660, @Aryeom wrote: > Thank you for your working. But it doesn't work ;-/ I hve forgot to mention, provided file was already saveds in version 2.92, so code thinks that files were created in that version and don't need correction. If file is still broken, re-save it with version 2.91 and then open in new version. Can you check if saving files in version 2.91 and opening in provided build will work?

Ahryeom HAN commented

2021-05-28 13:15:22 +02:00

Hmm. I never saved these files in version 2.92 because I saw the problem and I worried to mess up.
It could be the files saved more than version before.
But to be sure, I opened and saved the file in 2.91.2 and opened it again in the newer Blender.
And it still not working..

Hmm. I never saved these files in version 2.92 because I saw the problem and I worried to mess up. It could be the files saved more than version before. But to be sure, I opened and saved the file in 2.91.2 and opened it again in the newer Blender. And it still not working..

Richard Antalik commented

2021-05-28 14:20:38 +02:00

Oh no, I forgot that there was 2 files uploaded and I worked with incorrect one. Sorry for that, I will have to re-check again and make new fix.
Also I will update report so I don't get confused again.

Oh no, I forgot that there was 2 files uploaded and I worked with incorrect one. Sorry for that, I will have to re-check again and make new fix. Also I will update report so I don't get confused again.

Ahryeom HAN commented

2021-05-28 20:51:55 +02:00

Ah, ok. then I'll wait. :D
Thank you.

Ah, ok. then I'll wait. :D Thank you.

Richard Antalik commented

2021-05-31 15:56:04 +02:00

Ok I think I have found the real bug, conversion was wrong for Y axis only and all tests I have done were for X axis. I am quite surprised, that I hear about this problem only now.

Please download again build temp-vse-fix-#88263 from https://builder.blender.org/download/experimental/ and check if this fix will work.

Ok I think I have found the real bug, conversion was wrong for Y axis only and all tests I have done were for X axis. I am quite surprised, that I hear about this problem only now. Please download again build temp-vse-fix-#88263 from https://builder.blender.org/download/experimental/ and check if this fix will work.

Ahryeom HAN commented

2021-06-09 18:31:11 +02:00

It works well! ;D
Thanks for your work!

It works well! ;D Thanks for your work!

Richard Antalik commented

2021-06-10 13:34:16 +02:00

Thanks, will commit this fix then

blender-admin commented

2021-06-16 00:44:37 +02:00

This issue was referenced by 4891da8ae2

This issue was referenced by 4891da8ae22523c3ecb727f6f8be5647cbe0f51d

Richard Antalik commented

2021-06-16 00:46:04 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Richard Antalik closed this issue

2021-06-16 00:46:04 +02:00

Richard Antalik self-assigned this 2021-06-16 00:46:04 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

After updated, offset broken in video editing #88263