overlay.show_paint_wire doesn't work in vertex paint modes depending on edit mode selection #88385

New Issue

Demeter Dzadik · 2021-05-18T23:41:00+02:00

Demeter Dzadik commented

2021-05-18 23:41:00 +02:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.89

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-05-11 06:04, hash: 1151adf62d
Worked: 2.80?

Short description of error
This overlay option seems to take into account edit-mode selection

Here's what it's supposed to do:
viIeK7Tkv0.mp4

But on 2.93 and 3.0 it appears to do nothing in Weight/Vertex Paint mode if the geometry is selected in edit mode. This seems like a bug, unless it's some odd design choice?

Exact steps for others to reproduce the error

Create a cube and select all its verts in edit mode.
Enter weight paint mode
Toggle the Show Wire setting under Viewport Overlays->Weight Paint (NOT "Wireframe" under Viewport Overlays->Geometry)
Nothing happens
Switch to edit mode
Deselect all with Alt+A
Go back to weight paint mode
Wireframe display now works as expected.

Note: This now changed again in 44d2479dc3 (now it does not draw at all -- reported separately in #89880 (overlay.show_paint_wire doesn't work anymore))

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.89 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-05-11 06:04, hash: `1151adf62d` Worked: 2.80? **Short description of error** This overlay option seems to take into account edit-mode selection ![image.png](https://archive.blender.org/developer/F10124427/image.png) Here's what it's supposed to do: [viIeK7Tkv0.mp4](https://archive.blender.org/developer/F10124429/viIeK7Tkv0.mp4) But on 2.93 and 3.0 it appears to do nothing in Weight/Vertex Paint mode if the geometry is selected in edit mode. This seems like a bug, unless it's some odd design choice? **Exact steps for others to reproduce the error** - Create a cube and select all its verts in edit mode. - Enter weight paint mode - Toggle the Show Wire setting under Viewport Overlays->Weight Paint (NOT "Wireframe" under Viewport Overlays->Geometry) - Nothing happens - Switch to edit mode - Deselect all with Alt+A - Go back to weight paint mode - Wireframe display now works as expected. Note: This now changed again in 44d2479dc3 (now it does not draw **at all** -- reported separately in #89880 (overlay.show_paint_wire doesn't work anymore))

Demeter Dzadik commented

2021-05-18 23:41:00 +02:00

Added subscriber: @Mets

Demeter Dzadik changed title from ~~overlay.show_paint_wire doesn't work in weight paint mode~~ to overlay.show_paint_wire doesn't work in weight paint mode depending on edit mode selection

2021-05-18 23:45:59 +02:00

Philipp Oeser commented

2021-05-19 09:40:01 +02:00

Added subscriber: @lichtwerk

Philipp Oeser self-assigned this 2021-05-19 09:40:01 +02:00

Philipp Oeser commented

2021-05-19 09:40:01 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-05-19 09:40:01 +02:00

Can confirm, will check

Philipp Oeser commented

2021-05-19 10:28:31 +02:00

Hm, so after looking at this with fresh eyes (after coffee), I actually think this works as intended?

So the way it seems it will always take selection into account now (in vert select mode and in face select mode)
So, if everything is unselected in editmode, you'll get wires in weightpaint as well.

In vertex select mode, wire display was independent from selection in 2.80, that changed in 2.81
2.79 did not draw wires in vertex select mode at all.

Will check if the change from 2.80 to 2.81 was an intentional one now.

Hm, so after looking at this with fresh eyes (after coffee), I actually think this works as intended? So the way it seems it will **always** take selection into account now (in vert select mode and in face select mode) So, if everything is unselected in editmode, you'll get wires in weightpaint as well. In vertex select mode, wire display was independent from selection in 2.80, that changed in 2.81 2.79 did not draw wires in vertex select mode at all. Will check if the change from 2.80 to 2.81 was an intentional one now.

Philipp Oeser commented

2021-05-19 10:34:09 +02:00

In #88385#1162684, @lichtwerk wrote:
So the way it seems it will always take selection into account now (in vert select mode and in face select mode)

forgot to mention that after 2.81, it will also depend on selection if neither vertex nor face masking are used

> In #88385#1162684, @lichtwerk wrote: > So the way it seems it will **always** take selection into account now (in vert select mode and in face select mode) forgot to mention that after 2.81, it will also depend on selection if neither vertex nor face masking are used

Philipp Oeser commented

2021-05-19 10:49:57 +02:00

Changed status from 'Confirmed' to: 'Needs User Info'

Philipp Oeser commented

2021-05-19 10:49:57 +02:00

So before digging further, I'd like to know the following @Mets

are you sure this worked differently in 2.92 vs. 2.93/3.0?
are you getting the wire if everything is unselected in editmode?

So before digging further, I'd like to know the following @Mets - are you sure this worked differently in 2.92 vs. 2.93/3.0? - are you getting the wire if everything is unselected in editmode?

Demeter Dzadik commented

2021-05-19 11:36:49 +02:00

are you sure this worked differently in 2.92 vs. 2.93/3.0?

Now that I think about it, no. I edited the report after realizing that selection mattered, and because it was 2am and I was braindead, I forgot to check if the same thing is the case with earlier versions.

are you getting the wire if everything is unselected in editmode?

Yessir, that is correct. So things work as expected when everything is deselected in editmode.

If it turns out this always worked like this then... I find it rather odd design. :D

> - are you sure this worked differently in 2.92 vs. 2.93/3.0? Now that I think about it, no. I edited the report after realizing that selection mattered, and because it was 2am and I was braindead, I forgot to check if the same thing is the case with earlier versions. > - are you getting the wire if everything is unselected in editmode? Yessir, that is correct. So things work as expected when everything is deselected in editmode. If it turns out this always worked like this then... I find it rather odd design. :D

Philipp Oeser commented

2021-05-19 12:11:15 +02:00

Except for the change from 2.80 to 2.81 [in the former, wireframe was visible even with selected geometry, in the later, selection was taken into account], this seems to behave consistent across versions.

In order to have a clean report, @Mets, please also clarify this:

Enter Vertex Paint instead, and then it works.

It works correctly in Vertex Paint mode.

On my side, there is no difference in behavior between weight/vertex paint, please confirm.

Except for the change from 2.80 to 2.81 [in the former, wireframe was visible even with selected geometry, in the later, selection was taken into account], this seems to behave consistent across versions. In order to have a clean report, @Mets, please also clarify this: > Enter Vertex Paint instead, and then it works. > It works correctly in Vertex Paint mode. On my side, there is no difference in behavior between weight/vertex paint, please confirm.

Demeter Dzadik commented

2021-05-19 14:15:33 +02:00

Hmm, I could've sworn that it was always displaying the wireframe in vertex paint mode, but now that I check again, you seem to be right... Maybe I was going crazy :/ I'll update the original post with what I see happening currently.

Demeter Dzadik changed title from ~~overlay.show_paint_wire doesn't work in weight paint mode depending on edit mode selection~~ to overlay.show_paint_wire doesn't work in vertex paint modes depending on edit mode selection

2021-05-19 14:18:16 +02:00

Philipp Oeser commented

2021-05-19 15:34:44 +02:00

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2021-05-19 15:34:44 +02:00

OK, thx updating this.

At this point I think it would be good to make a design decision on this.
How do we want this to behave? Always have the wire visible? Take selection into account in face and vertex masking?

OK, thx updating this. At this point I think it would be good to make a design decision on this. How do we want this to behave? Always have the wire visible? Take selection into account in face and vertex masking?

Demeter Dzadik commented

2021-05-19 16:50:16 +02:00

I think the reason this may have been unintentional is because it's inconsistent with other methods of wireframe drawing, which don't take selection into account and also look a bit different.

overlay.show_wireframes: Draws wireframes on all objects. This takes precedent over the below options.
Object.show_wire: Draws wireframe on a single object(regardless of mode or selection state). This takes precedent over the below option.

`overlay.show_paint_wire`: This is the weird one. This draws wireframe only on the active object, only in vertex paint. Nothing wrong with this idea, but this is the only wire drawing method which also comes with weird behaviour depending on the masking mode and selection states:

- Face Masking: This seems to have its own logic for edge drawing, which is unaffected by the "Show Wires" toggle. So you're left with a checkbox that does nothing, which definitely seems unintentional.
- Vertex Masking: Draws only those edges which have both of their faces UNselected. This means you can select two vertices, and the fact that an edge has now become selected is not indicated, until you select 4 more vertices that make up 2 faces. Then the edge connecting those two faces becomes hidden. This makes no sense to me at all.
- No Masking: Same logic as in Vertex Masking, but in this state there is no way to change the vertex selection. So the edge drawing is purely for indication. But this indication indicates nothing, because there is no functionality in this mode for which vertex selection is relevant. Again, seems unintentional.

So I would be really curious what was the intended design here.
My suggestion is that when overlay.show_paint_wire is True, just draw all edges.
Vertex and Face masking modes are the only ones where selection states matter - and they already have clear ways to indicate when a vertex or a face is selected. There is no vertex painting mode where edge selection is relevant, so selection state of edges never needs to be indicated one way or another, as it just leads to confusion.

I think the reason this may have been unintentional is because it's inconsistent with other methods of wireframe drawing, which don't take selection into account and also look a bit different. - `overlay.show_wireframes`: Draws wireframes on all objects. This takes precedent over the below options. - `Object.show_wire`: Draws wireframe on a single object(regardless of mode or selection state). This takes precedent over the below option. # `overlay.show_paint_wire`: This is the weird one. This draws wireframe only on the active object, only in vertex paint. Nothing wrong with this idea, but this is the only wire drawing method which also comes with weird behaviour depending on the masking mode and selection states: - Face Masking: This seems to have its own logic for edge drawing, which is unaffected by the "Show Wires" toggle. So you're left with a checkbox that does nothing, which definitely seems unintentional. - Vertex Masking: Draws only those edges which have both of their faces UNselected. This means you can select two vertices, and the fact that an edge has now become selected is not indicated, until you select 4 more vertices that make up 2 faces. Then the edge connecting those two faces becomes hidden. This makes no sense to me at all. - No Masking: Same logic as in Vertex Masking, but in this state there is no way to change the vertex selection. So the edge drawing is purely for indication. But this indication indicates nothing, because there is no functionality in this mode for which vertex selection is relevant. Again, seems unintentional. So I would be really curious what was the intended design here. My suggestion is that when `overlay.show_paint_wire` is True, just draw all edges. Vertex and Face masking modes are the only ones where selection states matter - and they already have clear ways to indicate when a vertex or a face is selected. There is no vertex painting mode where edge selection is relevant, so selection state of edges never needs to be indicated one way or another, as it just leads to confusion.

Philipp Oeser removed their assignment 2021-05-26 11:55:50 +02:00

Philipp Oeser commented

2021-05-26 11:55:50 +02:00

Since this is now in design phase, will step down and let the module make decisions.

Daniel Salazar commented

2021-05-28 04:47:37 +02:00

Added subscriber: @zanqdo

Philipp Oeser commented

2021-07-15 16:31:50 +02:00

Note: This now changed again in 44d2479dc3 (now it does not draw at all)

Note: This now changed again in 44d2479dc3 (now it does not draw **at all**)

Germano Cavalcante commented

2021-08-16 15:27:10 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2021-08-16 15:27:10 +02:00

To solve this in code we need to remove the ibo.lines_paint_mask from batch.wire_loops. (Maybe creating another batch).
Personally I think it's a valid change.

To solve this in code we need to remove the `ibo.lines_paint_mask` from `batch.wire_loops`. (Maybe creating another batch). Personally I think it's a valid change.

Daniel Salazar commented

2022-06-07 01:15:23 +02:00

This is a bug IMO. Please don't be afraid to fix

Daniel Salazar commented

2022-06-07 01:17:13 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

overlay.show_paint_wire doesn't work in vertex paint modes depending on edit mode selection #88385

overlay.show_paint_wire: This is the weird one. This draws wireframe only on the active object, only in vertex paint. Nothing wrong with this idea, but this is the only wire drawing method which also comes with weird behaviour depending on the masking mode and selection states:

`overlay.show_paint_wire`: This is the weird one. This draws wireframe only on the active object, only in vertex paint. Nothing wrong with this idea, but this is the only wire drawing method which also comes with weird behaviour depending on the masking mode and selection states: