Texture Paint: Color Sampling ignoring Texture Interpolation setting #88440

New Issue

Jonas Meyer · 2021-05-20T21:21:24+02:00

Jonas Meyer commented

2021-05-20 21:21:24 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce RTX 3080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 462.31

Blender Version
Broken: version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: 02948a2cab
Worked: ?

Short description of error
The color picker in "Texture Painting" mode ignores the interpolation method the texture uses. It always seems to sample the color as if the texture interpolation was linear, even when it is set to something else.

Exact steps for others to reproduce the error

Open attached .blend file.
Change shading to "Rendered" or "Material Preview".
Enter Texture Paint mode.
Sample one of the colors.
Notice that the sampled color does not match what is displayed.
Change the texture interpolation to "Linear" to see that this is what is actually sampled.

blender_colorPicker_ignoringTextureSampling.blend

Expected Behaviour
Color sampler samples what the user sees in the viewport and doesn't ignore the texture interpolation.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce RTX 3080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 462.31 **Blender Version** Broken: version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: `02948a2cab` Worked: ? **Short description of error** The color picker in "Texture Painting" mode ignores the interpolation method the texture uses. It always seems to sample the color as if the texture interpolation was linear, even when it is set to something else. **Exact steps for others to reproduce the error** - Open attached .blend file. - Change shading to "Rendered" or "Material Preview". - Enter Texture Paint mode. - Sample one of the colors. - Notice that the sampled color does not match what is displayed. - Change the texture interpolation to "Linear" to see that this is what is actually sampled. [blender_colorPicker_ignoringTextureSampling.blend](https://archive.blender.org/developer/F10131471/blender_colorPicker_ignoringTextureSampling.blend) **Expected Behaviour** Color sampler samples what the user sees in the viewport and doesn't ignore the texture interpolation.

Jonas Meyer commented

2021-05-20 21:21:24 +02:00

Added subscriber: @JJG

Jonas Meyer commented

2021-05-21 00:35:25 +02:00

Also just to make this more obvious without needing to understand what I wrote above or opening the example file.

Also just to make this more obvious without needing to understand what I wrote above or opening the example file. ![texInterp_sampling.png](https://archive.blender.org/developer/F10131887/texInterp_sampling.png)

Evan Wilson commented

2021-05-21 16:20:40 +02:00

Added subscriber: @EAW

Evan Wilson commented

2021-05-21 16:20:40 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Evan Wilson commented

2021-05-21 16:20:40 +02:00

Thank you for the report. The picture is helpful for conveying the issue you are experiencing, however, I cannot reproduce the issue.
I tested 2.92, and 3.0. Are you able to have the color picker select the magenta color between the blue and the red even when the interpolation is set to closest?

Tested using:
OS: Windows-10-10.0.19041.630-SP0 64 Bits
GPU: GeForce GTX 470/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 391.35

Thank you for the report. The picture is helpful for conveying the issue you are experiencing, however, I cannot reproduce the issue. I tested 2.92, and 3.0. Are you able to have the color picker select the magenta color between the blue and the red even when the interpolation is set to `closest`? --- Tested using: OS: Windows-10-10.0.19041.630-SP0 64 Bits GPU: GeForce GTX 470/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 391.35

Jonas Meyer commented

2021-05-21 21:29:06 +02:00

Yes, the color picker seems to do all sorts of craziness for me when I use closest. Here is a video of it. Also seems like it works a bit strangely with linear interpolation.
colorsamplerTextureInterp.mp4

Yes, the color picker seems to do all sorts of craziness for me when I use closest. Here is a video of it. Also seems like it works a bit strangely with linear interpolation. [colorsamplerTextureInterp.mp4](https://archive.blender.org/developer/F10134574/colorsamplerTextureInterp.mp4)

Evan Wilson commented

2021-05-22 18:15:54 +02:00

Changed status from 'Needs User Info' to: 'Confirmed'

Evan Wilson commented

2021-05-22 18:15:54 +02:00

Added subscriber: @lichtwerk

Evan Wilson commented

2021-05-22 18:15:54 +02:00

Ah, I was using the E shortcut over the color bar, which activates the eyedropper modal, which confirms the sample upon mouse release. I was just clicking (press & release) at single points.
I can confirm that the S sampling shortcut does indeed sample using linear interpolation in the 3D viewport, unless Samples Merged is checked.
Looking at the key map, I see that the eyedropper modal will continuously sample as long as the left mouse button is held down. This too samples using linear interpolation.

I don't think this is technically a bug, as void paint_sample_color has bilinear_interpolation_color_wrap.
I will mark as confirmed based off of @lichtwerk's confirming #88300 (Color Picker in texture mode sampling incorrect values (sample merged OFF, sampling from another object)) as a TODO.

Ah, I was using the `E` shortcut over the color bar, which activates the eyedropper modal, which confirms the sample upon mouse release. I was just clicking (press & release) at single points. I can confirm that the `S` sampling shortcut does indeed sample using linear interpolation in the 3D viewport, unless `Samples Merged` is checked. Looking at the key map, I see that the eyedropper modal will continuously sample as long as the left mouse button is held down. This too samples using linear interpolation. I don't think this is technically a bug, as [void paint_sample_color](https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/sculpt_paint/paint_utils.c$453) has `bilinear_interpolation_color_wrap`. I will mark as confirmed based off of @lichtwerk's confirming #88300 (Color Picker in texture mode sampling incorrect values (sample merged OFF, sampling from another object)) as a `TODO`.

Jonas Meyer commented

2021-05-23 12:31:50 +02:00

I was not able to sample the correct colors with E either, the behavior seemed identical to the one seen in the video where I use S .
I would argue that void_paint_sample_color should sample what a user actually sees instead of something completely different, there is no way for a user to look at the current behavior and conclude that it makes sense, a user would probably just think it is broken.

Also naive question but couldn't a lot of this be solved by sampling directly from the DiffuseColor buffer? The same one you can access from EEVEE.

I was not able to sample the correct colors with `E` either, the behavior seemed identical to the one seen in the video where I use `S` . I would argue that [void_paint_sample_color](https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/sculpt_paint/paint_utils.c$453) should sample what a user actually sees instead of something completely different, there is no way for a user to look at the current behavior and conclude that it makes sense, a user would probably just think it is broken. Also naive question but couldn't a lot of this be solved by sampling directly from the `DiffuseColor` buffer? The same one you can access from EEVEE.

Philipp Oeser commented

2022-05-11 11:33:13 +02:00

This was actually fixed by 0d43ff43a4, no ?

This was actually fixed by 0d43ff43a4, no ?

Philipp Oeser commented

2022-05-11 11:36:25 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2022-05-11 11:36:25 +02:00

Philipp Oeser self-assigned this 2022-05-11 11:36:25 +02:00

Philipp Oeser commented

2022-05-11 11:36:25 +02:00

In #88440#1356614, @lichtwerk wrote:
This was actually fixed by 0d43ff43a4, no ?

Seems so, will close this as resolved, feel free to comment again if this is a misunderstanding (we can always reopen in such case)

> In #88440#1356614, @lichtwerk wrote: > This was actually fixed by 0d43ff43a4, no ? Seems so, will close this as resolved, feel free to comment again if this is a misunderstanding (we can always reopen in such case)

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Texture Paint: Color Sampling ignoring Texture Interpolation setting #88440