Crash when a multi-input Geometry socket has at least one uninitialized noodle in 3.0 alpha #89122

New Issue

Fen · 2021-06-13T22:37:13+02:00

Fen commented

2021-06-13 22:37:13 +02:00

System Information
Operating system: Linux-5.8.0-55-generic-x86_64-with-glibc2.31 64 Bits
Graphics card: Quadro K1000M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.143

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-06-13 05:13, hash: 0f68e5c30a
Worked: 2.93 does not crash

This also crashes on an older version of the 3.0.0 Alpha -- blender-3.0.0-alpha+master.f5d14e36e8a0-linux.x86_64-release -- although I was also getting some unreachable code warnings in some cases.

Short description of error
Some geometry nodes accept multiple Geometry inputs in one socket. If such a multi-input socket has two or more noodles going into it, and at least one of the noodles is uninitialized (from a Group Input where an instance of the group doesn't have anything plugged in), Blender crashes.

Exact steps for others to reproduce the error

Go into the Geometry Nodes tab
Create a new Geometry Nodes modifier on the starting cube
Create a Boolean node. Don't connect it to anything.
Press ctrl-g to make a new group out of this node.
Press ctrl-tab to exit the group view. Connect the Geometry output of the group to the Group Output
Press tab to re-enter the group view.
Drag from Geometry 1 on the Group Input node to Geometry 1 on the Boolean node
Crash

alternatively

Drag from Geometry 1 on the Group Input node to Geometry 2 on the Boolean node

alternatively

Create a new node that outputs Geometry, and plug it into Geometry 2 on the Boolean node

The output of the Boolean mode must be plugged into the Group Output node of the modifier. If it's disconnected, nothing happens, presumably because it isn't evaluated.

I've attached a file that ends at step 6. You should be able to immediately crash Blender with it. I've also attached the crash logs.

geometry-crash.blend

geometry-crash.crash.txt

**System Information** Operating system: Linux-5.8.0-55-generic-x86_64-with-glibc2.31 64 Bits Graphics card: Quadro K1000M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.143 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-06-13 05:13, hash: `0f68e5c30a` Worked: 2.93 does not crash This also crashes on an older version of the 3.0.0 Alpha -- `blender-3.0.0-alpha+master.f5d14e36e8a0-linux.x86_64-release` -- although I was also getting some unreachable code warnings in some cases. **Short description of error** Some geometry nodes accept multiple Geometry inputs in one socket. If such a multi-input socket has two or more noodles going into it, and at least one of the noodles is uninitialized (from a Group Input where an instance of the group doesn't have anything plugged in), Blender crashes. **Exact steps for others to reproduce the error** 1. Go into the *Geometry Nodes* tab 2. Create a new Geometry Nodes modifier on the starting cube 3. Create a Boolean node. Don't connect it to anything. 4. Press ctrl-g to make a new group out of this node. 5. Press ctrl-tab to exit the group view. Connect the *Geometry* output of the group to the Group Output 6. Press tab to re-enter the group view. 7. Drag from *Geometry 1* on the Group Input node to *Geometry 1* on the Boolean node 8. Crash *alternatively* 7. Drag from *Geometry 1* on the Group Input node to *Geometry 2* on the Boolean node *alternatively* 7. Create a new node that outputs Geometry, and plug it into *Geometry 2* on the Boolean node The output of the Boolean mode must be plugged into the Group Output node of the modifier. If it's disconnected, nothing happens, presumably because it isn't evaluated. I've attached a file that ends at step 6. You should be able to immediately crash Blender with it. I've also attached the crash logs. [geometry-crash.blend](https://archive.blender.org/developer/F10169961/geometry-crash.blend) [geometry-crash.crash.txt](https://archive.blender.org/developer/F10169963/geometry-crash.crash.txt)

Fen commented

2021-06-13 22:37:13 +02:00

Added subscriber: @chemicalcrux

blender-admin commented

2021-06-13 22:37:13 +02:00

#89296 was marked as duplicate of this issue

Richard Antalik commented

2021-06-14 03:46:17 +02:00

Added subscriber: @iss

Richard Antalik commented

2021-06-14 03:46:17 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Richard Antalik commented

2021-06-14 03:46:17 +02:00

Please check if this happens with latest alpha, I was not able to reproduce the crash.

In step 4 group has already all group inputs/outputs connected to boolean node, so in step 7 should I drag another noodle?

Please check if this happens with latest alpha, I was not able to reproduce the crash. In step 4 group has already all group inputs/outputs connected to boolean node, so in step 7 should I drag another noodle?

Fen commented

2021-06-14 04:15:48 +02:00

Correct, all of the wires will already be connected. Dragging any wire from the Group Input node into the Geometry 1 input on the Boolean node causes a crash for me.

I'm working with the head of the master branch right now (commit 0f68e5c30a7fe91e9393415a058933d7c5dcf32d). My internet is very slow right now, so I can try grabbing a pre-compiled alpha off of the website in two days, once I'm somewhere faster again.

Correct, all of the wires will already be connected. Dragging any wire from the Group Input node into the *Geometry 1* input on the Boolean node causes a crash for me. ![image.png](https://archive.blender.org/developer/F10170283/image.png) I'm working with the head of the master branch right now (commit `0f68e5c30a7fe91e9393415a058933d7c5dcf32d`). My internet is very slow right now, so I can try grabbing a pre-compiled alpha off of the website in two days, once I'm somewhere faster again.

Fen commented

2021-06-14 05:45:37 +02:00

The crash was first introduced by b084b57fbf, which brought in a new geometry nodes evaluator. It doesn't crash before that point, and it consistently crashes after that point (although I do get an extra unreachable code error on that commit).

Also, I did manage to pull down the latest alpha -- 54a03d4247cc -- and I got the crash.

One more note: It looks like I was mistaken about the cause of the crash. If I leave the multi-input unconnected, it doesn't crash when a noodle gets pushed down into it.

Instead, it appears that it just crashes whenever a multi-input Geometry socket has at least two noodles going into it and where one of them is uninitialized.

I've updated the task accordingly.

The crash was first introduced by b084b57fbf6d2b6c2a1adb2192f5d82581cede5c, which brought in a new geometry nodes evaluator. It doesn't crash before that point, and it consistently crashes after that point (although I do get an extra unreachable code error on that commit). Also, I did manage to pull down the latest alpha -- `54a03d4247cc` -- and I got the crash. One more note: It looks like I was mistaken about the cause of the crash. If I leave the multi-input unconnected, it doesn't crash when a noodle gets pushed down into it. Instead, it appears that it just crashes whenever a multi-input Geometry socket has at least two noodles going into it *and* where one of them is uninitialized. I've updated the task accordingly.

Fen changed title from ~~Crash when an uninitialized geometry noodle is involved in a move from a single-input socket to a multi-input socket in 3.0 alpha~~ to Crash when a multi-input Geometry socket has at least one uninitialized noodle in 3.0 alpha

2021-06-14 06:13:07 +02:00

Pratik Borhade commented

2021-06-20 15:26:23 +02:00

Added subscriber: @brunnerh

Pratik Borhade commented

2021-06-20 15:27:39 +02:00

Changed status from 'Needs User Info' to: 'Confirmed'

Pratik Borhade commented

2021-06-20 15:37:35 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-06-20 15:37:35 +02:00

Can confirm the crash for 3.0.0 (033641aa74) and also for 2.93.0LTS.

blender.exe         :0x00007FF6FEFE0110  blender::move_assign_container<blender::Array<blender::SimpleMapSlot<enum GeometryComponentType,ble
blender.exe         :0x00007FF6FF03ED60  blender::Map<enum GeometryComponentType,blender::UserCounter<GeometryComponent>,4,blender::PythonPr
blender.exe         :0x00007FF6FF5A73F0  blender::uninitialized_move_n<GeometrySet>
blender.exe         :0x00007FF6FF53F2B0  blender::modifiers::geometry_nodes::GeometryNodesEvaluator::execute
blender.exe         :0x00007FF6FF53EDF0  blender::modifiers::geometry_nodes::evaluate_geometry_nodes
blender.exe         :0x00007FF6FF47A020  compute_geometry
blender.exe         :0x00007FF6FF47B4C0  modifyGeometry
blender.exe         :0x00007FF6FF251B00  modifier_modify_mesh_and_geometry_set
blender.exe         :0x00007FF6FF250700  mesh_calc_modifiers
blender.exe         :0x00007FF6FF250400  mesh_build_data
blender.exe         :0x00007FF6FF252CF0  makeDerivedMesh
blender.exe         :0x00007FF6FF22E1D0  BKE_object_handle_data_update
blender.exe         :0x00007FF6FF22DF00  BKE_object_eval_uber_data
blender.exe         :0x00007FF70381FC50  blender::deg::`anonymous namespace'::evaluate_node
blender.exe         :0x00007FF70381FC00  blender::deg::`anonymous namespace'::deg_task_run_func
blender.exe         :0x00007FF703CA58A0  tbb::internal::function_task<Task>::execute
tbb.dll             :0x00007FFDA389F690  tbb::recursive_mutex::scoped_lock::internal_try_acquire
tbb.dll             :0x00007FFDA389F690  tbb::recursive_mutex::scoped_lock::internal_try_acquire
tbb.dll             :0x00007FFDA38951B0  tbb::interface7::internal::isolate_within_arena
tbb.dll             :0x00007FFDA389A470  tbb::task_scheduler_init::terminate
tbb.dll             :0x00007FFDA389DBD0  tbb::thread_bound_filter::try_process_item
tbb.dll             :0x00007FFDA389DBD0  tbb::thread_bound_filter::try_process_item
ucrtbase.dll        :0x00007FFDABDC1B20  configthreadlocale
KERNEL32.DLL        :0x00007FFDAC467020  BaseThreadInitThunk
ntdll.dll           :0x00007FFDADFC2630  RtlUserThreadStart```

Can confirm the crash for 3.0.0 (`033641aa74`) and also for 2.93.0LTS. ```Stack trace: blender.exe :0x00007FF6FEFE0110 blender::move_assign_container<blender::Array<blender::SimpleMapSlot<enum GeometryComponentType,ble blender.exe :0x00007FF6FF03ED60 blender::Map<enum GeometryComponentType,blender::UserCounter<GeometryComponent>,4,blender::PythonPr blender.exe :0x00007FF6FF5A73F0 blender::uninitialized_move_n<GeometrySet> blender.exe :0x00007FF6FF53F2B0 blender::modifiers::geometry_nodes::GeometryNodesEvaluator::execute blender.exe :0x00007FF6FF53EDF0 blender::modifiers::geometry_nodes::evaluate_geometry_nodes blender.exe :0x00007FF6FF47A020 compute_geometry blender.exe :0x00007FF6FF47B4C0 modifyGeometry blender.exe :0x00007FF6FF251B00 modifier_modify_mesh_and_geometry_set blender.exe :0x00007FF6FF250700 mesh_calc_modifiers blender.exe :0x00007FF6FF250400 mesh_build_data blender.exe :0x00007FF6FF252CF0 makeDerivedMesh blender.exe :0x00007FF6FF22E1D0 BKE_object_handle_data_update blender.exe :0x00007FF6FF22DF00 BKE_object_eval_uber_data blender.exe :0x00007FF70381FC50 blender::deg::`anonymous namespace'::evaluate_node blender.exe :0x00007FF70381FC00 blender::deg::`anonymous namespace'::deg_task_run_func blender.exe :0x00007FF703CA58A0 tbb::internal::function_task<Task>::execute tbb.dll :0x00007FFDA389F690 tbb::recursive_mutex::scoped_lock::internal_try_acquire tbb.dll :0x00007FFDA389F690 tbb::recursive_mutex::scoped_lock::internal_try_acquire tbb.dll :0x00007FFDA38951B0 tbb::interface7::internal::isolate_within_arena tbb.dll :0x00007FFDA389A470 tbb::task_scheduler_init::terminate tbb.dll :0x00007FFDA389DBD0 tbb::thread_bound_filter::try_process_item tbb.dll :0x00007FFDA389DBD0 tbb::thread_bound_filter::try_process_item ucrtbase.dll :0x00007FFDABDC1B20 configthreadlocale KERNEL32.DLL :0x00007FFDAC467020 BaseThreadInitThunk ntdll.dll :0x00007FFDADFC2630 RtlUserThreadStart```

blender-admin commented

2021-06-21 12:15:32 +02:00

This issue was referenced by 4968a0bdf9

This issue was referenced by 4968a0bdf9ec16134a545678eabb922f04ed8315

Jacques Lucke commented

2021-06-21 12:16:45 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jacques Lucke closed this issue

2021-06-21 12:16:45 +02:00

Jacques Lucke self-assigned this 2021-06-21 12:16:45 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash when a multi-input Geometry socket has at least one uninitialized noodle in 3.0 alpha #89122