Not optmized bpy.data.screens for some Workspaces in template files #89187

New Issue

Paulo José Oliveira Amaro · 2021-06-16T02:22:31+02:00

2021-06-16 02:22:31 +02:00

System Information
Operating system: Windows 10

Blender Version
Broken: 2.93.0

Short description of error
In Blender, each workspace adds a screen struct at bpy.data.screens.
For instance, the "Animation" workspace adds a "Animation" screen at bpy.data.screens["Animation"].
{F10173259, size=full}
That's the expected behavior.

But some workspaces, like "Video Editing", add an extra screen with generic names, like "Default.024" and "Default.025".
{F10173268, size=full}

Looking further, I could easily redo the "Video Editing" workspace from scratch with only one screen:
Current:
Fixed:

There is no visual difference that could justify the extra screen.

Affected workspaces
Not optimized workspaces and the screens they add:

Workspace	Screen
2D Animation > 2D Animation	"2D Animation", "Default.009"
2D Animation > 2D Full Canvas	"2D Full Canvas", "Default.001"
2D Animation > Compositing	"Compositing", "Default.016"
2D Animation > Rendering	"Rendering", "Default.020"
Sculpting > Sculpting	"Default.012"
Sculpting > Shading	"Default.003"
VFX > Compositing	"Default.021", "Default.022"
VFX > Masking	"Default.025", "Default.026"
VFX > Motion Tracking	"Default.000", "Default.001"
VFX > Rendering	"Default.019", "Default.020"
Video Editing > Rendering	"Default.019", "Default.020"
Video Editing > Video Editing	"Default.024", "Default.025"

Steps to reproduce the issue

Delete all workspaces, and leave just "Layout"
File > Clean Up > Unused Data Blocks
Outliner > display mode "Blender File" > expand "Screens"
There should be only one screen called "Layout"
Add one of the affected workspaces
Check the new screens in the Outliner

Workaround
It was easy to correct screen names, but I couldn't find a way to remove extra screens through the UI or bpy.
Each copy of an affected workspace also duplicate the extra screen, and it can't be dissociated.
So I remade the affected workspaces from scratch using only one screen, and replaced the template files in:
{BLENDER_SYSTEM_SCRIPTS}\startup\bl_app_templates_system
In my system it is in:
"C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\startup\bl_app_templates_system"

The fixed files: bl_app_templates_system.zip

Fixed workspaces:
Optimized workspaces and the screen they add:

Workspace	Screen
2D Animation > 2D Animation	"2D Animation"
2D Animation > 2D Full Canvas	"2D Full Canvas"
2D Animation > Compositing	"Compositing"
2D Animation > Rendering	"Rendering"
Sculpting > Sculpting	"Sculpting"
Sculpting > Shading	"Shading"
VFX > Compositing	"Compositing"
VFX > Masking	"Masking"
VFX > Motion Tracking	"Motion Tracking"
VFX > Rendering	"Rendering"
Video Editing > Rendering	"Rendering"
Video Editing > Video Editing	"Video Editing"

The actual fix
If this bug is confirmed, would it be enough to patch these files?
I feel like the real bug may be what's causing a workspace to have extra screens.
Maybe something that was fixed ages ago, but still after the templates were created?
I couldn't reproduce the behavior of adding a new workspace with extra screens by copying a non affected workspace.

**System Information** Operating system: Windows 10 **Blender Version** Broken: 2.93.0 **Short description of error** In Blender, each workspace adds a screen struct at `bpy.data.screens`. For instance, the "Animation" workspace adds a "Animation" screen at `bpy.data.screens["Animation"]`. {[F10173259](https://archive.blender.org/developer/F10173259/workspace-animation.png), size=full} That's the expected behavior. But some workspaces, like "Video Editing", add an extra screen with generic names, like "Default.024" and "Default.025". {[F10173268](https://archive.blender.org/developer/F10173268/workspace-video-editing.png), size=full} Looking further, I could easily redo the "Video Editing" workspace from scratch with only one screen: Current: ![workspace-video-editing-full-bug.png](https://archive.blender.org/developer/F10173349/workspace-video-editing-full-bug.png) Fixed: ![workspace-video-editing-full-fixed.png](https://archive.blender.org/developer/F10173355/workspace-video-editing-full-fixed.png) There is no visual difference that could justify the extra screen. **Affected workspaces** Not optimized workspaces and the screens they add: | Workspace | Screen | -- | -- | | 2D Animation > 2D Animation | "2D Animation", "Default.009" | 2D Animation > 2D Full Canvas | "2D Full Canvas", "Default.001" | 2D Animation > Compositing | "Compositing", "Default.016" | 2D Animation > Rendering | "Rendering", "Default.020" | Sculpting > Sculpting | "Default.012" | Sculpting > Shading | "Default.003" | VFX > Compositing | "Default.021", "Default.022" | VFX > Masking | "Default.025", "Default.026" | VFX > Motion Tracking | "Default.000", "Default.001" | VFX > Rendering | "Default.019", "Default.020" | Video Editing > Rendering | "Default.019", "Default.020" | Video Editing > Video Editing | "Default.024", "Default.025" **Steps to reproduce the issue** * Delete all workspaces, and leave just "Layout" * File > Clean Up > Unused Data Blocks * Outliner > display mode "Blender File" > expand "Screens" * There should be only one screen called "Layout" * Add one of the affected workspaces * Check the new screens in the Outliner **Workaround** It was easy to correct screen names, but I couldn't find a way to remove extra screens through the UI or bpy. Each copy of an affected workspace also duplicate the extra screen, and it can't be dissociated. So I remade the affected workspaces from scratch using only one screen, and replaced the template files in: `{BLENDER_SYSTEM_SCRIPTS}\startup\bl_app_templates_system` In my system it is in: `"C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\startup\bl_app_templates_system"` The fixed files: [bl_app_templates_system.zip](https://archive.blender.org/developer/F10173768/bl_app_templates_system.zip) **Fixed workspaces:** Optimized workspaces and the screen they add: | Workspace | Screen | -- | -- | | 2D Animation > 2D Animation | "2D Animation" | 2D Animation > 2D Full Canvas | "2D Full Canvas" | 2D Animation > Compositing | "Compositing" | 2D Animation > Rendering | "Rendering" | Sculpting > Sculpting | "Sculpting" | Sculpting > Shading | "Shading" | VFX > Compositing | "Compositing" | VFX > Masking | "Masking" | VFX > Motion Tracking | "Motion Tracking" | VFX > Rendering | "Rendering" | Video Editing > Rendering | "Rendering" | Video Editing > Video Editing | "Video Editing" **The actual fix** If this bug is confirmed, would it be enough to patch these files? I feel like the real bug may be what's causing a workspace to have extra screens. Maybe something that was fixed ages ago, but still after the templates were created? I couldn't reproduce the behavior of adding a new workspace with extra screens by copying a non affected workspace.

Paulo José Oliveira Amaro commented

2021-06-16 02:22:31 +02:00

Added subscriber: @PauloJoseOliveiraAmaro

Richard Antalik commented

2021-06-24 18:36:33 +02:00

Added subscriber: @iss

Richard Antalik commented

2021-06-24 18:36:33 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2021-06-24 18:36:33 +02:00

Can you summarize what change was needed to get nice name for screens? If you changed .blend files in templates this should be probably done through versioning, rather than patching .blend files.

I can reproduce this issue, so will confirm.

Can you summarize what change was needed to get nice name for screens? If you changed .blend files in templates this should be probably done through versioning, rather than patching .blend files. I can reproduce this issue, so will confirm.

Paulo José Oliveira Amaro commented

2021-07-27 22:09:33 +02:00

@iss I just recreated the workspace using the good template, adding new workspaces, then splitting existing regions and set them up exactly like the problematic ones. Then I renamed the new screens accordingly. No much to tell about it, I guess.

In #89187#1182242, @iss wrote:
Can you summarize what change was needed to get nice name for screens? If you changed .blend files in templates this should be probably done through versioning, rather than patching .blend files.

I can reproduce this issue, so will confirm.

@iss I just recreated the workspace using the good template, adding new workspaces, then splitting existing regions and set them up exactly like the problematic ones. Then I renamed the new screens accordingly. No much to tell about it, I guess. > In #89187#1182242, @iss wrote: > Can you summarize what change was needed to get nice name for screens? If you changed .blend files in templates this should be probably done through versioning, rather than patching .blend files. > > I can reproduce this issue, so will confirm.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Not optmized bpy.data.screens for some Workspaces in template files #89187