Parenting breaks extract operations in sculpt mode #89603

New Issue

Julien Kaspar · 2021-07-02T15:50:06+02:00

Julien Kaspar commented

2021-07-02 15:50:06 +02:00

System Information
Operating system: Linux-5.4.0-77-generic-x86_64-with-glibc2.31 64 Bits
Graphics card: Quadro GP100/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.80

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-07-02 04:03, hash: 9f5c0ffb5e

Short description of error
If an object is parented to another it will not take the position of the parent into account when extracting geometry from sculpt mode.
For example I can parent the object to an empty and move the empty. As a result the empty will have translation values but the main object does not.
If I now mask off some of the surface and use "Mask Extract" or "Mask Slice to New Object" it will only use the relative position of the object in relation to its parent instead of the actual position in the Scene and position the extracted geometry in the wrong location.
In the case of mask extract this will completely break since it will try to shrinkwrap the extracted geoemtry back onto the original object but from the wrong location.

Exact steps for others to reproduce the error
2021-07-02 15-44-32.mp4

**System Information** Operating system: Linux-5.4.0-77-generic-x86_64-with-glibc2.31 64 Bits Graphics card: Quadro GP100/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.80 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-07-02 04:03, hash: `9f5c0ffb5e` **Short description of error** If an object is parented to another it will not take the position of the parent into account when extracting geometry from sculpt mode. For example I can parent the object to an empty and move the empty. As a result the empty will have translation values but the main object does not. If I now mask off some of the surface and use "Mask Extract" or "Mask Slice to New Object" it will only use the relative position of the object in relation to its parent instead of the actual position in the Scene and position the extracted geometry in the wrong location. In the case of mask extract this will completely break since it will try to shrinkwrap the extracted geoemtry back onto the original object but from the wrong location. **Exact steps for others to reproduce the error** [2021-07-02 15-44-32.mp4](https://archive.blender.org/developer/F10209585/2021-07-02_15-44-32.mp4)

Julien Kaspar commented

2021-07-02 15:50:06 +02:00

Added subscriber: @JulienKaspar

blender-admin commented

2021-07-02 15:50:06 +02:00

#103753 was marked as duplicate of this issue

Pablo Dobarro commented

2021-07-02 18:02:27 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2023-01-10 11:14:12 +01:00

Added subscriber: @PratikPB2123

Philipp Oeser self-assigned this 2023-01-10 12:24:16 +01:00

Philipp Oeser commented

2023-01-10 18:18:36 +01:00

@JulienKaspar : would it be preferred to make this consistent with Mesh > Separate > Selection in that the new object would keep the parenting relationship as well as scale from the source object?
At the moment, you are getting an object outside the parenting hierarchy and with a scale of 1.

@JulienKaspar : would it be preferred to make this consistent with `Mesh` > `Separate` > `Selection` in that the new object would keep the parenting relationship as well as scale from the source object? At the moment, you are getting an object outside the parenting hierarchy and with a scale of 1.

Julien Kaspar commented

2023-01-10 19:47:54 +01:00

@lichtwerk I think your suggestion is great. That would be best and more consistent.

Philipp Oeser commented

2023-01-11 09:58:44 +01:00

Also noticed that it doesnt preserve materials (which should be done I think?)

Philipp Oeser commented

2023-01-11 10:02:14 +01:00

Also noticed that the name for the new object is just "Mesh" (which should be based on the name of the object this was extracted from I think?)

Philipp Oeser commented

2023-01-11 10:09:30 +01:00

The way the new object is created in editmesh_mask_extract.c also causes #103773 (Assert hit on executing mask extract operations) btw...
I think when addressing the points above, we can also switch to a method that would eliminate the assert from #103773.

The way the new object is created in `editmesh_mask_extract.c` also causes #103773 (Assert hit on executing mask extract operations) btw... I think when addressing the points above, we can also switch to a method that would eliminate the assert from #103773.

Julien Kaspar commented

2023-01-11 11:38:43 +01:00

All that sounds great! From what I read the the past these mask operators are not that well coded in the first place.
If you can fix these issues that would be fantastic!

All that sounds great! From what I read the the past these mask operators are not that well coded in the first place. If you can fix these issues that would be fantastic!

Pratik Borhade commented

2023-01-11 11:55:07 +01:00

Hi @lichtwerk , looks like you're working on this
Submitted the patch yesterday, turns out shirnkwrap option is not positioning new mesh vertices correctly
I think more modelling/transform knowledge is required to solve it.
I'll close my patch since it only handles one case

Hi @lichtwerk , looks like you're working on this Submitted the [patch ](https://developer.blender.org/D16962) yesterday, turns out `shirnkwrap` option is not positioning new mesh vertices correctly I think more modelling/transform knowledge is required to solve it. I'll close my patch since it only handles one case

Philipp Oeser commented

2023-01-11 12:34:07 +01:00

Sorry for the duplicate efforts @PratikPB2123

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Parenting breaks extract operations in sculpt mode #89603