Cloth disk cache is not read on library overrides when original linked data is already set to use 'Disk Cache' #89771

New Issue

Daniel Salazar · 2021-07-10T08:20:43+02:00

Daniel Salazar commented

2021-07-10 08:20:43 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.11

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-07-09 23:23, hash: 62d9dabc7d

Short description of error
Baking cloth with file disk cache used to work. Now it will get ignored on reload

Exact steps for others to reproduce the error
Unpack the following zip
Cloth Library Override.zip
Open Library Override.blend
Make sure Disk Cache is enabled and Use Library Path is disabled

Click Bake
Save
Reload
The cloth simulation is gone

Here's a video of the problem
2021-07-12 14-19-07.mp4

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.11 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-07-09 23:23, hash: `62d9dabc7d` **Short description of error** Baking cloth with file disk cache used to work. Now it will get ignored on reload **Exact steps for others to reproduce the error** Unpack the following zip [Cloth Library Override.zip](https://archive.blender.org/developer/F10219339/Cloth_Library_Override.zip) Open Library Override.blend Make sure Disk Cache is enabled and Use Library Path is disabled ![image.png](https://archive.blender.org/developer/F10219346/image.png) Click Bake Save Reload The cloth simulation is gone Here's a video of the problem [2021-07-12 14-19-07.mp4](https://archive.blender.org/developer/F10222200/2021-07-12_14-19-07.mp4)

Daniel Salazar commented

2021-07-10 08:20:43 +02:00

Added subscriber: @zanqdo

Daniel Salazar changed title from ~~Cloth disk cache is not read on library overrides~~ to Cloth disk cache is not read on library overrides (regression)

2021-07-10 08:39:20 +02:00

Pratik Borhade commented

2021-07-10 14:13:40 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-07-10 14:13:40 +02:00

The cloth simulation is gone

Can not reproduce with provided steps on 3.0.0 (62d9dabc7d).

System Information

Graphics card : AMD Radeon(TM) 535 ATI Technologies .```

@zanqdo , can you please mention the working version also?

>The cloth simulation is gone Can not reproduce with provided steps on 3.0.0 (`62d9dabc7d`). --- **System Information** ```Operating system : Windows-10-10.0.18362-SP0 64 Bits Graphics card : AMD Radeon(TM) 535 ATI Technologies .``` @zanqdo , can you please mention the working version also?

Daniel Salazar commented

2021-07-10 21:34:47 +02:00

In #89771#1189567, @PratikPB2123 wrote:

The cloth simulation is gone

Can not reproduce with provided steps on 3.0.0 (62d9dabc7d).

System Information
Graphics card : AMD Radeon(TM) 535 ATI Technologies .```

@zanqdo , can you please mention the working version also?

Hey man, do you mean it works for you? This is related to the Milestone 1 of this project

We made sure the basics for disk cache worked back in 2.92. I'm trying to find out what happened.

> In #89771#1189567, @PratikPB2123 wrote: >>The cloth simulation is gone > Can not reproduce with provided steps on 3.0.0 (`62d9dabc7d`). > > --- > **System Information** > ```Operating system : Windows-10-10.0.18362-SP0 64 Bits > Graphics card : AMD Radeon(TM) 535 ATI Technologies .``` > > @zanqdo , can you please mention the working version also? Hey man, do you mean it works for you? This is related to the [Milestone 1 of this project ](https://developer.blender.org/T82503) We made sure the basics for disk cache worked back in 2.92. I'm trying to find out what happened.

Bastien Montagne was assigned by Daniel Salazar

2021-07-10 21:36:00 +02:00

Philipp Oeser commented

2021-07-10 22:13:35 +02:00

Added subscriber: @lichtwerk

Pratik Borhade commented

2021-07-11 05:36:21 +02:00

do you mean it works for you?

@zanqdo , unsure what behavior is expected but seems same output for version 2.92 and above. (sorry for polluting the task)

At least I can say the animation is not lost after reloading the scene.

>do you mean it works for you? @zanqdo , unsure what behavior is expected but seems same output for version 2.92 and above. (sorry for polluting the task) At least I can say the animation is not lost after reloading the scene.

Daniel Salazar commented

2021-07-12 22:25:29 +02:00

I'm not sure what's going on on your side but I've added a video to the report

Philipp Oeser commented

2021-07-13 11:35:29 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-07-13 11:35:29 +02:00

I can confirm.

From a first quick look it also seems like the override setting on Disk Cache and Use Library Patch is not consistent?
If I enable Disk Cache and disable Use Library Patch, then save the file and revert/reopen, the setting is back to the original (this should not be the case, right?)

I can confirm. From a first quick look it also seems like the override setting on `Disk Cache` and `Use Library Patch` is not consistent? If I enable `Disk Cache` and disable `Use Library Patch`, then save the file and revert/reopen, the setting is back to the original (this should not be the case, right?)

Bastien Montagne commented

2021-07-13 12:23:47 +02:00

Please do not add bug as children of TODO/design tasks...

blender-admin commented

2021-07-14 12:14:51 +02:00

This issue was referenced by c9e9a42215

This issue was referenced by c9e9a422154581c5882b74e93c5be25798c88026

Bastien Montagne commented

2021-07-14 12:31:01 +02:00

This not a regression actually, that specific scenario never worked.

Issue with this case is that disk cache is already enabled in lib data (unlike what would happen by default). So there is nothing to override, and therefore no override rule is created for this setting.

But...... ClothModifier copy code just create a new empty PointCache, which by default has this setting disabled. Since there is no override rule, it remains like that in the override.

Fix incoming (note that issue could be present in other point cache usecases, but am tired of this code, it's is horribly badly handled, in a completely inconsistent way all over the codebase... It's just old system that needs complete redesign. so doing bare minimal changes needed to get this working for now).

This not a regression actually, that specific scenario never worked. Issue with this case is that disk cache is already enabled in lib data (unlike what would happen by default). So there is nothing to override, and therefore no override rule is created for this setting. But...... ClothModifier copy code just create a new empty PointCache, which by default has this setting disabled. Since there is no override rule, it remains like that in the override. Fix incoming (note that issue could be present in other point cache usecases, but am tired of this code, it's is horribly badly handled, in a completely inconsistent way all over the codebase... It's just old system that needs complete redesign. so doing bare minimal changes needed to get this working for now).

Bastien Montagne changed title from ~~Cloth disk cache is not read on library overrides (regression)~~ to Cloth disk cache is not read on library overrides

2021-07-14 12:31:16 +02:00

Bastien Montagne changed title from ~~Cloth disk cache is not read on library overrides~~ to Cloth disk cache is not read on library overrides when original linked data is already set to use 'Disk Cache'

2021-07-14 12:31:56 +02:00

Bastien Montagne commented

2021-07-14 14:48:16 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Bastien Montagne closed this issue

2021-07-14 14:48:16 +02:00

Daniel Salazar commented

2021-07-15 05:57:59 +02:00

Hey man I'm sorry but there's no way I can make this thing work :( 4be166b6b5

Library Overrides 2.mp4

Hey man I'm sorry but there's no way I can make this thing work :( 4be166b6b5 [Library Overrides 2.mp4](https://archive.blender.org/developer/F10224622/Library_Overrides_2.mp4)

Daniel Salazar commented

2021-07-15 05:58:18 +02:00

Changed status from 'Resolved' to: 'Confirmed'

Daniel Salazar reopened this issue

2021-07-15 05:58:18 +02:00

blender-admin commented

2021-10-20 17:21:30 +02:00

This issue was referenced by e00bf04c0f

This issue was referenced by e00bf04c0f59a9ed5bbe79e62f2f81861fbef2d7

Bastien Montagne commented

2021-10-20 17:24:48 +02:00

Changed status from 'Confirmed' to: 'Resolved'