Holdout Fill not working as expected with Grease Pencil #89879

Open
opened 2021-07-15 16:22:36 +02:00 by Alasdair Beckett-King · 12 comments

Operating system: Win 10
Graphics card: Nvidia GTX 1060

Broken: 2.93
Worked: unknown

I would expect holdout fills to render as 100% transparent. In Blender's image viewer, they don't - their opacity seems to change based on how bright they are, so white is 100% opaque, but grey is semi-transparent.

Saving the same image to a PNG file, the holdouts are fully transparent, but with aliased artefacts around the edge of the surrounding black strokes, in the colour of the holdout fill. If there is another grease pencil object positioned behind the holdout fill, instead of vanishing, its strokes are tinted the colour of the holdout fill.

holdout.png
(The artefacts are more noticeable against a dark or checkered background.)

Try rendering the simple drawing in the attached .blend, exporting a PNG and examining it in an image editor. holdouttest.blend

Operating system: Win 10 Graphics card: Nvidia GTX 1060 Broken: 2.93 Worked: unknown I would expect holdout fills to render as 100% transparent. In Blender's image viewer, they don't - their opacity seems to change based on how bright they are, so white is 100% opaque, but grey is semi-transparent. Saving the same image to a PNG file, the holdouts are fully transparent, but with aliased artefacts around the edge of the surrounding black strokes, in the colour of the holdout fill. If there is another grease pencil object positioned behind the holdout fill, instead of vanishing, its strokes are tinted the colour of the holdout fill. ![holdout.png](https://archive.blender.org/developer/F10225196/holdout.png) (The artefacts are more noticeable against a dark or checkered background.) Try rendering the simple drawing in the attached .blend, exporting a PNG and examining it in an image editor. [holdouttest.blend](https://archive.blender.org/developer/F10225159/holdouttest.blend)

Added subscriber: @Alasdair-1

Added subscriber: @Alasdair-1
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'
Member

This looks wrong, but I am not sure I understand fill holdout correctly.
Guess #grease_pencil module devs needs to check.

This looks wrong, but I am not sure I understand fill holdout correctly. Guess #grease_pencil module devs needs to check.

Added subscribers: @fclem, @antoniov

Added subscribers: @fclem, @antoniov

@fclem could you review this? you know better than me this part of the code.

@fclem could you review this? you know better than me this part of the code.

IIRC this is the expected result according to the current design. The full transparent is only when you use full black color. Any other color will mix the color with the existing one. Also, you can modulate the transparency using the alpha value of the color.

We will wait for @fclem to confirm it before archive the task report.

IIRC this is the expected result according to the current design. The full transparent is only when you use full black color. Any other color will mix the color with the existing one. Also, you can modulate the transparency using the alpha value of the color. We will wait for @fclem to confirm it before archive the task report.

Being able to modulating the opacity of the holdout makes sense, but surely tinting strokes and leaving artefacts in the colour of the holdout isn't expected behaviour?

Being able to modulating the opacity of the holdout makes sense, but surely *tinting* strokes and leaving artefacts in the colour of the holdout isn't expected behaviour?
Example: [2021-09-15 15-54-59.mp4](https://archive.blender.org/developer/F10419718/2021-09-15_15-54-59.mp4)

Thanks for the reply, I appreciate the demo! I see what you mean that a solid black holdout works as expected with no tinting. But, shouldn't it also hide the stroke which is part of a different object, rather than being limited to the strokes that are part of the same object?

And if holdouts only affect strokes within the same object, why does it tint the stroke that is part of a different object?

Thanks for the reply, I appreciate the demo! I see what you mean that a solid black holdout works as expected with no tinting. But, shouldn't it also hide the stroke which is part of a different object, rather than being limited to the strokes that are part of the same object? And if holdouts only affect strokes within the same object, why does it tint the stroke that is part of a different object?

Holdout only affects the same object and I don't see that it is tinting the other object ... it's like you are looking through tinted glass.

2021-09-15 16-11-33.mp4

Holdout only affects the same object and I don't see that it is tinting the other object ... it's like you are looking through tinted glass. [2021-09-15 16-11-33.mp4](https://archive.blender.org/developer/F10419884/2021-09-15_16-11-33.mp4)

If it is acts like tinted glass, I can't understand why I get such wildly different effects depending on the background colour. It only looks somewhat correct against the grey background.

image.png

image.png

image.png

If it is acts like tinted glass, I can't understand why I get such wildly different effects depending on the background colour. It only looks somewhat correct against the grey background. ![image.png](https://archive.blender.org/developer/F10419894/image.png) ![image.png](https://archive.blender.org/developer/F10419896/image.png) ![image.png](https://archive.blender.org/developer/F10419898/image.png)
Philipp Oeser removed the
Interest
Grease Pencil
label 2023-02-09 15:19:25 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#89879
No description provided.