New autoscrolling after renaming in the File Browser works weird #90082

New Issue

Philipp Oeser · 2021-07-23T16:23:05+02:00

Philipp Oeser commented

2021-07-23 16:23:05 +02:00

System Information
Operating system: Linux-5.13.0-0.rc6.45.fc35.x86_64-x86_64-with-glibc2.33.9000 64 Bits
Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 465.31

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-07-23 07:04, hash: f23b14091f
Was introduced in 6b0869039a like this

Short description of error
New autoscrolling after renamin in the File Browser works weird (does not scroll to the item created/renamed)

Exact steps for others to reproduce the error
in the FileBrowser:

go to a directory with many files/folders
create a new folder or rename an existing folder
watch it scroll somewhere else

filebrowser_autoscroll_somewhere_else.webm

**System Information** Operating system: Linux-5.13.0-0.rc6.45.fc35.x86_64-x86_64-with-glibc2.33.9000 64 Bits Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 465.31 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-07-23 07:04, hash: `f23b14091f` Was introduced in 6b0869039a like this **Short description of error** New autoscrolling after renamin in the File Browser works weird (does not scroll to the item created/renamed) **Exact steps for others to reproduce the error** in the FileBrowser: - go to a directory with many files/folders - create a new folder or rename an existing folder - watch it scroll somewhere else [filebrowser_autoscroll_somewhere_else.webm](https://archive.blender.org/developer/F10235000/filebrowser_autoscroll_somewhere_else.webm)

Philipp Oeser commented

2021-07-23 16:23:05 +02:00

Added subscriber: @lichtwerk

blender-admin commented

2021-07-23 16:23:05 +02:00

#93116 was marked as duplicate of this issue

Philipp Oeser commented

2021-07-23 16:24:05 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-07-23 16:24:05 +02:00

Added subscribers: @Schiette, @JulianEisel

Philipp Oeser commented

2021-07-23 16:24:05 +02:00

@JulianEisel
@Schiette

@JulianEisel @Schiette

Philipp Oeser changed title from ~~New autoscrolling after renamin in the File Browser works weird~~ to New autoscrolling after renaming in the File Browser works weird

2021-07-23 16:24:21 +02:00

Philipp Oeser commented

2021-07-23 16:27:03 +02:00

Since this can get really annoying, I consider this a regression (before the commit - and with sorting by Date Modified you could at least make sure the new/renamed entry and focus would stay on top, now it always scrolls away) and will dare setting this to High prio.

Since this can get really annoying, I consider this a regression (before the commit - and with sorting by `Date Modified` you could at least make sure the new/renamed entry and focus would stay on top, now it always scrolls away) and will dare setting this to High prio.

Julian Eisel commented

2021-07-26 14:13:35 +02:00

We didn't change the scrolling logic, which I think was quite broken in master already. At least I know of cases where it didn't work either. This change exposes it much more though.

Philipp Oeser commented

2021-11-16 08:36:28 +01:00

Added subscribers: @phoenixart, @PratikPB2123

Philipp Oeser self-assigned this 2021-11-25 09:40:56 +01:00

Philipp Oeser commented

2021-11-25 09:40:56 +01:00

Since I set this to High prio (it is still bugging me every day), will have a look.

Julian Eisel commented

2021-11-25 11:19:44 +01:00

The smooth auto scrolling (which isn't new functionality) has always had issues like that. It was entirely reworked at some point to address such issues, but without success. Think one of the main problems is that after actions like renaming, it is executed immediately, but the file list is first cleared and then rebuilt. So there is a moment where the scrolling may operate on an empty list, which messes things up.

So I think at this point we should simply remove the smooth auto scrolling, and just ensure the active file is in view bounds after loading using file_ensure_inside_viewbounds(). We can later port this to use UI_view2d_smooth_view(), and make sure that doesn't have conflicts with rebuilding the file list.

The smooth auto scrolling (which isn't new functionality) has always had issues like that. It was entirely reworked at some point to address such issues, but without success. Think one of the main problems is that after actions like renaming, it is executed immediately, but the file list is first cleared and then rebuilt. So there is a moment where the scrolling may operate on an empty list, which messes things up. So I think at this point we should simply remove the smooth auto scrolling, and just ensure the active file is in view bounds after loading using `file_ensure_inside_viewbounds()`. We can later port this to use `UI_view2d_smooth_view()`, and make sure that doesn't have conflicts with rebuilding the file list.

Philipp Oeser commented

2021-11-25 11:56:40 +01:00

I think the problem is the deselection/selection in the code from 6b0869039a [which resorts], not sure if you meant that?
Seems like getting the correct file again after resorting will fix this though, Diff incoming...

I think the problem is the deselection/selection in the code from 6b0869039a [which resorts], not sure if you meant that? Seems like getting the correct file again after resorting will fix this though, Diff incoming...

Philipp Oeser commented

2021-11-25 12:10:40 +01:00

There might be situations where there is an empty list (havent run into this though I think), but the clear regression from the culprit commit should still be fixed?

blender-admin commented

2021-11-25 17:31:31 +01:00

This issue was referenced by b2bb3e4b72

This issue was referenced by b2bb3e4b722bad7e887a66ac4a6f589b389e6dc5

Julian Eisel commented

2021-11-25 17:33:24 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Julian Eisel closed this issue

2021-11-25 17:33:24 +01:00

Thomas Dinges added this to the 3.0 milestone 2023-02-08 15:59:05 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

New autoscrolling after renaming in the File Browser works weird #90082