Scrollbar missing in Outliner and Properties editor #90367

Closed
opened 2021-08-02 09:11:34 +02:00 by Reiner Prokein · 30 comments

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.09

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-01 03:22, hash: 79277986c2

Short description of error
The scroll bar is missing in this blend file for the properties editor and the outliner.

Exact steps for others to reproduce the error

  • Open the blend file and try to scroll in the outliner or the properties editor.

I have honestly no idea what causes this state. But it came in from an external blend file of a custom Blender build that already showed this behaviour.

scrollbarproblem.blend

2021-08-02 09-03-59.mp4

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.09 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-01 03:22, hash: `79277986c2` **Short description of error** The scroll bar is missing in this blend file for the properties editor and the outliner. **Exact steps for others to reproduce the error** - Open the blend file and try to scroll in the outliner or the properties editor. I have honestly no idea what causes this state. But it came in from an external blend file of a custom Blender build that already showed this behaviour. [scrollbarproblem.blend](https://archive.blender.org/developer/F10259156/scrollbarproblem.blend) [2021-08-02 09-03-59.mp4](https://archive.blender.org/developer/F10259157/2021-08-02_09-03-59.mp4)
Author

Added subscriber: @tiles

Added subscriber: @tiles
Contributor

Added subscriber: @dupoxy

Added subscriber: @dupoxy
Contributor

You can work-around this if you uncheck "Load UI" and reload the file:
image.png
preferences>Save & Load >Load UI

You can work-around this if you uncheck "Load UI" and reload the file: ![image.png](https://archive.blender.org/developer/F10259254/image.png) preferences>Save & Load >Load UI
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Can reproduce with the provided file. Not sure if this is related to #75003 but resizing the window does not solve the issue.

You can fix this if you uncheck "Load UI" and reload the file:

This does not fix the problem on my system.

Can reproduce with the provided file. Not sure if this is related to #75003 but resizing the window does not solve the issue. >You can fix this if you uncheck "Load UI" and reload the file: This does not fix the problem on my system.
Author

@dupoxy, of course, then it does not load the UI from the Blend file anymore.. But the UI that is loaded from the blend file is the part that is broken. It should be imho not possible to hide away scrollers at all.

@dupoxy, of course, then it does not load the UI from the Blend file anymore.. But the UI that is loaded from the blend file is the part that is broken. It should be imho not possible to hide away scrollers at all.
Contributor

@tiles yes I get that:

In #90367#1200221, @tiles wrote:
the UI that is loaded from the blend file is the part that is broken.

I edited my previous comment to say work-around instead of fix so it's clear it not a permanent fix.

@tiles yes I get that: > In #90367#1200221, @tiles wrote: > the UI that is loaded from the blend file is the part that is broken. I edited my previous comment to say work-around instead of fix so it's clear it not a permanent fix.
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Can confirm.

Would be desirable to have a repro scenario here (which build is this written from?), but in general: would agree no file shuold be in such state, will confirm for now.

Can confirm. Would be desirable to have a repro scenario here (which build is this written from?), but in general: would agree no file shuold be in such state, will confirm for now.
Author

The repro case is to save with the actual version of Bforartists2, which is based at Blender 3. There the scrollbars are missing for unknown reasons. And this transfers to the blend file then.

The repro case is to save with the actual version of Bforartists2, which is based at Blender 3. There the scrollbars are missing for unknown reasons. And this transfers to the blend file then.
Member

Added subscriber: @JulianEisel

Added subscriber: @JulianEisel
Member

Changed status from 'Confirmed' to: 'Needs User Info'

Changed status from 'Confirmed' to: 'Needs User Info'
Member

Main question for me is what display resolution is used. But this is most likely the same issue as reported in #75003, which is a bug we are well aware of.

Main question for me is what display resolution is used. But this is most likely the same issue as reported in #75003, which is a bug we are well aware of.
Member

Added subscribers: @AnthonyEdlin, @Harley

Added subscribers: @AnthonyEdlin, @Harley
Member

@tiles - repro case is to save with the actual version of Bforartists2

So it was Bforartists2 that broke this file?!?

@JulianEisel - Main question for me is what display resolution is used. But this is most likely the same issue as reported in #75003, which is a bug we are well aware of.

I thought so too but this seems different in that the scrollbars do not come back no matter how much you resize the editors or the entire window. It also does not show scrollbars in Properties either.

For #75003 there is a patch that fixes that, D10733, but it does not seem to fix this file. I tested it with D6505 which incorporates @AnthonyEdlin's changes

> @tiles - repro case is to save with the actual version of Bforartists2 So it was **Bforartists2** that broke this file?!? > @JulianEisel - Main question for me is what display resolution is used. But this is most likely the same issue as reported in #75003, which is a bug we are well aware of. I thought so too but this seems different in that the scrollbars do not come back no matter how much you resize the editors or the entire window. It also does not show scrollbars in Properties either. For #75003 there is a patch that fixes that, [D10733](https://archive.blender.org/developer/D10733), but it does not seem to fix this file. I tested it with [D6505](https://archive.blender.org/developer/D6505) which incorporates @AnthonyEdlin's changes
Author

Yes. Blender code broke Bforartists. And then Bforartists broke the blend file. So to speak.

Yes. Blender code broke Bforartists. And then Bforartists broke the blend file. So to speak.
Author

Main question for me is what display resolution is used.

Sorry, overlooked this question. It is the usual 1920 x 1080 that i use here.

> Main question for me is what display resolution is used. Sorry, overlooked this question. It is the usual 1920 x 1080 that i use here.
Author

We have at Bforartists fixed the issue meanwhile. Apologies, it was one of our changes, not a change that came from Blender. We tried to fix this Blender bug here: https://developer.blender.org/T81532

by
046ea1c55d
and c6575cb6bc

It worked. But the side effect was that the scrollbar was missing then in the outliner and the properties editor. Which we did not notice.

So the remaining issue here is, how is it possible that the broken state of the scrollbar can be transfered to Blender by a blend file ?

We have at Bforartists fixed the issue meanwhile. Apologies, it was one of our changes, not a change that came from Blender. We tried to fix this Blender bug here: https://developer.blender.org/T81532 by https://github.com/Bforartists/Bforartists/commit/046ea1c55df71a3de4a584271df99dc84ab11541 and https://github.com/Bforartists/Bforartists/commit/c6575cb6bcac411ef3954281f4a8ba335aee7b1d It worked. But the side effect was that the scrollbar was missing then in the outliner and the properties editor. Which we did not notice. So the remaining issue here is, how is it possible that the broken state of the scrollbar can be transfered to Blender by a blend file ?
Member

That blender didn’t somehow fix a blend file broken and saved by Bforartists does not seem to be a suitable use of our bug reporting system

That blender didn’t somehow fix a blend file broken and saved by Bforartists does not seem to be a suitable use of our bug reporting system
Author

Well, that it is possible to break the Blender UI (not the layout) by loading a blend file is a very suitable use of OUR bug reporting system for me.

Must we really talk about who is allowed to make a bug report here? When you think the report is invalid, then close it. But not because i said "Bforartists", and you personally hate the fork. The discussion about Bforartists does simply not belong here. At least not as long as there is no bug involved that affects Blender. But exactly this was the case here.

I have written this report because i think i have found a Blender bug. I was asked for the repo case, and where this broken file comes from. I named it. And i even point at the code now that was broken so that one can follow what is going on. Do with it as you like. In case you need even more informations, i am here.

Kind regards
Tiles

Well, that it is possible to break the Blender UI (not the layout) by loading a blend file is a very suitable use of OUR bug reporting system for me. Must we really talk about who is allowed to make a bug report here? When you think the report is invalid, then close it. But not because i said "Bforartists", and you personally hate the fork. The discussion about Bforartists does simply not belong here. At least not as long as there is no bug involved that affects Blender. But exactly this was the case here. I have written this report because i think i have found a Blender bug. I was asked for the repo case, and where this broken file comes from. I named it. And i even point at the code now that was broken so that one can follow what is going on. Do with it as you like. In case you need even more informations, i am here. Kind regards Tiles
Member

@tiles - Must we really talk about who is allowed to make a bug report here?

Nope. I have no official status here, just giving my opinion as anyone can.

This bug report, as written, is about a problem created by Bforartists as you clearly stated "it was one of our changes, not a change that came from Blender"

So not seeing what bug is here in blender code for anyone to fix. I'm not sure that adding some ability to recover from files created badly by other software is something anyone will take up. But I could be wrong.

> @tiles - Must we really talk about who is allowed to make a bug report here? Nope. I have no official status here, just giving my opinion as anyone can. This bug report, as written, is about a problem created by Bforartists as you clearly stated "it was one of our changes, not a change that came from Blender" So not seeing what bug is here in blender code for anyone to fix. I'm not sure that adding some ability to recover from files created badly by other software is something anyone will take up. But I could be wrong.
Author

So not seeing what bug is here in blender code for anyone to fix.

So, the third time. It is possible to break the Blender UI (not the layout) by loading a broken blend file where the slider is missing. Because the broken state of the slider is stored in the blend file. And then loaded by Load UI. This should imho not be possible. For me this is a design bug in what gets stored and loaded by the Load UI code.

This is nothing that Bforartists can fix at its end. This is a general issue of the blend file format. We were just able to fix the missing slider.

For the consequences: There are currently a few thenthousands Bforartists versions out there that are able to produce such broken blend files. The bug existed for more than half a year now. And so you might run sooner or later into such reports again. And Bforartists is not the only custom build out there.

As told, when you think this bug report is invalid, then please close it. I can just report it.

> So not seeing what bug is here in blender code for anyone to fix. So, the third time. It is possible to break the Blender UI (not the layout) by loading a broken blend file where the slider is missing. Because the broken state of the slider is stored in the blend file. And then loaded by Load UI. This should imho not be possible. For me this is a design bug in what gets stored and loaded by the Load UI code. This is nothing that Bforartists can fix at its end. This is a general issue of the blend file format. We were just able to fix the missing slider. For the consequences: There are currently a few thenthousands Bforartists versions out there that are able to produce such broken blend files. The bug existed for more than half a year now. And so you might run sooner or later into such reports again. And Bforartists is not the only custom build out there. As told, when you think this bug report is invalid, then please close it. I can just report it.
Member

Removed subscriber: @Harley

Removed subscriber: @Harley
Member

Changed status from 'Needs User Info' to: 'Needs Triage'

Changed status from 'Needs User Info' to: 'Needs Triage'
Member

Changed status from 'Needs Triage' to: 'Archived'

Changed status from 'Needs Triage' to: 'Archived'
Member

I think this just ended up in incompatible flags for these Editors.
The Bforartists build flags these with V2D_SCROLL_VERTICAL_HANDLES -- but this just does not play nice with V2D_SCROLL_VERTICAL_HIDE it seems.

In particular, this check fails (and thus the scrollers are not set up correctly):
https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/view2d.c$157
(You'll get scrollbars if you use if (true) { there -- just for testing).

I would suggest two things (but I dont think it makes much sense to do this on the blender side):

  • add versioning code in Bforartists that resets V2D_SCROLL_VERTICAL_HANDLES in the Editors where it is not desired -- Outliner and Properties editor -- this really does not make sense to add in blender itself)
  • in the future, if you have fixes for bugs listed on developer.blender.org, submit a patch here (and at least give us a chance to prevent issues like this by having a look -- if this is taking too long you can still do your own thing Bforartists afterwards)

Having said all this, I will close this now, thx again reporting.

I think this just ended up in incompatible flags for these Editors. The Bforartists build flags these with `V2D_SCROLL_VERTICAL_HANDLES` -- but this just does not play nice with `V2D_SCROLL_VERTICAL_HIDE` it seems. In particular, this check fails (and thus the scrollers are not set up correctly): https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/view2d.c$157 (You'll get scrollbars if you use `if (true) {` there -- just for testing). I would suggest two things (but I dont think it makes much sense to do this on the blender side): - add versioning code in Bforartists that resets `V2D_SCROLL_VERTICAL_HANDLES` in the Editors where it is not desired -- Outliner and Properties editor -- this really does not make sense to add in blender itself) - in the future, if you have fixes for bugs listed on developer.blender.org, submit a patch here (and at least give us a chance to prevent issues like this by having a look -- if this is taking too long you can still do your own thing Bforartists afterwards) Having said all this, I will close this now, thx again reporting.
Author

Thanks for having a lookt at it. As told, we were surprised by this like you. And the code in question is reverted. So there is nothing to fix left.

I always make a report when i stumble across an issue. This is for me a question of honor. But this doesn't necessarily mean that we have a patch then. Just that we found a bug. Most of our changes are UI design issues, which are not accepted at Blender. This issue was one of the first exceptions form this rule in the long history of Bforartists where a change affected Blender in a way. Hopefully this doesn't happen too often.

Thanks for having a lookt at it. As told, we were surprised by this like you. And the code in question is reverted. So there is nothing to fix left. I always make a report when i stumble across an issue. This is for me a question of honor. But this doesn't necessarily mean that we have a patch then. Just that we found a bug. Most of our changes are UI design issues, which are not accepted at Blender. This issue was one of the first exceptions form this rule in the long history of Bforartists where a change affected Blender in a way. Hopefully this doesn't happen too often.
Member

In #90367#1214686, @tiles wrote:
Thanks for having a lookt at it. As told, we were surprised by this like you. And the code in question is reverted. So there is nothing to fix left.

there are still files out there that have this saved in, so this should be fixable with do_version, just saying.

I always make a report when i stumble across an issue. This is for me a question of honor. But this doesn't necessarily mean that we have a patch then. Just that we found a bug. Most of our changes are UI design issues, which are not accepted at Blender. This issue was one of the first exceptions form this rule in the long history of Bforartists where a change affected Blender in a way. Hopefully this doesn't happen too often.

I have seen you reporting here often, always appreciated! Wasnt aware that Bforartists doesnt do fixes, yeah, so if that ever happens to be the case again: more than welcome to drop them here :)

> In #90367#1214686, @tiles wrote: > Thanks for having a lookt at it. As told, we were surprised by this like you. And the code in question is reverted. So there is nothing to fix left. there are still files out there that have this saved in, so this should be fixable with `do_version`, just saying. > I always make a report when i stumble across an issue. This is for me a question of honor. But this doesn't necessarily mean that we have a patch then. Just that we found a bug. Most of our changes are UI design issues, which are not accepted at Blender. This issue was one of the first exceptions form this rule in the long history of Bforartists where a change affected Blender in a way. Hopefully this doesn't happen too often. I have seen you reporting here often, always appreciated! Wasnt aware that Bforartists doesnt do fixes, yeah, so if that ever happens to be the case again: more than welcome to drop them here :)
Author

Understood. Thanks. We will have a look :)

Understood. Thanks. We will have a look :)
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#90367
No description provided.