Effect Strip added to a nested Metastrip gets duplicate name (thus inherits fcurves from other Strips) #90737

New Issue

Jonata Bolzan · 2021-08-17T17:10:18+02:00

Jonata Bolzan commented

2021-08-17 17:10:18 +02:00

System Information
Operating system: Ubuntu Linux 20.04
Graphics card: NVS 3100M/PCIe/SSE2

Blender Version
Caused by bbb1936411

Short description of error

Creating an Effect Strip for Transform, for example, inside a nested Metastrip, it would inherit the fcurves from another Transform Strip

Exact steps for others to reproduce the error
#90737.blend

open above .blend
then Add > Effect Strip > Transform to MetaStrip.004
see the resulting Transform strip getting a false ( because already in use ) name: should be called "Transform.002" (but is called "Transform")
therefor it is already getting an FCurve

Or you can follow the steps on the attached video to see what happens.
simplescreenrecorder-2021-08-17_12.03.04.mkv
this is the file with the duplicate already
metastrip_bug.blend

**System Information** Operating system: Ubuntu Linux 20.04 Graphics card: NVS 3100M/PCIe/SSE2 **Blender Version** Caused by bbb1936411 **Short description of error** Creating an Effect Strip for Transform, for example, inside a nested Metastrip, it would inherit the fcurves from another Transform Strip **Exact steps for others to reproduce the error** [#90737.blend](https://archive.blender.org/developer/F10287354/T90737.blend) - open above .blend - then `Add` > `Effect Strip` > `Transform` to `MetaStrip.004` - see the resulting `Transform` strip getting a false ( because already in use ) name: should be called "Transform.002" (but is called "Transform") - therefor it is already getting an FCurve --- Or you can follow the steps on the attached video to see what happens. [simplescreenrecorder-2021-08-17_12.03.04.mkv](https://archive.blender.org/developer/F10286431/simplescreenrecorder-2021-08-17_12.03.04.mkv) this is the file with the duplicate already [metastrip_bug.blend](https://archive.blender.org/developer/F10286430/metastrip_bug.blend)

Jonata Bolzan commented

2021-08-17 17:10:18 +02:00

Added subscriber: @jonata

Philipp Oeser commented

2021-08-18 10:25:38 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-08-18 10:25:38 +02:00

Can confirm.

at this point, there are duplicates in the GHash.
Assume this is related to same problem as in {#90595}? (Transform being a nested struct not identifying its strip correctly?)

Getting this:

BLI_assert failed: source/blender/blenlib/intern/BLI_ghash.c:462, ghash_insert_ex(), at '(gh->flag & GHASH_FLAG_ALLOW_DUPES) || (BLI_ghash_haskey(gh, key) == 0)'

Can confirm. at this point, there are duplicates in the GHash. Assume this is related to same problem as in {#90595}? (Transform being a nested struct not identifying its strip correctly?) Getting this: ``` BLI_assert failed: source/blender/blenlib/intern/BLI_ghash.c:462, ghash_insert_ex(), at '(gh->flag & GHASH_FLAG_ALLOW_DUPES) || (BLI_ghash_haskey(gh, key) == 0)' ```

Philipp Oeser commented

2021-08-18 10:30:43 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser changed title from ~~Effect Strip added to a nested Metastrip inherits fcurves from other Strips~~ to Effect Strip added to a nested Metastrip gets duplicate name (thus inherits fcurves from other Strips)

2021-08-18 11:17:13 +02:00

Philipp Oeser self-assigned this 2021-08-18 12:29:12 +02:00

Philipp Oeser commented

2021-08-18 12:29:12 +02:00

Caused by bbb1936411

Think I got a fix for this.

Caused by bbb1936411 Think I got a fix for this.

blender-admin commented

2021-08-18 12:45:37 +02:00

This issue was referenced by 3fa1de6ad6

This issue was referenced by 3fa1de6ad68b1e3b22c5c30dc039820a1c36c2d4

blender-admin commented

2021-08-18 12:45:37 +02:00

This issue was referenced by 787350dde8

This issue was referenced by 787350dde8aec3caf8660c749e1847ff406974c8

Philipp Oeser commented

2021-08-18 14:50:18 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2021-08-18 14:50:18 +02:00

Philipp Oeser commented

2021-08-18 14:57:57 +02:00

Added subscriber: @iss

Philipp Oeser commented

2021-08-18 14:57:57 +02:00

I have pushed 787350dde8 now.

Unfortunately this does not mean your file is in a good state already.
As a workaround, you'll have to rename the strip (it got a non-unique name by accident/bug), see the commit for details.

@iss: if you've got a good way to repair these broken files, please go ahead (as a reminder, you'll get the following assert in such cases)

BLI_assert failed: source/blender/blenlib/intern/BLI_ghash.c:462, ghash_insert_ex(), at '(gh->flag & GHASH_FLAG_ALLOW_DUPES) || (BLI_ghash_haskey(gh, key) == 0)'

I have pushed 787350dde8 now. Unfortunately this does not mean your file is in a good state already. As a workaround, you'll have to rename the strip (it got a non-unique name by accident/bug), see the commit for details. @iss: if you've got a good way to repair these broken files, please go ahead (as a reminder, you'll get the following assert in such cases) ``` BLI_assert failed: source/blender/blenlib/intern/BLI_ghash.c:462, ghash_insert_ex(), at '(gh->flag & GHASH_FLAG_ALLOW_DUPES) || (BLI_ghash_haskey(gh, key) == 0)' ```

Falk David referenced this issue

2023-02-10 13:03:22 +01:00

Blender LTS: Maintenance Task 2.93 #88449

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Effect Strip added to a nested Metastrip gets duplicate name (thus inherits fcurves from other Strips) #90737