Improve thumbnail loading from blend files. #90908

New Issue

Jeroen Bakker · 2021-08-25T09:32:12+02:00

Jeroen Bakker commented

2021-08-25 09:32:12 +02:00

Thumbnails are cached in tmp folder but can be outdates or not available. When this is the case the thumbnails are extracted from the blend file.

Currently the logic is as follow

for each thumbnail to load:
  open file
  read all names of the same category
  read all preview images of the same category
  find the preview image that was needed as it is assumed that the name list and preview list are in the same order!
  discard the rest of the preview images (that will probably be reread in the following loop)...

Related functions:

IMB_thumb_load_blend
BLO_blendhandle_get_previews

Other improvements are:

- store preview images closer to the bhead.
- D12312: #90908: Reduce loading times when extracting thumbnails from Blendfiles.
- add an preview index at the end of the blend file that can act as a hashmap between IDname and preview index. So we don't need to go over the whole file.

Thumbnails are cached in tmp folder but can be outdates or not available. When this is the case the thumbnails are extracted from the blend file. Currently the logic is as follow ``` for each thumbnail to load: open file read all names of the same category read all preview images of the same category find the preview image that was needed as it is assumed that the name list and preview list are in the same order! discard the rest of the preview images (that will probably be reread in the following loop)... ``` Related functions: * `IMB_thumb_load_blend` * `BLO_blendhandle_get_previews` Other improvements are: * - [ ] store preview images closer to the bhead. * - [x] [D12312: #90908: Reduce loading times when extracting thumbnails from Blendfiles.](https://archive.blender.org/developer/D12312) * - [ ] add an preview index at the end of the blend file that can act as a hashmap between IDname and preview index. So we don't need to go over the whole file.

Jeroen Bakker self-assigned this 2021-08-25 09:32:12 +02:00

Jeroen Bakker commented

2021-08-25 09:32:12 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jeroen Bakker commented

2021-08-25 09:32:12 +02:00

Added subscriber: @Jeroen-Bakker

blender-admin commented

2021-08-25 14:15:57 +02:00

This issue was referenced by 0fd1e6a5f4

This issue was referenced by 0fd1e6a5f43df8b0f5382c07975c0d031bbbb506

Julian Eisel commented

2021-09-16 15:45:03 +02:00

Added subscriber: @JulianEisel

Julian Eisel commented

2021-09-16 15:45:03 +02:00

This is on the In Progress column. One of the points mentioned is done and AFAICS there are no plans to work on the remaining ones soon. So should we move this to the Community Tasks/Good-to-Have's?

This is on the *In Progress* column. One of the points mentioned is done and AFAICS there are no plans to work on the remaining ones soon. So should we move this to the *Community Tasks/Good-to-Have's*?

Jeroen Bakker was unassigned by Sybren A. Stüvel

2021-10-11 14:11:11 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Improve thumbnail loading from blend files. #90908