Blender crashes if simplify is turned on while baking multires #91171
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#91171
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: AMD Radeon RX 5700 XT ATI Technologies Inc. 4.5.14742 Core Profile Context 21.7.2 27.20.22021.1002
Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-09-02 14:26, hash:
6fc92b296fWorked: --
Short description of error
Blender crashes if simplify is turned on while baking multires data
Exact steps for others to reproduce the error
Test File:
multires_crash.blend
Added subscriber: @Diogo_Valadares
Added subscriber: @ThomasDinges
Changed status from 'Needs Triage' to: 'Confirmed'
Can confirm the crash. multires_crash.blend
Just click on Bake.
Added subscriber: @leesonw
It seems to give the following assert when running a debug build
BLI_assert failed: source/blender/blenkernel/intern/mesh_tangent.c:709, BKE_mesh_calc_loop_tangent_ex(), at 'tangent_mask_curr == tangent_mask'
the call stack is in P2504
the above assert does not happen when simplify is switched off so I am guessing this is the root of the problem.
This also seems to crash on 2.93 and 2.83 so this seems to go way back :-) There is a bunch of tangent stuff right before this that could possible be the reason (see below). Anyone got a really old version they could test?
commit
429f6bee28Author: Campbell Barton ideasman42@gmail.com
Date: Wed May 24 22:33:21 2017 +1000
commit
a6c60affffMerge:
60a099fb09d252ac6b95Author: Campbell Barton ideasman42@gmail.com
Date: Wed May 24 21:16:54 2017 +1000
commit
d252ac6b95Author: Campbell Barton ideasman42@gmail.com
Date: Wed May 24 21:13:32 2017 +1000
it goes wayy back to 2.8, honestly I had this bug for some time but I didn't think it was this old.
I thought about trying this in blender 2.79b, but I didn't find simplify neither bake from multires because it seems neither of them had been implemented before 2.8: https:*docs.blender.org/manual/en/2.79/render/cycles/render_settings/simplify.html ; https:*docs.blender.org/manual/en/2.79/render/cycles/baking.html
So basically it has been broken since it was implemented I guess.
Certainly seems that way.
Think I have an idea how to fix, will put on my desk.
Think this should be high prio as well (since it is a crasher that is not too unlikely to run into).
Situation turned out to be more complicated, will leave my notes, but step down for now...
MultiresFlags-- that means it is not taking the render settings for getting the (multires_get_level/get_render_subsurf_level), but always the viewport settings from simplify, is that what we want?
-- should we possibly use
MULTIRES_USE_RENDER_PARAMSfor baking?-- would it possibly make sense to just use
MULTIRES_IGNORE_SIMPLIFY? Or would you think people are relying on simplify for baking?I think using
MULTIRES_IGNORE_SIMPLIFYfor baking is correct. Simplify is mainly meant as a feature to speed up viewport drawing and renders, not so much to affect the behavior of tools. If just using that flag works, it seems like a good fix.The multires baking usage of viewport and renders levels may be confusing, but best not to touch that since that would break compatibility and potentially some use cases.
Fixed in
d08f63e7cb.