Quick Favorites and shortcuts are broken for many properties. #91225

New Issue

Poly Lou · 2021-09-06T19:12:56+02:00

Poly Lou commented

2021-09-06 19:12:56 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.41

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-09-06 08:56, hash: 81978594a8
Worked: 2.93.4

Caused by 3e4d720ae4

Short description of error
[Please fill out a short description of the error here]

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

Open Blender.
In 3D Viewport editor, click Viewport Overlays drop down menu, then hover mouse on chickbox of some options like "Face Orientation", then right click , choose "Add to Quick Favorites".
Hit Q on keyboard, Face Orientation not show in Quick Favorites menu.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.41 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-09-06 08:56, hash: `81978594a8` Worked: 2.93.4 Caused by 3e4d720ae4 **Short description of error** [Please fill out a short description of the error here] **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)] 1. Open Blender. 2. In 3D Viewport editor, click Viewport Overlays drop down menu, then hover mouse on chickbox of some options like "Face Orientation", then right click , choose "Add to Quick Favorites". 3. Hit Q on keyboard, Face Orientation not show in Quick Favorites menu.

Poly Lou commented

2021-09-06 19:12:56 +02:00

Added subscriber: @XiTi

Pratik Borhade commented

2021-09-07 08:14:26 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser self-assigned this 2021-09-07 08:17:32 +02:00

Pratik Borhade commented

2021-09-07 08:19:11 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-09-07 08:19:11 +02:00

May be similar to #59244 (Quick Favorites: add support for operator/prop enums (e.g. "Set origin")) ?

Poly Lou commented

2021-09-07 08:31:26 +02:00

I've tried same steps in Blender 2.93.4, it works fine.

Philipp Oeser commented

2021-09-07 08:34:35 +02:00

In #91225#1217003, @PratikPB2123 wrote:
May be similar to #59244 (Quick Favorites: add support for operator/prop enums (e.g. "Set origin")) ?

Nope, this broke with the recent 3e4d720ae4, I'm on it.

> In #91225#1217003, @PratikPB2123 wrote: > May be similar to #59244 (Quick Favorites: add support for operator/prop enums (e.g. "Set origin")) ? Nope, this broke with the recent 3e4d720ae4, I'm on it.

Philipp Oeser removed their assignment 2021-09-07 11:24:56 +02:00

Philipp Oeser commented

2021-09-07 11:24:56 +02:00

Added subscribers: @ideasman42, @lichtwerk

Philipp Oeser commented

2021-09-07 11:24:56 +02:00

Basically everything involving a path with some nested struct fails:
space_data.overlay.prop fails whereas space_data.prop is fine

One idea is to specifiy this directly on the member_id, like so [just an excerpt, would have to be done in more places]:
P2367: T91225_snippet



diff --git a/source/blender/windowmanager/intern/wm_operators.c b/source/blender/windowmanager/intern/wm_operators.c
index df051328990..745d5d3678c 100644
--- a/source/blender/windowmanager/intern/wm_operators.c
+++ b/source/blender/windowmanager/intern/wm_operators.c
@@ -551,9 +551,8 @@ static const char *wm_context_member_from_ptr(bContext *C, const PointerRNA *ptr
           case SPACE_VIEW3D: {
             const View3D *v3d = (View3D *)space_data;
             const View3DShading *shading = &v3d->shading;
-
-            TEST_PTR_DATA_TYPE("space_data", RNA_View3DOverlay, ptr, v3d);
-            TEST_PTR_DATA_TYPE("space_data", RNA_View3DShading, ptr, shading);
+            TEST_PTR_DATA_TYPE("space_data.overlay", RNA_View3DOverlay, ptr, v3d);
+            TEST_PTR_DATA_TYPE("space_data.shading", RNA_View3DShading, ptr, shading);
             break;
           }
           case SPACE_GRAPH: {

But @ideasman42 might have better ideas for it, will step down.

Basically everything involving a path with some nested struct fails: space_data.overlay.prop fails whereas space_data.prop is fine One idea is to specifiy this directly on the `member_id`, like so [just an excerpt, would have to be done in more places]: [P2367: T91225_snippet](https://archive.blender.org/developer/P2367.txt) ``` diff --git a/source/blender/windowmanager/intern/wm_operators.c b/source/blender/windowmanager/intern/wm_operators.c index df051328990..745d5d3678c 100644 --- a/source/blender/windowmanager/intern/wm_operators.c +++ b/source/blender/windowmanager/intern/wm_operators.c @@ -551,9 +551,8 @@ static const char *wm_context_member_from_ptr(bContext *C, const PointerRNA *ptr case SPACE_VIEW3D: { const View3D *v3d = (View3D *)space_data; const View3DShading *shading = &v3d->shading; - - TEST_PTR_DATA_TYPE("space_data", RNA_View3DOverlay, ptr, v3d); - TEST_PTR_DATA_TYPE("space_data", RNA_View3DShading, ptr, shading); + TEST_PTR_DATA_TYPE("space_data.overlay", RNA_View3DOverlay, ptr, v3d); + TEST_PTR_DATA_TYPE("space_data.shading", RNA_View3DShading, ptr, shading); break; } case SPACE_GRAPH: { ``` But @ideasman42 might have better ideas for it, will step down.

Philipp Oeser changed title from ~~Can't add Viewport Overlays options to quick favorites menu.~~ to Quick Favorites and shortcuts are broken for many properties.

2021-09-07 11:25:46 +02:00

Campbell Barton commented

2021-09-07 14:41:31 +02:00

@lichtwerk your patch looks correct, think this is fine to go in, although the other TEST_PTR_DATA_TYPE uses with space_data need updating too.

@lichtwerk your patch looks correct, think this is fine to go in, although the other `TEST_PTR_DATA_TYPE` uses with space_data need updating too.

blender-admin commented

2021-09-07 16:43:17 +02:00

This issue was referenced by 8d40d61af0

This issue was referenced by 8d40d61af093fcf528ce282b740eca119a5ee5d3

Philipp Oeser commented

2021-09-08 08:30:48 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2021-09-08 08:30:48 +02:00

Philipp Oeser self-assigned this 2021-09-08 08:30:48 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Quick Favorites and shortcuts are broken for many properties. #91225