Draw: Crash on undo after adding new texture #91294

Closed
opened 2021-09-09 20:39:58 +02:00 by Ulysse Martin · 38 comments

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.96

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-09-08 07:56, hash: 2b2d427bba
Worked: 54f5c174a8
Fisrt not working commit: 2b2d427bba

Short description of error
Crash when adding new texture in shader node then pressing undo.

Exact steps for others to reproduce the error

  • Open default scene
  • Switch to Shading workspace
  • Add Image Texture
  • Create a new Image

Undo

Animation.gif


Stack trace:

blender.exe         :0x00007FF70934F240  GPU_texture_free C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\gpu\intern\gpu_texture.cc:523
blender.exe         :0x00007FF70881BCE0  image_free_gpu C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\image_gpu.c:556
blender.exe         :0x00007FF7087D16E0  BKE_image_free_buffers C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\image.c:539
blender.exe         :0x00007FF7087D0240  image_free_data C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\image.c:179
blender.exe         :0x00007FF708810A80  BKE_id_free_ex C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\lib_id_delete.c:164
blender.exe         :0x00007FF70881DBB0  BKE_main_free C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\main.c:76
blender.exe         :0x00007FF7087C4340  BKE_blender_globals_clear C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\blender.c:184
blender.exe         :0x00007FF708818C60  setup_app_data C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\blendfile.c:285
blender.exe         :0x00007FF708818110  BKE_blendfile_read_setup C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\blendfile.c:480
blender.exe         :0x00007FF7094CB9E0  BKE_memfile_undo_decode C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\blender_undo.c:98
blender.exe         :0x00007FF70907FF60  memfile_undosys_step_decode C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\undo\memfile_undo.c:195
blender.exe         :0x00007FF708817C70  undosys_step_decode C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\undo_system.c:219
blender.exe         :0x00007FF708817180  BKE_undosys_step_load_data_ex C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\undo_system.c:830
blender.exe         :0x00007FF708817A40  BKE_undosys_step_undo C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\undo_system.c:910
blender.exe         :0x00007FF709081590  ed_undo_step_direction C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\undo\ed_undo.c:306
blender.exe         :0x00007FF709081360  ed_undo_exec C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\undo\ed_undo.c:520
blender.exe         :0x00007FF708753A20  wm_operator_invoke C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:1363
blender.exe         :0x00007FF708751610  wm_handler_operator_call C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:2345
blender.exe         :0x00007FF708752E30  wm_handlers_do_keymap_with_keymap_handler C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:2697
blender.exe         :0x00007FF7087525C0  wm_handlers_do_intern C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:3024
blender.exe         :0x00007FF708751C30  wm_handlers_do C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:3164
blender.exe         :0x00007FF70874F030  wm_event_do_handlers C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:3766
blender.exe         :0x00007FF7087397C0  WM_main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm.c:650
blender.exe         :0x00007FF708734FC0  main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\creator\creator.c:563
blender.exe         :0x00007FF709493E68  __scrt_common_main_seh d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
KERNEL32.DLL        :0x00007FFA55A87020  BaseThreadInitThunk
ntdll.dll           :0x00007FFA572E2630  RtlUserThreadStart```
**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.96 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-09-08 07:56, hash: `2b2d427bba` Worked: `54f5c174a8` Fisrt not working commit: 2b2d427bba **Short description of error** Crash when adding new texture in shader node then pressing undo. **Exact steps for others to reproduce the error** - Open default scene - Switch to Shading workspace - Add `Image Texture` - Create a new Image # Undo ![Animation.gif](https://archive.blender.org/developer/F10391587/Animation.gif) --- Stack trace: ```lines blender.exe :0x00007FF70934F240 GPU_texture_free C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\gpu\intern\gpu_texture.cc:523 blender.exe :0x00007FF70881BCE0 image_free_gpu C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\image_gpu.c:556 blender.exe :0x00007FF7087D16E0 BKE_image_free_buffers C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\image.c:539 blender.exe :0x00007FF7087D0240 image_free_data C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\image.c:179 blender.exe :0x00007FF708810A80 BKE_id_free_ex C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\lib_id_delete.c:164 blender.exe :0x00007FF70881DBB0 BKE_main_free C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\main.c:76 blender.exe :0x00007FF7087C4340 BKE_blender_globals_clear C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\blender.c:184 blender.exe :0x00007FF708818C60 setup_app_data C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\blendfile.c:285 blender.exe :0x00007FF708818110 BKE_blendfile_read_setup C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\blendfile.c:480 blender.exe :0x00007FF7094CB9E0 BKE_memfile_undo_decode C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\blender_undo.c:98 blender.exe :0x00007FF70907FF60 memfile_undosys_step_decode C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\undo\memfile_undo.c:195 blender.exe :0x00007FF708817C70 undosys_step_decode C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\undo_system.c:219 blender.exe :0x00007FF708817180 BKE_undosys_step_load_data_ex C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\undo_system.c:830 blender.exe :0x00007FF708817A40 BKE_undosys_step_undo C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\undo_system.c:910 blender.exe :0x00007FF709081590 ed_undo_step_direction C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\undo\ed_undo.c:306 blender.exe :0x00007FF709081360 ed_undo_exec C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\undo\ed_undo.c:520 blender.exe :0x00007FF708753A20 wm_operator_invoke C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:1363 blender.exe :0x00007FF708751610 wm_handler_operator_call C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:2345 blender.exe :0x00007FF708752E30 wm_handlers_do_keymap_with_keymap_handler C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:2697 blender.exe :0x00007FF7087525C0 wm_handlers_do_intern C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:3024 blender.exe :0x00007FF708751C30 wm_handlers_do C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:3164 blender.exe :0x00007FF70874F030 wm_event_do_handlers C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:3766 blender.exe :0x00007FF7087397C0 WM_main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm.c:650 blender.exe :0x00007FF708734FC0 main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\creator\creator.c:563 blender.exe :0x00007FF709493E68 __scrt_common_main_seh d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 KERNEL32.DLL :0x00007FFA55A87020 BaseThreadInitThunk ntdll.dll :0x00007FFA572E2630 RtlUserThreadStart```
Author

Added subscriber: @you.le

Added subscriber: @you.le

#92826 was marked as duplicate of this issue

#92826 was marked as duplicate of this issue

#91710 was marked as duplicate of this issue

#91710 was marked as duplicate of this issue

#92454 was marked as duplicate of this issue

#92454 was marked as duplicate of this issue

#92428 was marked as duplicate of this issue

#92428 was marked as duplicate of this issue

#92341 was marked as duplicate of this issue

#92341 was marked as duplicate of this issue

#92205 was marked as duplicate of this issue

#92205 was marked as duplicate of this issue

#92148 was marked as duplicate of this issue

#92148 was marked as duplicate of this issue

#92095 was marked as duplicate of this issue

#92095 was marked as duplicate of this issue

#92016 was marked as duplicate of this issue

#92016 was marked as duplicate of this issue

blender/blender-addons#91965 was marked as duplicate of this issue

blender/blender-addons#91965 was marked as duplicate of this issue

#91637 was marked as duplicate of this issue

#91637 was marked as duplicate of this issue

#91501 was marked as duplicate of this issue

#91501 was marked as duplicate of this issue
Author

This patch seems to prevent the crash:

p.diff

This patch seems to prevent the crash: [p.diff](https://archive.blender.org/developer/F10393158/p.diff)

Added subscriber: @JacobMerrill-1

Added subscriber: @JacobMerrill-1

In #91294#1218296, @you.le wrote:
This patch seems to prevent the crash:

p.diff

<3

> In #91294#1218296, @you.le wrote: > This patch seems to prevent the crash: > > [p.diff](https://archive.blender.org/developer/F10393158/p.diff) <3
Member

Added subscribers: @Jeroen-Bakker, @lichtwerk

Added subscribers: @Jeroen-Bakker, @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

@Jeroen-Bakker: can you check (the patch)?
@you.le: usually it is good to submit patches here https://developer.blender.org/differential/diff/create/

@Jeroen-Bakker: can you check (the patch)? @you.le: usually it is good to submit patches here https://developer.blender.org/differential/diff/create/

Added subscriber: @Olliver

Added subscriber: @Olliver

Please dont forget about this one

Please dont forget about this one
Member

Added subscribers: @JorgeBernalMartinez, @PratikPB2123

Added subscribers: @JorgeBernalMartinez, @PratikPB2123

@Jeroen-Bakker could you help with this one?

@Jeroen-Bakker could you help with this one?
Member

Added subscriber: @pafurijaz-4

Added subscriber: @pafurijaz-4
Author

Finally, I tried to push my first patch in upbge but today I realized that it was still crashing in some scenes.

I pushed a second "fix attempt" instead which seems to work better: 2b3b35c661

Finally, I tried to push my first patch in upbge but today I realized that it was still crashing in some scenes. I pushed a second "fix attempt" instead which seems to work better: https://github.com/UPBGE/upbge/commit/2b3b35c66149b312d296cf4bb372d36329dbed86
Member

Added subscriber: @Thane5

Added subscriber: @Thane5
Member

Added subscribers: @1029910278, @EAW, @mont29, @mano-wii

Added subscribers: @1029910278, @EAW, @mont29, @mano-wii

Added subscribers: @georgK, @iss

Added subscribers: @georgK, @iss
Pratik Borhade self-assigned this 2021-10-13 08:11:45 +02:00
Pratik Borhade removed their assignment 2021-10-14 07:05:04 +02:00
Member

Added subscriber: @3di

Added subscriber: @3di
Member

Added subscriber: @ZedDB

Added subscriber: @ZedDB
Member

Added subscriber: @Diogo_Valadares

Added subscriber: @Diogo_Valadares
Member

Added subscriber: @AFWS

Added subscriber: @AFWS

Added subscriber: @jack.herbert

Added subscriber: @jack.herbert

It looks like undoing any "add image" operation causes the crash, be it the Add>Image in 3D view or any "Image" input nodes from the shader editor and the compositor.
The only exceptions I found were the Movie Clip node and the VSE.
Also doesn't make a difference which render engine selected.

It looks like undoing any "add image" operation causes the crash, be it the `Add`>`Image` in 3D view or any "Image" input nodes from the shader editor and the compositor. The only exceptions I found were the Movie Clip node and the VSE. Also doesn't make a difference which render engine selected.

This issue was referenced by 8e56f3e8a3

This issue was referenced by 8e56f3e8a36d76ad1765f939c018a5ec3c01faab
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Jeroen Bakker self-assigned this 2021-10-25 11:42:07 +02:00

Added subscriber: @maochoa

Added subscriber: @maochoa
Member

Added subscriber: @JackHainsworth

Added subscriber: @JackHainsworth
Thomas Dinges added this to the 3.0 milestone 2023-02-08 15:59:03 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
10 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#91294
No description provided.