VSE: 'Clear fade' function clears every opacity/volume keyframe and resets non-default baseline value #91386

New Issue

David Salvo · 2021-09-13T19:54:20+02:00

David Salvo commented

2021-09-13 19:54:20 +02:00

System Information
Operating system: Linux-5.4.0-84-generic-x86_64-with-glibc2.31 64 Bits
Graphics card: GeForce 9800 GT/PCIe/SSE2 NVIDIA Corporation 3.3.0 NVIDIA 340.108

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-25 23:03, hash: 70fbdcb6bf
Worked: Unsure

Short description of error
The 'Clear fade' function used on either a visual or audio strip does not only clear the start/end fade(s), but any other set opacity/volume keyframes as well. It will also reset the baseline value to 1, even if the fades in the strip clearly operate on a baseline set to other than 1.

Exact steps for others to reproduce the error
clear-fade-function-clears-internal-value-changes-and-does-not-preserve-non-default-baseline-value.blend
(NOTE: In blend file, choose 'Clear fade' from the context menu for the top strip)

Add sound or visual strip
Change opacity/volume to 0.5
Choose 'Fade in and out' from the context menu, and note that the changed 0.5 baseline has been respected
Add a manual keyframe change/fluctuation somewhere in the middle of the strip
Choose 'Clear fade' from the context menu
Notice that all keyframes including the middle ones are now gone, as well as the 0.5 baseline value (replaced by default 1.0)

It is not expected that any fades apart from in and out will be cleared. In particular, it is quite common to have volume keyframes toyed with throughout the strip, so I do think targeting just the ins and outs is useful, certainly much more so than destroying all the keyframes (which one can achieve by choosing "Clear keyframes" directly on the property).

Also all the options to add fades are for adding fade-ins and fade-outs, so it's expected that the "Clear fade" will remove fade ins/outs as well. Either way, the description should be made clearer to reflect what will really happen.

A user-set, non-default baseline should also be preserved, if it clearly exists.

**System Information** Operating system: Linux-5.4.0-84-generic-x86_64-with-glibc2.31 64 Bits Graphics card: GeForce 9800 GT/PCIe/SSE2 NVIDIA Corporation 3.3.0 NVIDIA 340.108 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-25 23:03, hash: `70fbdcb6bf` Worked: Unsure **Short description of error** The 'Clear fade' function used on either a visual or audio strip does not only clear the start/end fade(s), but any other set opacity/volume keyframes as well. It will also reset the baseline value to 1, even if the fades in the strip clearly operate on a baseline set to other than 1. **Exact steps for others to reproduce the error** [clear-fade-function-clears-internal-value-changes-and-does-not-preserve-non-default-baseline-value.blend](https://archive.blender.org/developer/F10409338/clear-fade-function-clears-internal-value-changes-and-does-not-preserve-non-default-baseline-value.blend) (NOTE: In blend file, choose 'Clear fade' from the context menu for the top strip) - Add sound or visual strip - Change opacity/volume to 0.5 - Choose 'Fade in and out' from the context menu, and note that the changed 0.5 baseline has been respected - Add a manual keyframe change/fluctuation somewhere in the middle of the strip - Choose 'Clear fade' from the context menu - Notice that all keyframes including the middle ones are now gone, as well as the 0.5 baseline value (replaced by default 1.0) It is not expected that any fades apart from in and out will be cleared. In particular, it is quite common to have volume keyframes toyed with throughout the strip, so I do think targeting just the ins and outs is useful, certainly much more so than destroying all the keyframes (which one can achieve by choosing "Clear keyframes" directly on the property). Also all the options to add fades are for adding fade-ins and fade-outs, so it's expected that the "Clear fade" will remove fade ins/outs as well. Either way, the description should be made clearer to reflect what will really happen. A user-set, non-default baseline should also be preserved, if it clearly exists.

David Salvo commented

2021-09-13 19:54:20 +02:00

Added subscriber: @slinkeepie

David Salvo changed title from ~~VSE: 'Clear fade' function clears every opacity/volume keyframe and resets baseline value~~ to VSE: 'Clear fade' function clears every opacity/volume keyframe and resets non-default baseline value

2021-09-13 19:55:01 +02:00

tintwotin commented

2021-09-13 20:09:28 +02:00

Added subscriber: @tintwotin

tintwotin commented

2021-09-13 20:09:28 +02:00

The fade functions are implemented as a temporary solution till time permits a proper implementation, maybe modifier based, so it will not interfere with f-curves. The functions are actually coded in python and can be updated without building Blender. Search for a file called sequencer.py in your Blender installation if you want to tinker with it, save it and restart Blender to see the changes.

David Salvo commented

2021-09-14 04:08:27 +02:00

In #91386#1219578, @tintwotin wrote:
The fade functions are implemented as a temporary solution till time permits a proper implementation, maybe modifier based, so it will not interfere with f-curves. The functions are actually coded in python and can be updated without building Blender. Search for a file called sequencer.py in your Blender installation if you want to tinker with it, save it and restart Blender to see the changes.

Okay interesting, thanks for the heads up... if that's the case then I've no problem if this is closed (and hopefully it remains on the to-do list!).

> In #91386#1219578, @tintwotin wrote: > The fade functions are implemented as a temporary solution till time permits a proper implementation, maybe modifier based, so it will not interfere with f-curves. The functions are actually coded in python and can be updated without building Blender. Search for a file called sequencer.py in your Blender installation if you want to tinker with it, save it and restart Blender to see the changes. Okay interesting, thanks for the heads up... if that's the case then I've no problem if this is closed (and hopefully it remains on the to-do list!).

Philipp Oeser commented

2021-09-14 12:37:11 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-09-14 12:37:11 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-09-14 12:37:11 +02:00

In #91386#1219649, @slinkeepie wrote:

In #91386#1219578, @tintwotin wrote:
The fade functions are implemented as a temporary solution till time permits a proper implementation, maybe modifier based, so it will not interfere with f-curves. The functions are actually coded in python and can be updated without building Blender. Search for a file called sequencer.py in your Blender installation if you want to tinker with it, save it and restart Blender to see the changes.

Okay interesting, thanks for the heads up... if that's the case then I've no problem if this is closed (and hopefully it remains on the to-do list!).

I'd still keep this as this is really not behaving as it should.
(I know this is not the only case)
I also know this is not likely to be fixed (since as @tintwotin said, fades are just "regular" FCurves and identifying keyframes that belong to fades rather than handmade animation is pretty much not going to work I assume)
But would prefer #vfx_video devs to close this.

> In #91386#1219649, @slinkeepie wrote: >> In #91386#1219578, @tintwotin wrote: >> The fade functions are implemented as a temporary solution till time permits a proper implementation, maybe modifier based, so it will not interfere with f-curves. The functions are actually coded in python and can be updated without building Blender. Search for a file called sequencer.py in your Blender installation if you want to tinker with it, save it and restart Blender to see the changes. > > Okay interesting, thanks for the heads up... if that's the case then I've no problem if this is closed (and hopefully it remains on the to-do list!). I'd still keep this as this is really not behaving as it should. (I know this is not the only case) I also know this is not likely to be fixed (since as @tintwotin said, fades are just "regular" FCurves and identifying keyframes that belong to fades rather than handmade animation is pretty much not going to work I assume) But would prefer #vfx_video devs to close this.

Richard Antalik commented

2021-11-04 09:16:06 +01:00

Added subscriber: @iss

Richard Antalik commented

2021-11-04 09:16:06 +01:00

Checking code, I see that this works as designed.

Still would be fine to improve this, but question is how exactly. Keyframes can't be tagged as fades and they can be moved around.

Best solution I think would be to check for keyframes at pre-defined frames and there would have to be no other keyframes, otherwise the script would have no idea what to do. If anybody have ideas, feel free to share.

Checking code, I see that this works as designed. Still would be fine to improve this, but question is how exactly. Keyframes can't be tagged as fades and they can be moved around. Best solution I think would be to check for keyframes at pre-defined frames and there would have to be no other keyframes, otherwise the script would have no idea what to do. If anybody have ideas, feel free to share.

Richard Antalik added this to the Video Sequencer project 2023-02-09 20:57:27 +01:00

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

VSE: 'Clear fade' function clears every opacity/volume keyframe and resets non-default baseline value #91386