Grease pencil Time offset modifier crash #91454

New Issue

Thawatchai Chunhachai · 2021-09-16T13:57:18+02:00

2021-09-16 13:57:18 +02:00

System Information
Operating system: Windows
Graphics card: RTX2060 (notebook)

Blender Version
Broken: 2.93.2
Worked: (newest version of Blender that worked as expected)

Short description of error
Grease pencil Time offset modifier crash when create a loop and go to frame 0
It's working fine if I'm in Frame 1- 200 and so on.

Exact steps for others to reproduce the error
create grease pencil object
Draw animation 10 frames
add time offset modifer > make it loop > custom frame range end at frame 12
go to frame 0
Blender will be very slow or crash.Ch010_Pg010_Pn010_Anim_bird_v09_scale.blend

**System Information** Operating system: Windows Graphics card: RTX2060 (notebook) **Blender Version** Broken: 2.93.2 Worked: (newest version of Blender that worked as expected) **Short description of error** Grease pencil Time offset modifier crash when create a loop and go to frame 0 It's working fine if I'm in Frame 1- 200 and so on. **Exact steps for others to reproduce the error** create grease pencil object Draw animation 10 frames add time offset modifer > make it loop > custom frame range end at frame 12 go to frame 0 Blender will be very slow or crash.[Ch010_Pg010_Pn010_Anim_bird_v09_scale.blend](https://archive.blender.org/developer/F10427578/Ch010_Pg010_Pn010_Anim_bird_v09_scale.blend)

Thawatchai Chunhachai commented

2021-09-16 13:57:18 +02:00

Added subscriber: @Boat-Thawatchai-Chunhachai

Antonio Vazquez commented

2021-09-16 18:18:02 +02:00

Added subscriber: @antoniov

Antonio Vazquez commented

2021-09-16 18:18:02 +02:00

Have you tested last build of 3.0? IIRC this bug was fixed in 3.0.

Thawatchai Chunhachai commented

2021-09-16 19:55:28 +02:00

Oh, Thanks it' works perfectly on the latest version.
Next time I'll try out the latest one first.
Thanks a lot Antonio :)

Oh, Thanks it' works perfectly on the latest version. Next time I'll try out the latest one first. Thanks a lot Antonio :)

Thawatchai Chunhachai commented

2021-09-16 20:14:09 +02:00

after I try it again with the latest version of Blender 3.0 and if you scroll to time line back and forth before frame 1 (frame 0, frame -3,frame -5 ) Blender will sstart to slow down again.

Philipp Oeser commented

2021-09-17 09:56:06 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-09-17 09:56:07 +02:00

The crash was fixed by af7233368d, but I can confirm blender is kind of hanging in negative keyframes in this file (this was also the case prior to f3bf87e588 though)
@antoniov: mind checking?

The crash was fixed by af7233368d, but I can confirm blender is kind of hanging in negative keyframes in this file (this was also the case prior to f3bf87e588 though) @antoniov: mind checking?

Philipp Oeser commented

2021-09-17 09:57:10 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Antonio Vazquez commented

2021-09-17 11:28:54 +02:00

@lichtwerk I have removed all modifers except TimeOffset and the loop is "sometimes"... when I stop the running, the program is always in this section.

It looks some task locking not related to GPencil itself.

@lichtwerk I have removed all modifers except TimeOffset and the loop is "sometimes"... when I stop the running, the program is always in this section. ![image.png](https://archive.blender.org/developer/F10442157/image.png) It looks some task locking not related to GPencil itself.

Antonio Vazquez commented

2021-09-17 11:33:05 +02:00

I can get the endless loop without any modifier.

Philipp Oeser commented

2021-09-17 11:59:05 +02:00

In #91454#1221335, @antoniov wrote:
I can get the endless loop without any modifier.

Is this only in negative frames? mind sharing a file (without modifiers)?

> In #91454#1221335, @antoniov wrote: > I can get the endless loop without any modifier. Is this only in negative frames? mind sharing a file (without modifiers)?

Antonio Vazquez commented

2021-09-17 12:12:23 +02:00

Yes, only negatives using master compiled just now.

The file:

Chicken_NoTime.blend

The video with the problem.

2021-09-17 12-11-00.mp4

Yes, only negatives using `master` compiled just now. The file: [Chicken_NoTime.blend](https://archive.blender.org/developer/F10442669/Chicken_NoTime.blend) The video with the problem. [2021-09-17 12-11-00.mp4](https://archive.blender.org/developer/F10442673/2021-09-17_12-11-00.mp4)

Antonio Vazquez commented

2021-09-17 15:47:41 +02:00

@lichtwerk I have tested deleting both GP objects and when move to negative frames crash too.

Edit. False alarm.... it was slow, but no endless loop.

@lichtwerk I have tested deleting both GP objects and when move to negative frames crash too. Edit. False alarm.... it was slow, but no endless loop.

Antonio Vazquez commented

2021-09-17 16:00:14 +02:00

I hadn't seen the file has 2 GP objects and the othe rhas timeoffset too..if you remove the timeoffset of both the loop never happens...I'm going to do more tests

Antonio Vazquez commented

2021-09-17 16:13:34 +02:00

I have added some printf to this function:

deg::Depsgraph *deg_graph = reinterpret_cast<deg::Depsgraph *>(graph);
const Scene *scene = DEG_get_input_scene(graph);

deg_graph->tag_time_source();
deg_graph->frame = frame;
printf("a1->");
deg_graph->ctime = BKE_scene_frame_to_ctime(scene, frame);
printf("a2->");
deg_flush_updates_and_refresh(deg_graph);
printf("done\n");

}```

I have seen the result when the system loop is:

```a1->a2->done
a1->a2->done
a1->a2->done
a1->a2->done
a1->a2->done
a1->a2->done
a1->a2->done
a1->a2->```

It's clear the problem is in `deg_flush_updates_and_refresh(deg_graph);` that never ends. The error is in `deg::deg_evaluate_on_refresh(deg_graph);` step of the function.

I have added some printf to this function: ```void DEG_evaluate_on_framechange(Depsgraph *graph, float frame) { ``` deg::Depsgraph *deg_graph = reinterpret_cast<deg::Depsgraph *>(graph); const Scene *scene = DEG_get_input_scene(graph); ``` ``` deg_graph->tag_time_source(); deg_graph->frame = frame; printf("a1->"); deg_graph->ctime = BKE_scene_frame_to_ctime(scene, frame); printf("a2->"); deg_flush_updates_and_refresh(deg_graph); printf("done\n"); ``` }``` I have seen the result when the system loop is: ```a1->a2->done a1->a2->done a1->a2->done a1->a2->done a1->a2->done a1->a2->done a1->a2->done a1->a2->``` It's clear the problem is in `deg_flush_updates_and_refresh(deg_graph);` that never ends. The error is in `deg::deg_evaluate_on_refresh(deg_graph);` step of the function.

Antonio Vazquez commented

2022-09-28 16:05:01 +02:00

Added subscriber: @frogstomp-4

Antonio Vazquez commented

2022-09-28 16:05:01 +02:00

@frogstomp-4 could you try if you can replicate this bug?

Aleš Jelovčan commented

2022-09-29 08:47:45 +02:00

Could not reproduce in latest versions. The timeline is restricted so could not even scrub in negative frames.
Was this tested also agains latext 3.3 and above?

Could not reproduce in latest versions. The timeline is restricted so could not even scrub in negative frames. Was this tested also agains latext 3.3 and above?

Thawatchai Chunhachai commented

2022-09-29 09:12:17 +02:00

Hi, I saw this in my email. I tried this scene with the negative frames in Blender 3.3 and it doesn't slow down or crash anymore :)

Antonio Vazquez commented

2022-09-29 09:46:15 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Antonio Vazquez closed this issue

2022-09-29 09:46:15 +02:00

Antonio Vazquez self-assigned this 2022-09-29 09:46:15 +02:00

Antonio Vazquez commented

2022-09-29 09:46:15 +02:00

I'm going to close this task. If you find again any problem, please open a new report.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Grease pencil Time offset modifier crash #91454