GPencil: Square type strokes do not react to Rotation option with Solid Shading #91467

New Issue

Henrik D. · 2021-09-16T23:09:55+02:00

Henrik D. commented

2021-09-16 23:09:55 +02:00

System Information
Operating system: Linux-5.10.0-6-amd64-x86_64-with-glibc2.31 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.73.01

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-09-16 14:11, hash: 73ed076489
Worked: ?

Short description of error
The stroke type Squares draw little squares at the points of the stroke. The rotation is controlled by the alignment option and the rotation slider, which in this case does nothing if solid shading mode is selected. Note that textures are not displayed in solid shading mode and even if used the squares don't rotate as long as I am in solid shading mode.

Exact steps for others to reproduce the error

Add default Stroke Grease Pencil Object
Navigate to the Material and change Line Type to Squares
Make sure you are in Solid Shading Mode with "Color" not set to "Texture"
Change the Rotation slider from the same panel, which says in the tooltip it should rotate the squares
observe how the squares do nothing at all.

**System Information** Operating system: Linux-5.10.0-6-amd64-x86_64-with-glibc2.31 64 Bits Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.73.01 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-09-16 14:11, hash: `73ed076489` Worked: ? **Short description of error** The stroke type Squares draw little squares at the points of the stroke. The rotation is controlled by the alignment option and the rotation slider, which in this case does nothing if solid shading mode is selected. Note that textures are not displayed in solid shading mode and even if used the squares don't rotate as long as I am in solid shading mode. **Exact steps for others to reproduce the error** 1. Add default Stroke Grease Pencil Object 2. Navigate to the Material and change Line Type to Squares 3. Make sure you are in Solid Shading Mode with "Color" not set to "Texture" 4. Change the Rotation slider from the same panel, which says in the tooltip it should rotate the squares 5. observe how the squares do nothing at all.

Henrik D. commented

2021-09-16 23:09:55 +02:00

Added subscriber: @HDMaster84

Antonio Vazquez commented

2021-09-17 08:20:19 +02:00

Added subscriber: @antoniov

Antonio Vazquez commented

2021-09-17 08:20:19 +02:00

It must rotate the texture...check that.

Antonio Vazquez commented

2021-09-17 08:21:37 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Antonio Vazquez commented

2021-09-17 08:21:37 +02:00

2021-09-17 08-20-57.mp4

[2021-09-17 08-20-57.mp4](https://archive.blender.org/developer/F10440990/2021-09-17_08-20-57.mp4)

Henrik D. commented

2021-09-17 10:51:57 +02:00

The bug is that it does nothing if the Style is Solid. If Texture is selected then it will look as if it rotates the square (not just the uv) so why won't it do that for the solid squares?

Also... neither the tooltip nor the documentation mention textures...

The bug is that it does nothing if the Style is Solid. If Texture is selected then it will look as if it rotates the square (not just the uv) so why won't it do that for the solid squares? Also... neither the tooltip nor the documentation mention textures...

Henrik D. commented

2021-09-17 10:52:34 +02:00

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Antonio Vazquez commented

2021-09-17 11:05:45 +02:00

The option is in Fill mode, so no change in the geometry. The fix must be fix the tooltip. and disable the option if the mode is Solid Fill.

Edit. Sorry I was wrong...it's stroke... I need review all before doing any change.

The option is in Fill mode, so no change in the geometry. The fix must be fix the tooltip. and disable the option if the mode is Solid Fill. Edit. Sorry I was wrong...it's stroke... I need review all before doing any change.

Antonio Vazquez commented

2021-09-17 11:06:29 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Antonio Vazquez self-assigned this 2021-09-17 11:06:29 +02:00

Antonio Vazquez commented

2021-09-17 11:12:53 +02:00

Changed status from 'Confirmed' to: 'Needs User Info'

Antonio Vazquez commented

2021-09-17 11:12:53 +02:00

I cannot reproduce in my system...maybe I'm not looking the same.

2021-09-17 11-10-02.mp4

I cannot reproduce in my system...maybe I'm not looking the same. [2021-09-17 11-10-02.mp4](https://archive.blender.org/developer/F10442036/2021-09-17_11-10-02.mp4)

Henrik D. commented

2021-09-17 11:30:25 +02:00

@antoniov Oh wow, this just became a lot more interesting!
You are explicitly showing that it works in solid shading mode. I figured out that it does actually work even on my system if I am in rendered mode, but it does nothing in solid shading mode.
Here is a Video of me doing the same:
2021-09-17_11-27-01.mp4

I will update the summary with the new information

@antoniov Oh wow, this just became a lot more interesting! You are explicitly showing that it works in solid shading mode. I figured out that it does actually work even on my system if I am in rendered mode, but it does nothing in solid shading mode. Here is a Video of me doing the same: [2021-09-17_11-27-01.mp4](https://archive.blender.org/developer/F10442166/2021-09-17_11-27-01.mp4) I will update the summary with the new information

Henrik D. changed title from ~~GPencil: Square type strokes do not react to Rotation option~~ to GPencil: Square type strokes do not react to Rotation option with Solid Shading

2021-09-17 11:32:57 +02:00

Antonio Vazquez commented

2021-09-17 13:12:16 +02:00

I cannot reproduce in any Engine/Shading mode... could you test with this file?

Test_Rota_UV.blend

I cannot reproduce in any Engine/Shading mode... could you test with this file? ![image.png](https://archive.blender.org/developer/F10444036/image.png) [Test_Rota_UV.blend](https://archive.blender.org/developer/F10444023/Test_Rota_UV.blend)

Henrik D. commented

2021-09-17 13:44:04 +02:00

strange... I can not reproduce with that file.
Can you reproduce with this file?
gp_test_square_rotation.blend

strange... I can not reproduce with that file. Can you reproduce with this file? [gp_test_square_rotation.blend](https://archive.blender.org/developer/F10444613/gp_test_square_rotation.blend)

Antonio Vazquez commented

2021-09-17 16:50:19 +02:00

I have seen where is the difference:

2021-09-17 16-49-23.mp4

Internally, the solid is just a texture filled of same color.

I have seen where is the difference: [2021-09-17 16-49-23.mp4](https://archive.blender.org/developer/F10447810/2021-09-17_16-49-23.mp4) Internally, the solid is just a texture filled of same color.

Henrik D. commented

2021-09-17 17:59:38 +02:00

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Antonio Vazquez commented

2021-09-20 12:51:25 +02:00

Actually the code is designed to use the rotation only in texture mode. As the Draw Engine is going to change with the new Eevee integration, IMHO the best option now is mark as KNow Issue and change the tooltip.

Antonio Vazquez commented

2021-09-20 12:51:58 +02:00

Added subscriber: @HooglyBoogly

Antonio Vazquez commented

2021-09-20 12:51:58 +02:00

@HooglyBoogly Do you think the tooltip is correct now?

index 8d0d3adab8b..4078691444b 100644
    - a/source/blender/makesrna/intern/rna_material.c
+++ b/source/blender/makesrna/intern/rna_material.c
@@ -604,8 +604,10 @@ static void rna_def_material_greasepencil(BlenderRNA *brna)

RNA_def_property_float_default(prop, 0.0f);
RNA_def_property_range(prop, -DEG2RADF(90.0f), DEG2RADF(90.0f));
RNA_def_property_ui_range(prop, -DEG2RADF(90.0f), DEG2RADF(90.0f), 10, 3);

- RNA_def_property_ui_text(
- prop, "Rotation", "Additional rotation applied to dots and square strokes");
+  RNA_def_property_ui_text(prop,
+                           "Rotation",
+                           "Additional rotation applied to dots and square texture of strokes. "
+                           "Only valid in texture shading mode");

RNA_def_property_update(prop, NC_GPENCIL | ND_SHADING, "rna_MaterialGpencil_update");

/* pass index for future compositing and editing tools */

@HooglyBoogly Do you think the tooltip is correct now? ```diff --git a/source/blender/makesrna/intern/rna_material.c b/source/blender/makesrna/intern/rna_material.c index 8d0d3adab8b..4078691444b 100644 - a/source/blender/makesrna/intern/rna_material.c +++ b/source/blender/makesrna/intern/rna_material.c @@ -604,8 +604,10 @@ static void rna_def_material_greasepencil(BlenderRNA *brna) ``` RNA_def_property_float_default(prop, 0.0f); RNA_def_property_range(prop, -DEG2RADF(90.0f), DEG2RADF(90.0f)); RNA_def_property_ui_range(prop, -DEG2RADF(90.0f), DEG2RADF(90.0f), 10, 3); ``` - RNA_def_property_ui_text( - prop, "Rotation", "Additional rotation applied to dots and square strokes"); + RNA_def_property_ui_text(prop, + "Rotation", + "Additional rotation applied to dots and square texture of strokes. " + "Only valid in texture shading mode"); ``` RNA_def_property_update(prop, NC_GPENCIL | ND_SHADING, "rna_MaterialGpencil_update"); ``` ``` /* pass index for future compositing and editing tools */ ``` ```

Hans Goudey commented

2021-09-20 14:31:11 +02:00

I might suggest changing valid to applies, but sure, that makes sense.

I might suggest changing `valid` to `applies`, but sure, that makes sense.

Antonio Vazquez commented

2021-09-20 15:33:21 +02:00

@HooglyBoogly Thanks, I have changed to applies.

@HooglyBoogly Thanks, I have changed to `applies`.

Antonio Vazquez commented

2021-09-20 15:33:31 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Antonio Vazquez removed their assignment 2021-09-20 15:34:13 +02:00

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GPencil: Square type strokes do not react to Rotation option with Solid Shading #91467