Cycles HIP device #91571

New Issue

Brecht Van Lommel · 2021-09-21T16:02:12+02:00

Brecht Van Lommel commented

2021-09-21 16:02:12 +02:00

Tasks to keep track of HIP device development tasks.

Windows support and stability
- Upgrade HIP SDK to 22.10
- RDNA2
- RDNA1
- Vega
Linux support and stability
- Crash in hipGetDeviceProperties
- RDNA3 (D16507)
- RDNA2
- RDNA1 (#97591)
- Vega
Hardware ray-tracing
Wiki build documentation for building with hipcc on Linux and Windows
Clip mode in Image Texture node not supported (#92975)
Image texture size is limited, could detect this and resize, or support tiling (#94057, #93109)
Compute capability checking (if needed)
Integrator state size estimation depending on the GPU

On hold

~~Deduplicate CUDA and HIP host code~~ (No practical mechanism for this currently)
~~Graphics interop~~ (Wait until overall HIP stability improves before risking this)

Completed for 3.0 release:

Buildbot setup of hipcc
- Install on CentOS workers
- Install on Windows workers
- Enable Windows binaries on the buildbot
Determine range of supported cards on Linux and Windows for 3.0
Detect supported cards in the code (D12958)
Bug: instancing rendering artifact in bmw27 scene
Supported GPU hardware list for documentation
#92972 (Cycles HIP graphics interop issue on AMD 5500 XT and Windows)
Windows driver available
#92984 (Cycles HIP crash with smoke volume)
#93109 (Cycles HIP device missing driver version check)

Tasks to keep track of HIP device development tasks. - [x] Windows support and stability - [x] Upgrade HIP SDK to 22.10 - [x] RDNA2 - [x] RDNA1 - [x] Vega - [x] Linux support and stability - [x] Crash in `hipGetDeviceProperties` - [x] RDNA3 ([D16507](https://archive.blender.org/developer/D16507)) - [x] RDNA2 - [x] RDNA1 (#97591) - [x] Vega - [x] Hardware ray-tracing - [x] Wiki build documentation for building with hipcc on Linux and Windows - [x] Clip mode in Image Texture node not supported (#92975) - [ ] Image texture size is limited, could detect this and resize, or support tiling (#94057, #93109) - [x] Compute capability checking (if needed) - [x] Integrator state size estimation depending on the GPU On hold - [ ] ~~Deduplicate CUDA and HIP host code~~ (No practical mechanism for this currently) - [ ] ~~Graphics interop~~ (Wait until overall HIP stability improves before risking this) Completed for 3.0 release: - [x] Buildbot setup of hipcc - [x] Install on CentOS workers - [x] Install on Windows workers - [x] Enable Windows binaries on the buildbot - [x] Determine range of supported cards on Linux and Windows for 3.0 - [x] Detect supported cards in the code ([D12958](https://archive.blender.org/developer/D12958)) - [x] Bug: instancing rendering artifact in bmw27 scene - [x] Supported GPU hardware list for documentation - [x] #92972 (Cycles HIP graphics interop issue on AMD 5500 XT and Windows) - [x] Windows driver available - [x] #92984 (Cycles HIP crash with smoke volume) - [x] #93109 (Cycles HIP device missing driver version check)

Brecht Van Lommel commented

2021-09-21 16:02:12 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Brecht Van Lommel commented

2021-09-21 16:02:12 +02:00

Added subscriber: @brecht

Raimund Klink commented

2021-09-21 16:12:03 +02:00

Added subscriber: @Raimund58

Steffen Dünner commented

2021-09-21 16:51:53 +02:00

Added subscriber: @SteffenD

Brian Savery (AMD) commented

2021-09-21 16:59:33 +02:00

Added subscriber: @BrianSavery

Paul Larson commented

2021-09-21 18:47:14 +02:00

Added subscriber: @GeorgiaPacific

Alaska commented

2021-09-22 00:04:18 +02:00

Added subscriber: @Alaska

Shengyu Qu commented

2021-09-22 08:39:49 +02:00

Added subscriber: @Stat_Headcrabed

Shengyu Qu commented

2021-09-22 08:39:49 +02:00

So AMD GPU cannot use blender on windows even after HIP support is implemented?

Raimund Klink commented

2021-09-22 09:19:34 +02:00

@Stat_Headcrabed Even with HIP implemented it would currently not work because the GPU driver to support it is not released yet.

Alaska commented

2021-09-22 11:07:00 +02:00

In #91571#1223528, @Stat_Headcrabed wrote:
So AMD GPU cannot use blender on windows even after HIP support is implemented?

At the moment it seems like the HIP implementation works on Linux with the right setup. There appear to be plans to add Windows support via the release of tools and a new GPU driver in the coming months. The current time line suggest that Windows support should be avaliable before the relase of Blender 3.0, but it is not garunteed that the HIP implementation will be added to/or enabled in Blender with the 3.0 release.

Notes about it can be found in the Render Meeting Notes : https://devtalk.blender.org/c/blender/meetings-archive/18

Plan to post a public patch soon in time for the 3.0 release, however drivers and compiler will not be available yet at that time. Since this can be disabled by default with a build option it’s fine to continue development like this in cycles-x/master to make things easier.

bsavery: this part pretty much explains it. HIP support will have a PR soon to the cycles-x, but the driver and compiler will not be available publicly yet (these should be available before Blender 3.0 releases.)
Source: https://devtalk.blender.org/t/2021-08-31-blender-rendering-meeting/20206/3

AMD HIP support will be submitted to code review soon, review will be prioritized by William and Brecht to make the deadline. As mentioned before, the required graphics drivers will not be available at the time this is expected to be merged, so it will not be immediately available for user testing.
Source: https://devtalk.blender.org/t/2021-09-14-blender-rendering-meeting/20469

> In #91571#1223528, @Stat_Headcrabed wrote: > So AMD GPU cannot use blender on windows even after HIP support is implemented? At the moment it seems like the HIP implementation works on Linux with the right setup. There appear to be plans to add Windows support via the release of tools and a new GPU driver in the coming months. The current time line suggest that Windows support should be avaliable before the relase of Blender 3.0, but it is not garunteed that the HIP implementation will be added to/or enabled in Blender with the 3.0 release. Notes about it can be found in the `Render Meeting Notes` : https://devtalk.blender.org/c/blender/meetings-archive/18 >>Plan to post a public patch soon in time for the 3.0 release, however drivers and compiler will not be available yet at that time. Since this can be disabled by default with a build option it’s fine to continue development like this in cycles-x/master to make things easier. >bsavery: this part pretty much explains it. HIP support will have a PR soon to the cycles-x, but the driver and compiler will not be available publicly yet (these should be available before Blender 3.0 releases.) >Source: https://devtalk.blender.org/t/2021-08-31-blender-rendering-meeting/20206/3 >AMD HIP support will be submitted to code review soon, review will be prioritized by William and Brecht to make the deadline. As mentioned before, the required graphics drivers will not be available at the time this is expected to be merged, so it will not be immediately available for user testing. >Source: https://devtalk.blender.org/t/2021-09-14-blender-rendering-meeting/20469

blender-admin commented

2021-09-28 16:51:14 +02:00

This issue was referenced by blender/cycles@fedbb9c898

This issue was referenced by blender/cycles@fedbb9c8987a67d0ca1a28ad1e6807436dea0568

blender-admin commented

2021-09-28 16:51:14 +02:00

This issue was referenced by 044a77352f

This issue was referenced by 044a77352f8a8a0e1f60190369d69ef26587b65f

Andy Cuccaro commented

2021-09-28 20:55:19 +02:00

Added subscriber: @AndyCuccaro

Julian Bruns commented

2021-09-29 21:30:51 +02:00

Added subscriber: @julian8bruns

hujin commented

2021-09-30 02:46:27 +02:00

Added subscriber: @2046411367

Jagannadhan Ravi commented

2021-10-04 22:28:58 +02:00

Added subscriber: @easythrees

Brecht Van Lommel commented

2021-10-05 14:04:47 +02:00

@BrianSavery , I'm trying to set this up on the buildbot but running into some issues. I did various improvements and fixes in 55b8fc7, but still running into problems.

What is CYCLES_HIP_BINARIES_ARCH support to be set to?
I get errors running hipcc, not sure if they would all be fixed by providing a proper architecture:

-- Found HIP /usr/bin/hipcc (4.3.21300)
...
[1/4] Generating kernel_unknown.fatbin
FAILED: intern/cycles/kernel/kernel_unknown.fatbin 
cd /home/brecht/dev/build_linux/intern/cycles/kernel && /usr/bin/hipcc -arch=unknown --fatbin /home/brecht/dev/blender/intern/cycles/kernel/device/hip/kernel.cpp -D CCL_NAMESPACE_BEGIN= -D CCL_NAMESPACE_END= -D HIPCC -m 64 -I /home/brecht/dev/blender/intern/cycles/kernel/.. -I /home/brecht/dev/blender/intern/cycles/kernel/device/hip --use_fast_math -o /home/brecht/dev/build_linux/intern/cycles/kernel/kernel_unknown.fatbin -D WITH_NANOVDB -I /home/brecht/dev/lib/linux_centos7_x86_64/nanovdb/include
clang-13: error: unsupported option '--fatbin'
clang-13: error: unsupported option '--use_fast_math'
clang-13: error: unknown argument: '-m'
clang-13: error: no such file or directory: '64'

@BrianSavery , I'm trying to set this up on the buildbot but running into some issues. I did various improvements and fixes in 55b8fc7, but still running into problems. * What is `CYCLES_HIP_BINARIES_ARCH` support to be set to? * I get errors running hipcc, not sure if they would all be fixed by providing a proper architecture: ``` -- Found HIP /usr/bin/hipcc (4.3.21300) ... [1/4] Generating kernel_unknown.fatbin FAILED: intern/cycles/kernel/kernel_unknown.fatbin cd /home/brecht/dev/build_linux/intern/cycles/kernel && /usr/bin/hipcc -arch=unknown --fatbin /home/brecht/dev/blender/intern/cycles/kernel/device/hip/kernel.cpp -D CCL_NAMESPACE_BEGIN= -D CCL_NAMESPACE_END= -D HIPCC -m 64 -I /home/brecht/dev/blender/intern/cycles/kernel/.. -I /home/brecht/dev/blender/intern/cycles/kernel/device/hip --use_fast_math -o /home/brecht/dev/build_linux/intern/cycles/kernel/kernel_unknown.fatbin -D WITH_NANOVDB -I /home/brecht/dev/lib/linux_centos7_x86_64/nanovdb/include clang-13: error: unsupported option '--fatbin' clang-13: error: unsupported option '--use_fast_math' clang-13: error: unknown argument: '-m' clang-13: error: no such file or directory: '64' ```

Firecrow Silvernight commented

2021-10-10 02:04:47 +02:00

Added subscriber: @fire

Pauan commented

2021-10-11 10:40:37 +02:00

Added subscriber: @pauanyu_blender

Sayak Biswas commented

2021-10-11 23:40:13 +02:00

Added subscriber: @Sayak-Biswas

周建峰 commented

2021-10-13 11:59:29 +02:00

Added subscriber: @2905710881

周建峰 commented

2021-10-13 11:59:29 +02:00

amd yes

Lahcene Belbachir commented

2021-10-13 13:42:10 +02:00

Added subscriber: @LahceneB

Eyad Ahmed commented

2021-10-14 13:22:36 +02:00

Added subscriber: @IyadAhmed

Andrea Monzini commented

2021-10-14 14:37:31 +02:00

Added subscriber: @AndreaMonzini

Andrea Monzini commented

2021-10-14 14:37:31 +02:00

As GNU/Linux user i think it would be important to help ( and ideally support ) the ROCm/HIP installation on other distros like for example Arch, GUIX Sytem, NixOS.
Or with Cycles HIP we will have less freedom on the OS we can use compared to the Cycles on OpenCL.

Anyway thank you for your work !

As GNU/Linux user i think it would be important to help ( and ideally support ) the ROCm/HIP installation on other distros like for example Arch, GUIX Sytem, NixOS. Or with Cycles HIP we will have less freedom on the OS we can use compared to the Cycles on OpenCL. Anyway thank you for your work !

Alexey commented

2021-10-15 08:27:24 +02:00

Added subscriber: @FreeCX

pikhosh commented

2021-10-18 10:50:07 +02:00

(Migrated from localhost:3001)

Added subscriber: @pikhosh

J. A. McCormick commented

2021-10-18 23:32:13 +02:00

Added subscriber: @Chou-Vieux

Diogo Valadares Reis dos Santos commented

2021-10-20 17:55:09 +02:00

Added subscriber: @Diogo_Valadares

s12a commented

2021-10-20 20:32:13 +02:00

Added subscriber: @s12a

Mylo Pinto Rizvi commented

2021-10-21 14:14:11 +02:00

Added subscriber: @Low_Polygon42

J. A. McCormick commented

2021-10-21 21:53:44 +02:00

Thank you for all your hard work. This will add more options as to the choices creators have when it comes to gpu's. Again, thank you.

William Leeson commented

2021-10-22 13:36:19 +02:00

Added subscriber: @leesonw

Fog commented

2021-10-24 10:23:10 +02:00

Added subscriber: @FogLizard

Fog commented

2021-10-24 10:23:10 +02:00

I have installed full rocm on Arch Linux and enabled HIP in CMakeLists.txt by overriding the options in the blender-git PKGBUILD, I do have HIP option under system preferences and my GPU and CPU shows up there.

However if I try to render with Cycles and GPU Compute, render fails with the following error:

Invalid value in hipDeviceGetAttribute(&pitch_alignment, hipDeviceAttributeTexturePitchAlignment, hipDevice)) (intern/cycles/device/hip/device_impl.cpp:116)

I have a Vega 64 and I've checked with rocminfo that it's arch is gfx900, which is missing in CMakeLists.txt:

set(CYCLES_HIP_BINARIES_ARCH gfx1010 gfx1011 gfx1012 gfx1030 gfx1031 gfx1032 gfx1034 CACHE STRING "AMD HIP architectures to build binaries for")

I have tried overriding this option in PKGBUILD file and recompiling, but apparently it didn't work.

cmake -G Ninja -S "$srcdir/blender" -B build
- C "${srcdir}/blender/build_files/cmake/config/blender_release.cmake"
- DCMAKE_INSTALL_PREFIX=/usr
- DCMAKE_BUILD_TYPE=Release
- DWITH_INSTALL_PORTABLE=OFF
- DWITH_SYSTEM_GLEW=OFF
- DWITH_PYTHON_INSTALL=OFF
- DWITH_CYCLES_DEVICE_HIP=ON
- DWITH_CYCLES_HIP_BINARIES=ON
- DCYCLES_HIP_BINARIES_ARCH=gfx900
- DXR_OPENXR_SDK_ROOT_DIR=/usr
- DPYTHON_VERSION="${_pyver}" \

      "${_CMAKE_FLAGS[@]}"
ninja -C "$srcdir/build" ${MAKEFLAGS:--j1}

Please add Vega 64 arch gfx900 support, as it supports HIP, or let me know how to do it manually.

I have installed full rocm on Arch Linux and enabled HIP in CMakeLists.txt by overriding the options in the blender-git PKGBUILD, I do have HIP option under system preferences and my GPU and CPU shows up there. However if I try to render with Cycles and GPU Compute, render fails with the following error: Invalid value in hipDeviceGetAttribute(&pitch_alignment, hipDeviceAttributeTexturePitchAlignment, hipDevice)) (intern/cycles/device/hip/device_impl.cpp:116) I have a Vega 64 and I've checked with rocminfo that it's arch is gfx900, which is missing in CMakeLists.txt: set(CYCLES_HIP_BINARIES_ARCH gfx1010 gfx1011 gfx1012 gfx1030 gfx1031 gfx1032 gfx1034 CACHE STRING "AMD HIP architectures to build binaries for") I have tried overriding this option in PKGBUILD file and recompiling, but apparently it didn't work. cmake -G Ninja -S "$srcdir/blender" -B build \ - C "${srcdir}/blender/build_files/cmake/config/blender_release.cmake" \ - DCMAKE_INSTALL_PREFIX=/usr \ - DCMAKE_BUILD_TYPE=Release \ - DWITH_INSTALL_PORTABLE=OFF \ - DWITH_SYSTEM_GLEW=OFF \ - DWITH_PYTHON_INSTALL=OFF \ - DWITH_CYCLES_DEVICE_HIP=ON \ - DWITH_CYCLES_HIP_BINARIES=ON \ - DCYCLES_HIP_BINARIES_ARCH=gfx900 \ - DXR_OPENXR_SDK_ROOT_DIR=/usr \ - DPYTHON_VERSION="${_pyver}" \ ``` "${_CMAKE_FLAGS[@]}" ninja -C "$srcdir/build" ${MAKEFLAGS:--j1} ``` Please add Vega 64 arch gfx900 support, as it supports HIP, or let me know how to do it manually.

Alaska commented

2021-10-24 10:40:43 +02:00

In #91571#1240208, @FogLizard wrote:
Please add Vega 64 arch gfx900 support, as it supports HIP, or let me know how to do it manually.

Official instructions on how to setup HIP in Cycles will be avalibale in the future. Once the instructions are released, it should be better.

As a side note, I'm not familiar with with the build method you're using, but I would suggest using the official build instructions listed on the Blender website: https://wiki.blender.org/wiki/Building_Blender
And once you've got Blender compiled and working, navigate to ~/blender-git/build-linux/ and modify the file CMakeCache.txt with an application like cmake-gui to enable HIP and add your desired architectures then rebuild Blender again. I would personally recommend adding more architectures than just your GPU just in case you've got the wrong number. Here is a list of GPU architectures that Brecht said compiles, but he hasn't tested all of them yet:

gfx801;gfx803;gfx810;gfx900;gfx902;gfx904;gfx906;gfx908;gfx909;gfx1010;gfx1011;gfx1012;gfx1030;gfx1031;gfx1032

You might also need to change some code in intern/cycles/device/hip/util.h for everything to work properly. You can see an example in this commit on what sort of changes should be done: 2f89ddc043

It might actually be easier to test with the cycles-hip-binaries branch of Blender. This can be done by using git checkout cycles-hip-binaries in the Blender source code directory to checkout that branch then to compile a clean build of Blender from that.

On a side note. There is a version of Blender avaliable for download with the HIP binaries pre-compiled. It should recognize a wide range of GPUs, but I have no idea if it's functional, you will probably experience some bugs, and this version of Blender will quickly become outdated so we do NOT accept bug reports for it: https://builder-uatest.blender.org/download/experimental/cycles-hip-binaries/

It should also be noted that at the current point in time Vega 64 isn't "officially" supported. It may work, but with the currently avaliable official Blender code Vega 64 isn't on the list of supported GPUs. It's also possible you may experience bugs due to the HIP implementation still being under development.

> In #91571#1240208, @FogLizard wrote: > Please add Vega 64 arch gfx900 support, as it supports HIP, or let me know how to do it manually. Official instructions on how to setup HIP in Cycles will be avalibale in the future. Once the instructions are released, it should be better. As a side note, I'm not familiar with with the build method you're using, but I would suggest using the official build instructions listed on the Blender website: https://wiki.blender.org/wiki/Building_Blender And once you've got Blender compiled and working, navigate to `~/blender-git/build-linux/` and modify the file `CMakeCache.txt` with an application like `cmake-gui` to enable HIP and add your desired architectures then rebuild Blender again. I would personally recommend adding more architectures than just your GPU just in case you've got the wrong number. Here is a list of GPU architectures that Brecht said compiles, but he hasn't tested all of them yet: > gfx801;gfx803;gfx810;gfx900;gfx902;gfx904;gfx906;gfx908;gfx909;gfx1010;gfx1011;gfx1012;gfx1030;gfx1031;gfx1032 You might also need to change some code in `intern/cycles/device/hip/util.h` for everything to work properly. You can see an example in this commit on what sort of changes should be done: 2f89ddc043 It might actually be easier to test with the `cycles-hip-binaries` branch of Blender. This can be done by using `git checkout cycles-hip-binaries` in the Blender source code directory to checkout that branch then to compile a clean build of Blender from that. --- On a side note. There is a version of Blender avaliable for download with the HIP binaries pre-compiled. It should recognize a wide range of GPUs, but I have no idea if it's functional, you will probably experience some bugs, and this version of Blender will quickly become outdated so we do NOT accept bug reports for it: https://builder-uatest.blender.org/download/experimental/cycles-hip-binaries/ --- It should also be noted that at the current point in time Vega 64 isn't "officially" supported. It may work, but with the currently avaliable official Blender code Vega 64 isn't on the list of supported GPUs. It's also possible you may experience bugs due to the HIP implementation still being under development.

Brecht Van Lommel commented

2021-10-24 13:34:51 +02:00

We're not ready to have this tested by users, we don't know yet which architectures will work and may need to work through some bugs. When it's ready there will be build instructions.

@FogLizard In general for help building Blender, please use devtalk.blender.org. This task should stay on the topic of development, not support.

@Alaska, please don't recommend users to try that build, it's really not at a stage we want to deal with feedback from that.

We're not ready to have this tested by users, we don't know yet which architectures will work and may need to work through some bugs. When it's ready there will be build instructions. @FogLizard In general for help building Blender, please use devtalk.blender.org. This task should stay on the topic of development, not support. @Alaska, please don't recommend users to try that build, it's really not at a stage we want to deal with feedback from that.

Mike Pan commented

2021-10-25 23:35:38 +02:00

Added subscriber: @MikePan

Makram commented

2021-11-02 18:52:45 +01:00

Added subscriber: @Pliou

Grzegorz Wereszko commented

2021-11-11 23:17:59 +01:00

Added subscriber: @Prodeous

Ahmad Bilal commented

2021-11-16 19:21:03 +01:00

Added subscriber: @SomeAB

Ahmad Bilal commented

2021-11-16 19:21:03 +01:00

Good to see the progress on HIP. Haven't been using 3.0 Alpha/Beta because of lack of this. Can we expect support for Vega64, 56 generation of cards before official 3.0 release?
What kind of performance numbers can be expected compared to before? OpenCL as far as I remember, was way behind even CUDA.. which is superseded by Optix on roughly equivalent hardware. As I have worked with HIP in machine learning before, I'm not very optimistic sadly.

1. Good to see the progress on HIP. Haven't been using 3.0 Alpha/Beta because of lack of this. Can we expect support for Vega64, 56 generation of cards before official 3.0 release? 2. What kind of performance numbers can be expected compared to before? OpenCL as far as I remember, was way behind even CUDA.. which is superseded by Optix on roughly equivalent hardware. As I have worked with HIP in machine learning before, I'm not very optimistic sadly.

Brecht Van Lommel commented

2021-11-16 20:42:44 +01:00

For questions and feedback, there is this topic now:
https://devtalk.blender.org/t/cycles-amd-hip-device-feedback/21400/16

I'll answer the question there, as this task is for coordinating development.

For questions and feedback, there is this topic now: https://devtalk.blender.org/t/cycles-amd-hip-device-feedback/21400/16 I'll answer the question there, as this task is for coordinating development.

Firecrow Silvernight commented

2021-11-16 22:23:53 +01:00

Removed subscriber: @fire

brunnerh commented

2021-11-17 18:13:59 +01:00

Added subscriber: @brunnerh

brunnerh commented

2021-11-17 18:13:59 +01:00

Image texture size is limited, could detect this and resize or show user better error

If it is to resize automatically, there probably should be a warning mentioning the affected texture so it does not silently degrade the expected quality. Maybe there could be an option for it as well. E.g. In the context of a render farm it might be better to cancel with an error than render something of lesser quality the user did not want.

> Image texture size is limited, could detect this and resize or show user better error If it is to resize automatically, there probably should be a warning mentioning the affected texture so it does not silently degrade the expected quality. Maybe there could be an option for it as well. E.g. In the context of a render farm it might be better to cancel with an error than render something of lesser quality the user did not want.

Effi commented

2021-11-17 20:18:40 +01:00

Added subscriber: @ephraimpauli

Daniel commented

2021-11-29 20:33:57 +01:00

Added subscriber: @Zeenus

John Ross commented

2021-12-01 11:39:49 +01:00

Added subscriber: @AlfredENeuman

Giovanni Leon commented

2021-12-01 17:26:49 +01:00

Added subscriber: @dmlr7

Marius Eckardt commented

2021-12-03 14:43:32 +01:00

Added subscriber: @Alirion-2

Marius Eckardt commented

2021-12-03 14:43:32 +01:00

Cant wait when this runs on Polaris. Hopefully stable rendering again. Still stuck on 2.8 for Stability.

Ian Flynn commented

2021-12-06 16:40:34 +01:00

Added subscriber: @itf

Allaa Eddine Riad Amiar commented

2021-12-07 22:32:15 +01:00

Added subscriber: @Th3ho0d

Allaa Eddine Riad Amiar commented

2021-12-07 22:32:15 +01:00

can you share the list of the devices you working on enabling HIP for right now ? or a timeline for future devices to work on ?

Brian Savery (AMD) commented

2021-12-07 22:57:42 +01:00

In #91571#1267758, @Th3ho0d wrote:
can you share the list of the devices you working on enabling HIP for right now ? or a timeline for future devices to work on ?

RDNA and RDNA2 GPUs in linux for Blender 3.1
Other than that the only info we can give is that we plan to work backwards enabling older GPUs.

> In #91571#1267758, @Th3ho0d wrote: > can you share the list of the devices you working on enabling HIP for right now ? or a timeline for future devices to work on ? RDNA and RDNA2 GPUs in linux for Blender 3.1 Other than that the only info we can give is that we plan to work backwards enabling older GPUs.

JinzeLi commented

2021-12-12 03:27:16 +01:00

Added subscriber: @LouisLithium

Ghost commented

2021-12-15 02:19:31 +01:00

Added subscriber: @hahnzhu

Caden Mitchell commented

2021-12-15 06:35:27 +01:00

Added subscriber: @Caden-Mitchell

George Sofianos commented

2021-12-17 09:19:54 +01:00

Added subscriber: @Luciddream

Iain Hogg commented

2021-12-29 18:23:49 +01:00

Added subscriber: @iain.hogg

Iain Hogg commented

2021-12-29 18:23:49 +01:00

In #91571#1267770, @BrianSavery wrote:

In #91571#1267758, @Th3ho0d wrote:
can you share the list of the devices you working on enabling HIP for right now ? or a timeline for future devices to work on ?

RDNA and RDNA2 GPUs in linux for Blender 3.1
Other than that the only info we can give is that we plan to work backwards enabling older GPUs.

Are you able to confirm how far backwords you are planning to work - Im running an AMD fireproW8100 - would it be likley that this would be included goinf fwd?

> In #91571#1267770, @BrianSavery wrote: >> In #91571#1267758, @Th3ho0d wrote: >> can you share the list of the devices you working on enabling HIP for right now ? or a timeline for future devices to work on ? > > RDNA and RDNA2 GPUs in linux for Blender 3.1 > Other than that the only info we can give is that we plan to work backwards enabling older GPUs. Are you able to confirm how far backwords you are planning to work - Im running an AMD fireproW8100 - would it be likley that this would be included goinf fwd?

Alaska commented

2021-12-29 21:28:15 +01:00

In #91571#1279918, @iain.hogg wrote:

In #91571#1267770, @BrianSavery wrote:

RDNA and RDNA2 GPUs in linux for Blender 3.1
Other than that the only info we can give is that we plan to work backwards enabling older GPUs.

Are you able to confirm how far backwords you are planning to work - Im running an AMD fireproW8100 - would it be likley that this would be included goinf fwd?

Note: From my interprestaion of things, ROCm is required to run HIP on Linux.
This is just my interpretation of things and I may be getting it wrong. According to some documentation for ROCm on Linux, ROCm officially supports graphics cards going back to Vega (56 and 64). ROCm is enabled, but is not officially support on graphics cards going back to the "Hawaii" chips such as AMD Radeon R9 390X and FirePro W9100.

Assuming this trend carries over to the HIP implementation in Blender, then it is unlikely your GPU (AMD fireproW8100) will be supported. But this is all just specualtion ffrom me and I may be wrong.

> In #91571#1279918, @iain.hogg wrote: >> In #91571#1267770, @BrianSavery wrote: >> >> RDNA and RDNA2 GPUs in linux for Blender 3.1 >> Other than that the only info we can give is that we plan to work backwards enabling older GPUs. > > Are you able to confirm how far backwords you are planning to work - Im running an AMD fireproW8100 - would it be likley that this would be included goinf fwd? Note: From my interprestaion of things, ROCm is required to run HIP on Linux. This is just my interpretation of things and I may be getting it wrong. According to some documentation for ROCm on Linux, ROCm officially supports graphics cards going back to Vega (56 and 64). ROCm is enabled, but is not officially support on graphics cards going back to the "Hawaii" chips such as AMD Radeon R9 390X and FirePro W9100. Assuming this trend carries over to the HIP implementation in Blender, then it is unlikely your GPU (AMD fireproW8100) will be supported. But this is all just specualtion ffrom me and I may be wrong.

Caden Mitchell commented

2021-12-30 20:09:33 +01:00

Cannot GPU compute in Blender 3 alpha in Linux. I have ROCm and HIP installed. I can compute render in 2.93 but my device doesn’t even show up in Blender 3. Radeon RX5700 XT.

Alaska commented

2021-12-30 21:42:46 +01:00

In #91571#1280590, @Caden-Mitchell wrote:
Cannot GPU compute in Blender 3 alpha in Linux. I have ROCm and HIP installed. I can compute render in 2.93 but my device doesn’t even show up in Blender 3. Radeon RX5700 XT.

HIP support in Linux is still being worked up. New drivers and/or a new HIP compiler is needed for it to work properly.

> In #91571#1280590, @Caden-Mitchell wrote: > Cannot GPU compute in Blender 3 alpha in Linux. I have ROCm and HIP installed. I can compute render in 2.93 but my device doesn’t even show up in Blender 3. Radeon RX5700 XT. HIP support in Linux is still being worked up. New drivers and/or a new HIP compiler is needed for it to work properly.

Hannah Ümit commented

2021-12-31 02:13:27 +01:00

Added subscriber: @Hannah-Umit

Nico commented

2022-01-03 22:57:01 +01:00

Added subscriber: @not_a_boring_name

Maxime Chambonnet commented

2022-01-08 14:09:38 +01:00

Added subscriber: @Maxzor

Jonas Hagberth commented

2022-01-17 16:58:23 +01:00

Added subscriber: @Jonas-Hagberth

Jonas Hagberth commented

2022-01-17 17:04:37 +01:00

This comment was removed by @Jonas-Hagberth

*This comment was removed by @Jonas-Hagberth*

Martijn Versteegh commented

2022-01-18 23:52:16 +01:00

Added subscriber: @Baardaap

dvi commented

2022-01-20 14:34:53 +01:00

Added subscriber: @dvi

dvi commented

2022-01-20 14:34:53 +01:00

when is Hardware ray-tracing coming?

Brian Savery (AMD) commented

2022-01-20 16:21:59 +01:00

Regarding Linux support:

Our driver release timeline unfortunately doesn't quite line up with the dates for Blender 3.1, and there are some fixes in there that are needed. It should be out sometime after bcon3 and before bcon4, but I'm proposing Linux support gets pushed to Blender 3.2 so there is time for testing. Linux users should be able to use it under 3.2 in march though.

Regarding Linux support: Our driver release timeline unfortunately doesn't quite line up with the dates for Blender 3.1, and there are some fixes in there that are needed. It should be out sometime after bcon3 and before bcon4, but I'm proposing Linux support gets pushed to Blender 3.2 so there is time for testing. Linux users should be able to use it under 3.2 in march though.

Brecht Van Lommel commented

2022-01-20 17:10:22 +01:00

Ok, we can push it to 3.2 then. There will be a 3.2 daily build starting next week, so as soon as there is something working it can be available to users for testing.

Sayak Biswas commented

2022-01-20 19:02:09 +01:00

Is there a branch for 3.2 or is code going to master for now? I have some changes to hipew, I'd like to push

Brecht Van Lommel commented

2022-01-20 19:14:38 +01:00

There will be a branch next week. But code can go into master still.

John Ross commented

2022-01-21 00:14:55 +01:00

Removed subscriber: @AlfredENeuman

Garek commented

2022-01-21 06:28:23 +01:00

Added subscriber: @Garek

Maxime Chambonnet commented

2022-01-21 12:40:17 +01:00

Added subscriber: @Maxzor-1

Maxime Chambonnet commented

2022-01-21 12:41:40 +01:00

Added subscriber: @ThomasDinges

Maxime Chambonnet commented

2022-01-21 12:41:40 +01:00

@ThomasDinges Hello, what about dedicating some time in your next weekly interaction meeting to talk about it? My interest is to get technical on HIP support, I have been helping packaging ROCm for Debian/Ubuntu and this is practically finished.

Eyad Ahmed commented

2022-01-21 14:28:18 +01:00

Removed subscriber: @IyadAhmed

Caden Mitchell commented

2022-01-25 21:28:25 +01:00

Could we get a legacy OpenCL pipeline option back for Linux only (or even HIP unsupported AMD cards)? I don't know if the new Cycles code is compatible with OpenCL, but I am not satisfied with the state of Blender 3.x on my AMD system currently.

Hannah Ümit commented

2022-01-25 22:52:30 +01:00

Added subscriber: @CadenMitchell-3

Hannah Ümit commented

2022-01-25 22:52:30 +01:00

I am not satisfied with the state of Blender 3.x on my AMD system currently.

@CadenMitchell-3 I 100% Agree with this part. OpenCL is a different story as it's very much broken but I doubt that the amount of Linux users using HIP compatible devices is as big as the current GCN userbase.

> I am not satisfied with the state of Blender 3.x on my AMD system currently. @CadenMitchell-3 I 100% Agree with this part. OpenCL is a different story as it's very much broken but I doubt that the amount of Linux users using HIP compatible devices is as big as the current GCN userbase.

周建峰 commented

2022-01-26 04:31:35 +01:00

This comment was removed by @2905710881

*This comment was removed by @2905710881*

周建峰 commented

2022-01-26 04:32:25 +01:00

In #91571#1294857, @Hannah-Umit wrote:

I am not satisfied with the state of Blender 3.x on my AMD system currently.

@CadenMitchell-3 I 100% Agree with this part. OpenCL is a different story as it's very much broken but I doubt that the amount of Linux users using HIP compatible devices is as big as the current GCN userbase.

The underlying layer of hip is rocm, the old gcn graphics card has long supported rocm, rdna graphics card support time almost and cyclesx hip is synchronized support, so gcn support hip is only a matter of time.

> In #91571#1294857, @Hannah-Umit wrote: >> I am not satisfied with the state of Blender 3.x on my AMD system currently. > > > @CadenMitchell-3 I 100% Agree with this part. OpenCL is a different story as it's very much broken but I doubt that the amount of Linux users using HIP compatible devices is as big as the current GCN userbase. The underlying layer of hip is rocm, the old gcn graphics card has long supported rocm, rdna graphics card support time almost and cyclesx hip is synchronized support, so gcn support hip is only a matter of time.

Thomas Dinges commented

2022-01-26 09:45:09 +01:00

Please keep this task on topic! This task is for developers and should focus on code discussion. Please refrain from further user questions, including asking for a build, asking for a merge ETA, examples, comparison with other software and so on... Thank you for your understanding.

Every further off-topic comment will be removed.

Please keep this task on topic! This task is for developers and should focus on code discussion. Please refrain from further user questions, including asking for a build, asking for a merge ETA, examples, comparison with other software and so on... Thank you for your understanding. Every further off-topic comment will be removed.

Denver P. commented

2022-02-04 06:51:04 +01:00

Added subscriber: @Obsyden

Denver P. commented

2022-02-04 06:51:04 +01:00

The crash on Linux is caused by the hipDeviceGetAttribute function, which will always segfault for some mysterious reason. Fortunately, this can be replaced with hipGetDeviceProperties for the exact same information that the former fetches.

Maxime Chambonnet commented

2022-02-04 07:56:28 +01:00

Having the above function not crashing is rather trivial, what matters is the graphics/compute interop being implemented - and between which APIs - underneath or not?

Brecht Van Lommel commented

2022-02-04 11:09:06 +01:00

If just using hipGetDeviceProperties works that would be great, but from what I understand there are further issues.

Graphics interop is not that important, it improves viewport performance but everything still works without it.

If just using hipGetDeviceProperties works that would be great, but from what I understand there are further issues. Graphics interop is not that important, it improves viewport performance but everything still works without it.

Takuro Shoji commented

2022-02-07 09:43:09 +01:00

Added subscriber: @Takuro-Shoji

Christian Höppner commented

2022-02-08 00:15:00 +01:00

Added subscriber: @mkaito

BlenderUser commented

2022-02-11 22:03:55 +01:00

Added subscriber: @BlenderUser700

BlenderUser commented

2022-02-11 22:03:55 +01:00

This comment was removed by @BlenderUser700

*This comment was removed by @BlenderUser700*

Denver P. commented

2022-02-26 02:20:30 +01:00

I just made a diff to fix the Linux crash due to hipDeviceGetAttribute, but there are still other crashes due to causes unknown to me. Keep in mind it's my first patch on this repo: https://developer.blender.org/D14198

Denver P. commented

2022-02-27 00:47:05 +01:00

After some testing I've found that cycles HIP instantly crashes when using image textures of any kind. The error thrown is

Memory access fault by GPU node-1 (Agent handle: 0x7fffb0ae5000) on address (nil). Reason: Page not present or supervisor privilege.

I'm running Ubuntu 20.04 LTS with a Radeon RX 6600 XT.
The only steps to reproduce this are going into any material e.g. environment or materials tab and selecting some form of image texture like environment texture or image texture. This instantly crashes Blender with the above error

After some testing I've found that cycles HIP instantly crashes when using image textures of any kind. The error thrown is ``` Memory access fault by GPU node-1 (Agent handle: 0x7fffb0ae5000) on address (nil). Reason: Page not present or supervisor privilege. ``` I'm running Ubuntu 20.04 LTS with a Radeon RX 6600 XT. The only steps to reproduce this are going into any material e.g. environment or materials tab and selecting some form of image texture like environment texture or image texture. This instantly crashes Blender with the above error

Yuro commented

2022-03-08 00:59:50 +01:00

Added subscriber: @Yuro

George Angelopoulos commented

2022-03-15 16:16:13 +01:00

Added subscriber: @george-4

Noah Prezant commented

2022-04-15 23:52:42 +02:00

Added subscriber: @Noah-Prezant

blender-admin commented

2022-04-22 00:02:05 +02:00

This issue was referenced by 179100c021

This issue was referenced by 179100c021269c278396c9a8039a0b75703c5f3a

Wiktor Madaliński commented

2022-05-07 23:05:04 +02:00

Added subscriber: @Kosmita

David Gianforte commented

2022-05-09 16:59:31 +02:00

Added subscriber: @DavidG-1

Andrius Lukosevicius commented

2022-05-13 05:48:47 +02:00

Added subscriber: @niobium93

Andrius Lukosevicius commented

2022-05-13 05:48:47 +02:00

I'm running Arch Linux with ROCm 5.1.1 installed with a Radeon RX 5700 XT and am getting the same crash whenever any image texture exists in the scene. Complex scenes render fine only as long as all image textures are removed.
blender.crash.txt

I'm running Arch Linux with ROCm 5.1.1 installed with a Radeon RX 5700 XT and am getting the same crash whenever any image texture exists in the scene. Complex scenes render fine only as long as all image textures are removed. [blender.crash.txt](https://archive.blender.org/developer/F13071836/blender.crash.txt)

Darkhan K commented

2022-05-17 04:08:09 +02:00

Added subscriber: @Darkhan-K

Andrius Lukosevicius commented

2022-05-23 20:41:00 +02:00

I upgraded to ROCm 5.1.3 and blender 3.3.r115176.gffa262c9f8c and now the HIP kernel fails to compile. blender hip compile fail.log

I upgraded to ROCm 5.1.3 and blender 3.3.r115176.gffa262c9f8c and now the HIP kernel fails to compile. [blender hip compile fail.log](https://archive.blender.org/developer/F13101224/blender_hip_compile_fail.log)

Alaska commented

2022-05-24 00:45:46 +02:00

@niobium93 , please make a separate bug report for your issues rather than commenting them on this task.

Mylo Pinto Rizvi commented

2022-05-24 14:44:41 +02:00

Removed subscriber: @Low_Polygon42

Hannah Ümit commented

2022-05-25 17:13:34 +02:00

Removed subscriber: @Hannah-Umit

Ward Nakchbandi commented

2022-05-29 15:54:43 +02:00

Added subscriber: @CosmoHQ

Pavel Patzelt commented

2022-06-12 23:29:51 +02:00

Added subscriber: @Pavel_Patzelt

Alexey commented

2022-06-13 14:14:52 +02:00

Removed subscriber: @FreeCX

Neil McNair commented

2022-06-23 17:29:46 +02:00

Added subscriber: @Neil-McNair

blender-admin commented

2022-06-28 16:55:27 +02:00

This issue was referenced by abfa09752f

This issue was referenced by abfa09752f5c4d1fa2ae9df5e4ee0c9d77b50f3e

Martijn Versteegh commented

2022-06-28 19:58:28 +02:00

Removed subscriber: @Baardaap

Nitin Sharma commented

2022-09-08 11:05:55 +02:00

Added subscriber: @finalflasher

Porama Ruengrairatanaroj commented

2022-11-22 19:26:46 +01:00

Added subscriber: @PoramaRuengrairatanaroj

Jonathan commented

2022-12-11 12:19:57 +01:00

Added subscriber: @Jonathan-61

Jonathan commented

2022-12-11 12:19:57 +01:00

Who actually tested and checked the box for "RDNA2" under "Linux support and stability"?
At least the viewport does not work properly on HIP+Cycles as reported here:
https://developer.blender.org/T100353
and here:
https://gitlab.freedesktop.org/drm/amd/-/issues/2145

Who actually tested and checked the box for "RDNA2" under "Linux support and stability"? At least the viewport does not work properly on HIP+Cycles as reported here: https://developer.blender.org/T100353 and here: https://gitlab.freedesktop.org/drm/amd/-/issues/2145

Brecht Van Lommel commented

2022-12-11 18:54:26 +01:00

This task is not used to track bugs, it's only for the initial development of features where RDNA2 was confirmed to work. Bugs discovered afterwards or with specific distribution/driver combinations like the one you mentioned are handled in their own task..

L---S commented

2022-12-12 00:52:34 +01:00

Added subscriber: @L-S

L---S commented

2022-12-12 00:52:34 +01:00

In #91571#1458697, @brecht wrote:
This task is not used to track bugs, it's only for the initial development of features where RDNA2 was confirmed to work. Bugs discovered afterwards or with specific distribution/driver combinations like the one you mentioned are handled in their own task..

Apologies for responding in the incorrect task. This may be wishful thinking but it appears you to have gone out of your way to mention "specific distribution/driver combinations" in your response. By any chance are you are aware of a combination Blender and HIP that does not produce the fault in #100353. If so please let us know so we can report it to the drm/amd issue, it could be pivotal in finding a resolution. Thanks!

> In #91571#1458697, @brecht wrote: > This task is not used to track bugs, it's only for the initial development of features where RDNA2 was confirmed to work. Bugs discovered afterwards or with specific distribution/driver combinations like the one you mentioned are handled in their own task.. Apologies for responding in the incorrect task. This may be wishful thinking but it appears you to have gone out of your way to mention "specific distribution/driver combinations" in your response. By any chance are you are aware of a combination Blender and HIP that does not produce the fault in #100353. If so please let us know so we can report it to the drm/amd issue, it could be pivotal in finding a resolution. Thanks!

Yu Ding commented

2022-12-19 08:01:20 +01:00

Added subscriber: @HowardBlandy

Marcus H commented

2023-01-08 07:02:49 +01:00

Added subscriber: @Cosmocrat

Brecht Van Lommel added this to the Render & Cycles project 2023-02-07 19:08:06 +01:00

Philipp Oeser removed the

Interest

Render & Cycles

label 2023-02-09 14:02:59 +01:00

Pratik Borhade referenced this issue

2023-04-05 16:08:09 +02:00

HIP doesn't render displacement node properly #106463

Pratik Borhade referenced this issue

2023-08-14 08:01:00 +02:00

Invalid value in hipTexObjectCreate #110808

Pratik Borhade referenced this issue

2023-08-17 10:27:11 +02:00

Cycles HIP device crash on rendering on latest AMD Adrenaline Driver #110392

Pratik Borhade referenced this issue

2023-08-18 06:40:19 +02:00

Cycles HIP Crash: Invalid Value in hipTexObjectCreate #111237

Germano Cavalcante referenced this issue

2023-09-13 01:50:10 +02:00

Blender HIP AMD GPU bug #112296

Pratik Borhade referenced this issue

2023-09-14 05:47:29 +02:00

HIP doesn't work #112356

Pratik Borhade referenced this issue

2024-01-01 10:44:21 +01:00

Cycles renderer only loads 1 texture when set to GPU compute #113521

Pratik Borhade referenced this issue

2024-02-02 04:23:17 +01:00

[AMD HIP; Linux] Invalid value in hipTexObjectCreate when using an image that is ≥ 16384 px in 1 or more dimensions #117743

Alaska referenced this issue

2024-02-14 09:17:48 +01:00

Cycles: Improve error reporting of large textures on HIP #118239

Alaska referenced this issue

2024-02-20 14:15:34 +01:00

Edges of textures repeat on clip when using HIP cycles #118504

Vafu referenced this issue

2024-02-20 14:33:15 +01:00

Edges of textures repeat on clip when using HIP cycles #118504

Alaska commented

2024-02-20 16:24:29 +01:00

Clip mode in Image Texture node not supported (#92975)

Using HIP SDK 5.5 to compile HIP kernels, and early 2024 GPU drivers on a RX 7800XT on Windows, it seems this issue has been fixed (assuming you modify the relevant code to use the clip mode).

I don't know when this was fixed, whether or not it was a ROCm and/or driver fix, or how to write the relevant code to detect different ROCm/driver versions in device_impl to switch between the working case, and the "fallback" case. So can someone else with the relevant knowledge handle this code change? CC @brecht or @salipour

> - [ ] Clip mode in Image Texture node not supported (#92975) Using HIP SDK 5.5 to compile HIP kernels, and early 2024 GPU drivers on a RX 7800XT on Windows, it seems this issue has been fixed (assuming you [modify the relevant code](https://projects.blender.org/blender/blender/pulls/118540/files) to use the clip mode). I don't know when this was fixed, whether or not it was a ROCm and/or driver fix, or how to write the relevant code to detect different ROCm/driver versions in `device_impl` to switch between the working case, and the "fallback" case. So can someone else with the relevant knowledge handle this code change? CC @brecht or @salipour

👍 3

Alaska referenced this issue

2024-02-20 16:26:37 +01:00

Edges of textures repeat on clip when using HIP cycles #118504

Brecht Van Lommel commented

2024-02-20 18:10:43 +01:00

Thanks for testing that. I'm not sure how to find out in which driver release this get fixed, @salipour, do you know? Besides installing old drivers until it breaks.

Sahar A. Kashi commented

2024-02-20 20:26:37 +01:00

I don't know the exact driver version but the issue has been fixed for a long time now
https://github.com/ROCm/HIP/pull/2229

I don't know the exact driver version but the issue has been fixed for a long time now https://github.com/ROCm/HIP/pull/2229

Brecht Van Lommel commented

2024-02-20 21:20:32 +01:00

Ok, let's just enable it everywhere then without a check.

@Alaska feel free to make a PR, if not I can do it.

Ok, let's just enable it everywhere then without a check. @Alaska feel free to make a PR, if not I can do it.

Alaska referenced this issue

2024-02-21 01:15:49 +01:00

Cycles HIP: Fix incorrect rendering of clip image textures #118540

Alaska commented

2024-02-21 13:39:21 +01:00

Graphics interop is broken in 21.Q4 driver, enable for next driver (D13167)

On a RX 7800XT with early 2024 drivers on Windows with the relevant code changes (Pull request: #118562), OpenGL interop appears to be working. I see none of the issues reported in #92972

Similar to the HIP Clip issue. I'm not sure when this was fixed, but it seems like it was probably over a year ago considering that AMD has OpenGL interop examples with Windows support dating back to December 2022. And I would presume AMD verify this example worked before publishing it.

Edit: Testing points to Linux being extremely unstable with graphics interop.

> - [ ] Graphics interop is broken in 21.Q4 driver, enable for next driver (D13167) On a RX 7800XT with early 2024 drivers on Windows with the relevant code changes (Pull request: #118562), OpenGL interop appears to be working. I see none of the issues reported in #92972 Similar to the HIP Clip issue. I'm not sure when this was fixed, but it seems like it was probably over a year ago considering that AMD has [OpenGL interop examples](https://github.com/amd/rocm-examples/tree/develop/HIP-Basic/opengl_interop) with Windows support dating back to December 2022. And I would presume AMD verify this example worked before publishing it. Edit: Testing points to Linux being extremely unstable with graphics interop.

Alaska referenced this issue

2024-02-21 13:41:56 +01:00

WIP: Cycles HIP: Enable OpenGL interop #118562

Brecht Van Lommel referenced this issue from a commit

2024-02-29 13:49:41 +01:00

Fix: Cycles HIP incorrect rendering of clip image textures

Philipp Oeser referenced this issue from a commit

2024-03-12 10:44:39 +01:00

Fix: Cycles HIP incorrect rendering of clip image textures

Philipp Oeser referenced this issue from a commit

2024-03-12 16:24:03 +01:00

Fix: Cycles HIP incorrect rendering of clip image textures