Name of custom socket types is not set when making a node group via script. #91658

New Issue

Jeroen Bakker · 2021-09-23T21:31:55+02:00

Jeroen Bakker commented

2021-09-23 21:31:55 +02:00

System Information
Operating system: Linux-5.11.0-36-generic-x86_64-with-glibc2.33 64 Bits
Graphics card: Mesa Intel(R) UHD Graphics 620 (KBL GT2) Intel 4.6 (Core Profile) Mesa 21.0.3

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-09-23 17:39, hash: b8a30c7664
Worked: (newest version of Blender that worked as expected)

Short description of error
When making a node group via a script, the custom socket type name is not set.

Exact steps for others to reproduce the error

load script P2427: Example of socket interface

import bpy
import nodeitems_utils

class CSTree(bpy.types.NodeTree):
    bl_idname = 'CSTree'
    bl_label = "CS Node Editor"
    bl_icon = 'NODETREE'
    

class CSSocket(bpy.types.NodeSocket):
    bl_idname = 'CSSocket'
    bl_label = "CS Socket"

    def draw(self, context, layout, node, text):
        layout.label(text=text)

    def draw_color(self, context, node):
        return (1.0, 0.8, 0.4, 1.0)


class CSSocketInterface(bpy.types.NodeSocketInterface):
    bl_idname = "CSSocketInterface"
    bl_socket_idname = "CSSocket"
    bl_label = "CS Socket"

    def draw_color(self, context):
        return (1.0, 0.8, 0.4, 1.0)

    def draw(self, context, layout):
        pass


class CSNode(bpy.types.Node):
    bl_idname = 'CSNode'
    bl_label = "Node"

    def init(self, context):
        self.inputs.new('CSSocket', name='Input1')


class CSNodeGroup(bpy.types.NodeCustomGroup):
    bl_idname = 'CSNodeGroup'
    bl_label = 'Node Group'
    bl_icon = 'OUTLINER_OB_EMPTY'

    def init(self, context):
        self.node_tree = bpy.data.node_groups.new('CSNodeGroup', 'CSTree')
        nodes = self.node_tree.nodes
        inputnode = nodes.new('NodeGroupInput')


def make_group(context):
    space_data = context.space_data
    node_tree = space_data.node_tree
    selected_nodes = context.selected_nodes
    node_group = node_tree.nodes.new("CSNodeGroup")
    node_group_tree = node_group.node_tree
    input_group = node_group_tree.nodes['Group Input']
    
    new_node = node_group_tree.nodes.new("CSNode")

    to_socket = new_node.inputs[0]
    from_socket = input_group.outputs.new(to_socket.bl_idname, to_socket.name)
    node_group_tree.links.new(input=from_socket, output=to_socket)
    

class CSMakeNodeGroupOperator(bpy.types.Operator):
    bl_idname = "crowd.cs_make_group"
    bl_label = "CS Make Group"
    
    @classmethod
    def poll(cls, context):
        space_data = context.space_data

        if not (space_data.type == 'NODE_EDITOR'
            and space_data.tree_type == 'CSTree'
            and space_data.node_tree is not None):
            return False

        return True
    
    def execute(self, context):
        node_group = make_group(context)
        return {'FINISHED'}


def register():
    bpy.utils.register_class(CSTree)
    bpy.utils.register_class(CSSocket)
    bpy.utils.register_class(CSNode)
    bpy.utils.register_class(CSNodeGroup)
    bpy.utils.register_class(CSMakeNodeGroupOperator)

def unregister():
    bpy.utils.unregister_class(CSTree)
    bpy.utils.unregister_class(CSSocket)
    bpy.utils.unregister_class(CSNode)
    bpy.utils.unregister_class(CSNodeGroup)
    bpy.utils.unregister_class(CSMakeNodeGroupOperator)

if __name__ =="__main__":
    register()

execute script
open CS Node Editor
create new node tree
Search for "CS Make Group" operator
switch to "CSNodeGroup" tree
Open side panel (N)
Check that the Group/Inputs has one item, but the name in the list is blank.

{F10562486 width=100%}

**System Information** Operating system: Linux-5.11.0-36-generic-x86_64-with-glibc2.33 64 Bits Graphics card: Mesa Intel(R) UHD Graphics 620 (KBL GT2) Intel 4.6 (Core Profile) Mesa 21.0.3 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-09-23 17:39, hash: `b8a30c7664` Worked: (newest version of Blender that worked as expected) **Short description of error** When making a node group via a script, the custom socket type name is not set. **Exact steps for others to reproduce the error** * load script [P2427: Example of socket interface](https://archive.blender.org/developer/P2427.txt) ```python import bpy import nodeitems_utils class CSTree(bpy.types.NodeTree): bl_idname = 'CSTree' bl_label = "CS Node Editor" bl_icon = 'NODETREE' class CSSocket(bpy.types.NodeSocket): bl_idname = 'CSSocket' bl_label = "CS Socket" def draw(self, context, layout, node, text): layout.label(text=text) def draw_color(self, context, node): return (1.0, 0.8, 0.4, 1.0) class CSSocketInterface(bpy.types.NodeSocketInterface): bl_idname = "CSSocketInterface" bl_socket_idname = "CSSocket" bl_label = "CS Socket" def draw_color(self, context): return (1.0, 0.8, 0.4, 1.0) def draw(self, context, layout): pass class CSNode(bpy.types.Node): bl_idname = 'CSNode' bl_label = "Node" def init(self, context): self.inputs.new('CSSocket', name='Input1') class CSNodeGroup(bpy.types.NodeCustomGroup): bl_idname = 'CSNodeGroup' bl_label = 'Node Group' bl_icon = 'OUTLINER_OB_EMPTY' def init(self, context): self.node_tree = bpy.data.node_groups.new('CSNodeGroup', 'CSTree') nodes = self.node_tree.nodes inputnode = nodes.new('NodeGroupInput') def make_group(context): space_data = context.space_data node_tree = space_data.node_tree selected_nodes = context.selected_nodes node_group = node_tree.nodes.new("CSNodeGroup") node_group_tree = node_group.node_tree input_group = node_group_tree.nodes['Group Input'] new_node = node_group_tree.nodes.new("CSNode") to_socket = new_node.inputs[0] from_socket = input_group.outputs.new(to_socket.bl_idname, to_socket.name) node_group_tree.links.new(input=from_socket, output=to_socket) class CSMakeNodeGroupOperator(bpy.types.Operator): bl_idname = "crowd.cs_make_group" bl_label = "CS Make Group" @classmethod def poll(cls, context): space_data = context.space_data if not (space_data.type == 'NODE_EDITOR' and space_data.tree_type == 'CSTree' and space_data.node_tree is not None): return False return True def execute(self, context): node_group = make_group(context) return {'FINISHED'} def register(): bpy.utils.register_class(CSTree) bpy.utils.register_class(CSSocket) bpy.utils.register_class(CSNode) bpy.utils.register_class(CSNodeGroup) bpy.utils.register_class(CSMakeNodeGroupOperator) def unregister(): bpy.utils.unregister_class(CSTree) bpy.utils.unregister_class(CSSocket) bpy.utils.unregister_class(CSNode) bpy.utils.unregister_class(CSNodeGroup) bpy.utils.unregister_class(CSMakeNodeGroupOperator) if __name__ =="__main__": register() ``` * execute script * open CS Node Editor * create new node tree * Search for "CS Make Group" operator * switch to "CSNodeGroup" tree * Open side panel (N) * Check that the Group/Inputs has one item, but the name in the list is blank. {[F10562486](https://archive.blender.org/developer/F10562486/image.png) width=100%}

Jeroen Bakker commented

2021-09-23 21:31:55 +02:00

Added subscriber: @Jeroen-Bakker

Richard Antalik commented

2021-09-23 21:39:54 +02:00

Added subscriber: @iss

Richard Antalik commented

2021-09-23 21:39:54 +02:00

This is crashing for me in one of steps:

Search (and run) for "CS Make Group" operator
Switch to "CSNodeGroup" tree

This is crashing for me in one of steps: - Search (and run) for "CS Make Group" operator - Switch to "CSNodeGroup" tree

Richard Antalik commented

2021-09-30 19:31:30 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Name of custom socket types is not set when making a node group via script. #91658