Update nodes that realize instances. #91672

Closed
opened 2021-09-24 11:32:20 +02:00 by Jacques Lucke · 5 comments
Member

Nodes should generally not realize instances implicitly. Instead, they should either of the following two behaviors:

  • Handle instances in an explicit way. E.g. the Curve Fill node fills instances without making them real.
  • Create a warning and output an empty geometry when instances are passed in. An explicit Realize Instances node should be used instead.

The following nodes have to be updated:

  • Boolean: Fail when there are instances in the first input.

  • Distribute Points on Faces

  • Curve Fillet

  • Curve Length

  • Curve Resample

  • Curve to Mesh

  • Curve Trim

  • Material Assign

  • Material Replace

  • Mesh Subdivide

  • Triangulate

  • Mesh Subdivision Surface //Should be replaced anyway/

  • Curve to Points: Should be replaced by a node with outputs like point distribute anyway

  • Curve Endpoints: Should be replaced like curve to points anyway

  • Edge Split: Should be replaced by a node with a selection input anyway

Not quite sure if there are errors on this last. Some of the curve nodes may be deprecated already and don't need to be updated.

Explicit Instancing Proposal: https://devtalk.blender.org/t/explicit-instancing-proposal/20494
Meeting Notes on the topic: https://devtalk.blender.org/t/2021-09-20-2021-9-24-geometry-nodes-sub-module-meetings/20594/4

Nodes should generally not realize instances implicitly. Instead, they should either of the following two behaviors: * Handle instances in an explicit way. E.g. the Curve Fill node fills instances without making them real. * Create a warning and output an empty geometry when instances are passed in. An explicit Realize Instances node should be used instead. The following nodes have to be updated: - [x] Boolean: *Fail when there are instances in the first input.* - [x] Distribute Points on Faces - [x] Curve Fillet - [x] Curve Length - [x] Curve Resample - [x] Curve to Mesh - [x] Curve Trim - [x] Material Assign - [x] Material Replace - [x] Mesh Subdivide - [x] Triangulate - [ ] Mesh Subdivision Surface //Should be replaced anyway/ - [ ] Curve to Points: *Should be replaced by a node with outputs like point distribute anyway* - [ ] Curve Endpoints: *Should be replaced like curve to points anyway* - [ ] Edge Split: *Should be replaced by a node with a selection input anyway* Not quite sure if there are errors on this last. Some of the curve nodes may be deprecated already and don't need to be updated. Explicit Instancing Proposal: https://devtalk.blender.org/t/explicit-instancing-proposal/20494 Meeting Notes on the topic: https://devtalk.blender.org/t/2021-09-20-2021-9-24-geometry-nodes-sub-module-meetings/20594/4
Author
Member

Added subscriber: @JacquesLucke

Added subscriber: @JacquesLucke
Jacques Lucke changed title from Don't realize instances in various nodes to Update nodes that realize instances. 2021-09-24 11:56:28 +02:00
Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Hans Goudey self-assigned this 2021-09-27 22:17:04 +02:00
Member

I'm still trying to understand the guidelines for making a node implicitly realize instances or not. But I think curve length could work on instances implicitly? It doesn't output them, and I think that's what users would expect anyway.

I'm still trying to understand the guidelines for making a node implicitly realize instances or not. But I think curve length could work on instances implicitly? It doesn't output them, and I think that's what users would expect anyway.
Member

Followup tasks for the newly legacy nodes:
#91762 (Updated versions of curve to points and curve endpoints nodes)
#91763 (Updated version of subdivision surface node)
#91764 (Updated version of edge split node)

Followup tasks for the newly legacy nodes: #91762 (Updated versions of curve to points and curve endpoints nodes) #91763 (Updated version of subdivision surface node) #91764 (Updated version of edge split node)
Author
Member

Changed status from 'Needs Triage' to: 'Resolved'

Changed status from 'Needs Triage' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#91672
No description provided.