Keymap priorities are different #91794

New Issue

Ovionis · 2021-09-28T22:51:29+02:00

Ovionis commented

2021-09-28 22:51:29 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1650 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.12

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-09-27 18:29, hash: c53ffda8a4
Worked: 3.0.0 Alpha, branch: master, commit date: 2021-08-23 15:09, hash: 7d17f2addf

Short description of error
1 ) Keymaps in the same area (3D View), don't prioritize their order above their activation. Specifically, I have a command as {key shift}+{key tab}.
From top down, #1 is view3d.localview_clickdrag (Local View), as [Click Drag],

2 is view3d.localview (Local View), as [Click],
3 is wm.context_toggle (Context Toggle), as [Press].

Before #3 would not run because #2 would run unless I move the mouse in which case #1 would run (as intended), now #3 will always run no matter what unless I disable it.

2 ) Keymaps from Screen, no longer override keymaps for example from 3D View.
In Screen I have {key shift}+{key Z} for screen.repeat_last (Repeat Last), as Press.
In 3D View I have {key shift}+{key Z} for view3d.toggle_shading (Toggle Shading Type), as Press.

Before, Repeat would work, now it only works if I move the mouse outside of the 3D View's area (because no other area has the same key in use)

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1650 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.12 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-09-27 18:29, hash: `c53ffda8a4` Worked: 3.0.0 Alpha, branch: master, commit date: 2021-08-23 15:09, hash: `7d17f2addf` **Short description of error** 1 ) Keymaps in the same area (3D View), don't prioritize their order above their activation. Specifically, I have a command as {key shift}+{key tab}. From top down, #1 is `view3d.localview_clickdrag` (Local View), as [Click Drag], - 2 is `view3d.localview` (Local View), as [Click], - 3 is `wm.context_toggle` (Context Toggle), as [Press]. Before #3 would not run because #2 would run unless I move the mouse in which case #1 would run (as intended), now #3 will always run no matter what unless I disable it. 2 ) Keymaps from Screen, no longer override keymaps for example from 3D View. In Screen I have {key shift}+{key Z} for `screen.repeat_last` (Repeat Last), as Press. In 3D View I have {key shift}+{key Z} for `view3d.toggle_shading` (Toggle Shading Type), as Press. Before, Repeat would work, now it only works if I move the mouse outside of the 3D View's area (because no other area has the same key in use)

Ovionis commented

2021-09-28 22:51:29 +02:00

Added subscriber: @Phigon

Pratik Borhade commented

2021-09-29 08:08:52 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-09-29 08:42:38 +02:00

In Screen I have {key Shift Z} for screen.repeat_last (Repeat Last), as Press.

Hi, thanks for the report. I think you have customized the Keymap.

Not sure I understand the first part of the report but in 2nd part you have assigned same keys for two different operations, which conflicts with Blender’s default keymap.

Worked: 3.0.0 Alpha, branch: master, commit date: 2021-08-23

Could you please clarify the exact issue? Tested on master & 962153dbed , both gave me the same output.

> In Screen I have {key Shift Z} for screen.repeat_last (Repeat Last), as Press. Hi, thanks for the report. I think you have customized the Keymap. Not sure I understand the first part of the report but in 2nd part you have assigned same keys for two different operations, which conflicts with Blender’s default keymap. > Worked: 3.0.0 Alpha, branch: master, commit date: 2021-08-23 Could you please clarify the exact issue? Tested on master & 962153dbed , both gave me the same output.

Ovionis commented

2021-09-29 16:32:29 +02:00

Yes I'm using custom keys. I use an addon to add keys above Blender's keys.

1

Go to the preferences under 3D View or whatever, and add 2 keys with something unused (like {key u}). Set the first to be Click Drag, and the second to be Click.
Maybe transform.translate and object.select_all.
When you press the button without moving the mouse, the second op will run, and if you drag the mouse first the first will run. You can switch them around if you want.
Next change the / add a key below to be Press. The above key(s) will now never run again, unless the bottom op's poll fails.

2

Go to the preferences, under 3D View, add a key and op {key u} (or pick the key of an existing op).
Under Screen or Window add something, like ed.undo_history (which can be used in and out of the 3D View).
Only the 3D View's op will run in the 3D View.

Yes I'm using custom keys. I use an addon to add keys above Blender's keys. # 1 Go to the preferences under 3D View or whatever, and add 2 keys with something unused (like {key u}). Set the first to be Click Drag, and the second to be Click. Maybe `transform.translate` and `object.select_all`. When you press the button without moving the mouse, the second op will run, and if you drag the mouse first the first will run. You can switch them around if you want. Next change the / add a key below to be Press. The above key(s) will now never run again, unless the bottom op's poll fails. # 2 Go to the preferences, under 3D View, add a key and op {key u} (or pick the key of an existing op). Under Screen or Window add something, like `ed.undo_history` (which can be used in and out of the 3D View). Only the 3D View's op will run in the 3D View.

Richard Antalik commented

2021-09-30 16:44:09 +02:00

Added subscribers: @lichtwerk, @ideasman42, @iss

Richard Antalik commented

2021-09-30 16:44:09 +02:00

Here all builds give consistent results: First time keymap for 3D view is used, then keymap for Window is used.

I don't think there is any system in place to resolve keymap conflicts between various areas apart from operator poll functions. Usually this is hardcoded in operators to pass through events if some conditions are not met. Not sure if keymaps are read in order, but I don't think this would be meant to be deterministic.

Not 100% sure on this though, but I don't see code to dispatch duplicate keymaps. @lichtwerk, @ideasman42 Am I correct here?

Here all builds give consistent results: First time keymap for 3D view is used, then keymap for Window is used. I don't think there is any system in place to resolve keymap conflicts between various areas apart from operator poll functions. Usually this is hardcoded in operators to pass through events if some conditions are not met. Not sure if keymaps are read in order, but I don't think this would be meant to be deterministic. Not 100% sure on this though, but I don't see code to dispatch duplicate keymaps. @lichtwerk, @ideasman42 Am I correct here?

Ovionis commented

2021-09-30 19:08:55 +02:00

Changed status from 'Needs Triage' to: 'Resolved'

Ovionis closed this issue

2021-09-30 19:08:55 +02:00

Ovionis self-assigned this 2021-09-30 19:08:55 +02:00

Ovionis commented

2021-09-30 19:08:55 +02:00

Sorry, my fault.

I went to record both blender builds, side by side repeating my previous instructions, wherein this time it would not work.
Confused, as I could swear it worked last time, I did some tests and found the problem was my addon's keymapping.
One of the things I do with it is disable Blender keys (and I didn't realize I already specified key conflicts between Click/Drag and Press).

What went wrong was that my addon compared with "is" for bools instead of "==", and before the keymap bool shift/ctrl/alt were actual Booleans, and now return an int.
For example bpy.context.window_manager.keyconfigs.active.keymaps['3D View'].keymap_items['wm.context_toggle'].shift would return True, now it returns 1

My previous steps possibly worked because of a glitch or I'm just misremembering but either way, I can't repeat the process on video and have got my keys working, so the problem is solved.

Sorry, my fault. I went to record both blender builds, side by side repeating my previous instructions, wherein this time it would not work. Confused, as I could swear it worked last time, I did some tests and found the problem was my addon's keymapping. One of the things I do with it is disable Blender keys (and I didn't realize I already specified key conflicts between Click/Drag and Press). What went wrong was that my addon compared with "is" for bools instead of "==", and before the keymap `bool` shift/ctrl/alt were actual Booleans, and now return an `int`. For example `bpy.context.window_manager.keyconfigs.active.keymaps['3D View'].keymap_items['wm.context_toggle'].shift` would return `True`, now it returns `1` My previous steps possibly worked because of a glitch or I'm just misremembering but either way, I can't repeat the process on video and have got my keys working, so the problem is solved.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Keymap priorities are different #91794

1

2