Undoing texture paint stroke randomly undoes one additional operation #92641

Closed
opened 2021-10-30 10:11:00 +02:00 by Ludvik Koutny · 19 comments
Contributor

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.12

Blender Version
Broken: version: 2.93.4, branch: master (modified), commit date: 2021-08-31 09:23, hash: b7205031ce
Worked: (newest version of Blender that worked as expected)

Short description of error
When texture painting in 3D viewport, undoing the first brush stroke always also randomly undoes one additional operation, in my most recent case, paint mask toggle.

Exact steps for others to reproduce the error
No reliable reproduction steps, happens often on first texture paint stroke after entering texture paint mode in 3D viewport and configuring some settings.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.12 **Blender Version** Broken: version: 2.93.4, branch: master (modified), commit date: 2021-08-31 09:23, hash: `b7205031ce` Worked: (newest version of Blender that worked as expected) **Short description of error** When texture painting in 3D viewport, undoing the first brush stroke always also randomly undoes one additional operation, in my most recent case, paint mask toggle. **Exact steps for others to reproduce the error** No reliable reproduction steps, happens often on first texture paint stroke after entering texture paint mode in 3D viewport and configuring some settings.
Author
Contributor

Added subscriber: @Rawalanche

Added subscriber: @Rawalanche
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123

Added subscriber: @mano-wii

Added subscriber: @mano-wii

Changed status from 'Needs Triage' to: 'Needs User Info'

Changed status from 'Needs Triage' to: 'Needs User Info'

Thanks for the report, but it is not clear what the problem is described in the report.
Is it any of these:
#88592 (Undo eliminates brush texture)
#69346 (Undo doesn't work with paint mask selection (texture paint vs. vertex/weightpaint))
#78181 (Texture Paint: Color Palette operator issues with Undo/Redo -- Vertex Paint is fine though)

For the development team to be able to help, there needs to be either reproducible steps.

There are plans to redo the paint modes Undo system:
#85797 (Refactor and simplify Image (paint) undo code)

Thanks for the report, but it is not clear what the problem is described in the report. Is it any of these: #88592 (Undo eliminates brush texture) #69346 (Undo doesn't work with paint mask selection (texture paint vs. vertex/weightpaint)) #78181 (Texture Paint: Color Palette operator issues with Undo/Redo -- Vertex Paint is fine though) For the development team to be able to help, there needs to be either reproducible steps. There are plans to redo the paint modes Undo system: #85797 (Refactor and simplify Image (paint) undo code)
Author
Contributor

In #92641#1247551, @mano-wii wrote:
Thanks for the report, but it is not clear what the problem is described in the report.
Is it any of these:
#88592 (Undo eliminates brush texture)
#69346 (Undo doesn't work with paint mask selection (texture paint vs. vertex/weightpaint))
#78181 (Texture Paint: Color Palette operator issues with Undo/Redo -- Vertex Paint is fine though)

For the development team to be able to help, there needs to be either reproducible steps.

There are plans to redo the paint modes Undo system:
#85797 (Refactor and simplify Image (paint) undo code)

I don't think it was any of these, but it was similar. So please keep this open for a few more days, and I will try to gather all the specific operations it undoes, with possible repro steps.

> In #92641#1247551, @mano-wii wrote: > Thanks for the report, but it is not clear what the problem is described in the report. > Is it any of these: > #88592 (Undo eliminates brush texture) > #69346 (Undo doesn't work with paint mask selection (texture paint vs. vertex/weightpaint)) > #78181 (Texture Paint: Color Palette operator issues with Undo/Redo -- Vertex Paint is fine though) > > For the development team to be able to help, there needs to be either reproducible steps. > > There are plans to redo the paint modes Undo system: > #85797 (Refactor and simplify Image (paint) undo code) I don't think it was any of these, but it was similar. So please keep this open for a few more days, and I will try to gather all the specific operations it undoes, with possible repro steps.
Author
Contributor

Ok, I got one. Undoing a Paint stroke undoes Calculate option under Alpha rollout of Image Texture:
2021-11-22 13-45-18.mp4
But seriously, this needs to be addressed more systematically than individually patching each random checkbox.

Ok, I got one. Undoing a Paint stroke undoes Calculate option under Alpha rollout of Image Texture: [2021-11-22 13-45-18.mp4](https://archive.blender.org/developer/F11843593/2021-11-22_13-45-18.mp4) But seriously, this needs to be addressed more systematically than individually patching each random checkbox.

Added subscriber: @Jenny-Brown

Added subscriber: @Jenny-Brown

I am seeing the same behavior with weight painting rather than texture painting. I've modified a mesh, and then go into weight paint mode and make a couple of weight paint strokes. Instead of Undo removing one weight paint stroke at a time, it jumps me back out of weight paint mode, and sometimes also undoes whatever step I did just prior to weight painting. Undo is going more than one step back, which makes it quite difficult to use. I'm using 2.93.5 on Windows 10.

I am seeing the same behavior with weight painting rather than texture painting. I've modified a mesh, and then go into weight paint mode and make a couple of weight paint strokes. Instead of Undo removing one weight paint stroke at a time, it jumps me back out of weight paint mode, and sometimes also undoes whatever step I did just prior to weight painting. Undo is going more than one step back, which makes it quite difficult to use. I'm using 2.93.5 on Windows 10.

Changed status from 'Needs User Info' to: 'Needs Triage'

Changed status from 'Needs User Info' to: 'Needs Triage'
Member

Added subscriber: @OmarEmaraDev

Added subscriber: @OmarEmaraDev
Member

Changed status from 'Needs Triage' to: 'Needs User Info'

Changed status from 'Needs Triage' to: 'Needs User Info'
Member

I could reproduce the Calculate Alpha undo two times, but it happens randomly and can't be reproduced reliably.
Are you able to provide more exact reproduction steps start from a simple file?

I could reproduce the Calculate Alpha undo two times, but it happens randomly and can't be reproduced reliably. Are you able to provide more exact reproduction steps start from a simple file?
Author
Contributor

In #92641#1304491, @OmarEmaraDev wrote:
I could reproduce the Calculate Alpha undo two times, but it happens randomly and can't be reproduced reliably.
Are you able to provide more exact reproduction steps start from a simple file?

Unfortunately not, that's why I wrote randomly. But I found out it happens more frequently when you undo the first stroke after entering the paint mode. When you undo the strokes after the first one, it tends to happen more rarely. Unfortunately the undo in paint modes is fundamentally flawed, so chasing specific occurrences of these bugs is extremely difficult. Especially in terms of additional actions they are undoing.

> In #92641#1304491, @OmarEmaraDev wrote: > I could reproduce the Calculate Alpha undo two times, but it happens randomly and can't be reproduced reliably. > Are you able to provide more exact reproduction steps start from a simple file? Unfortunately not, that's why I wrote randomly. But I found out it happens more frequently when you undo the first stroke after entering the paint mode. When you undo the strokes after the first one, it tends to happen more rarely. Unfortunately the undo in paint modes is fundamentally flawed, so chasing specific occurrences of these bugs is extremely difficult. Especially in terms of additional actions they are undoing.
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Note we have #69760 (Undo/Adjust Last Operation: vertex and weightpaint operators/strokes undo more then they should (change back any setting changed prior to execution)) for vertexpaint and weightpaint, but texture paint is explicitly excluded there...

Note we have #69760 (Undo/Adjust Last Operation: vertex and weightpaint operators/strokes undo more then they should (change back any setting changed prior to execution)) for vertexpaint and weightpaint, but texture paint is explicitly excluded there...
Member

Changed status from 'Needs User Info' to: 'Needs Triage'

Changed status from 'Needs User Info' to: 'Needs Triage'
Member

Closed as duplicate of #62520

Closed as duplicate of #62520
Member

I can reproduce #62520 much more reliably and is still valid. So merging to that one as it is very similar, the additional operation being changing the slot.

I can reproduce #62520 much more reliably and is still valid. So merging to that one as it is very similar, the additional operation being changing the slot.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#92641
No description provided.