Cycles HIP device missing driver version check #93109

New Issue

brunnerh · 2021-11-16T00:51:21+01:00

brunnerh commented

2021-11-16 00:51:21 +01:00

System Information
Operating system: Windows-10-10.0.19042-SP0 64 Bits
Graphics card: AMD Radeon RX 5700 XT ATI Technologies Inc. 4.5.14742 Core Profile Context 21.8.2 27.20.22025.1006

Blender Version
Broken: version: 3.1.0 Alpha, branch: master, commit date: 2021-11-14 00:26, hash: 7e82c840b7
Worked: Unknown

Short description of error
When using the new HIP GPU rendering with cycles I currently get this error (using the graphics card listed above):

Invalid value in hipDeviceGetAttribute(&pitch_alignment, hipDeviceAttributeTexturePitchAlignment, hipDevice) (C:\Users\blender\git\blender-vdev\blender.git\intern\cycles\device\hip\device_impl.cpp:115)

Exact steps for others to reproduce the error
Just tried to render the default cube, setting engine to Cycles and device to GPU Compute.

Logs:
blender_debug_output.txt
blender_system_info.txt

**System Information** Operating system: Windows-10-10.0.19042-SP0 64 Bits Graphics card: AMD Radeon RX 5700 XT ATI Technologies Inc. 4.5.14742 Core Profile Context 21.8.2 27.20.22025.1006 **Blender Version** Broken: version: 3.1.0 Alpha, branch: master, commit date: 2021-11-14 00:26, hash: `7e82c840b7` Worked: Unknown **Short description of error** When using the new HIP GPU rendering with cycles I currently get this error (using the graphics card listed above): > Invalid value in hipDeviceGetAttribute(&pitch_alignment, hipDeviceAttributeTexturePitchAlignment, hipDevice) (C:\Users\blender\git\blender-vdev\blender.git\intern\cycles\device\hip\device_impl.cpp:115) **Exact steps for others to reproduce the error** Just tried to render the default cube, setting engine to `Cycles` and device to `GPU Compute`. Logs: [blender_debug_output.txt](https://archive.blender.org/developer/F11811664/blender_debug_output.txt) [blender_system_info.txt](https://archive.blender.org/developer/F11811665/blender_system_info.txt)

brunnerh commented

2021-11-16 00:51:21 +01:00

Added subscriber: @brunnerh

Jesse Yurkovich commented

2021-11-16 00:57:39 +01:00

Added subscriber: @deadpin

Jesse Yurkovich commented

2021-11-16 00:57:39 +01:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Jesse Yurkovich commented

2021-11-16 00:57:39 +01:00

Are you using the very latest AMD driver - it seems your driver version is a little older? https://www.amd.com/en/support/kb/release-notes/rn-rad-win-21-40-beta-blender-3-0

Brecht Van Lommel commented

2021-11-16 18:02:13 +01:00

Added subscribers: @leesonw, @BrianSavery, @brecht

Brecht Van Lommel commented

2021-11-16 18:02:13 +01:00

I thought that older AMD drivers don't even have the HIP library, so there would be no need to check the driver version, since there exists no older HIP driver.

However I think 21.8.2 is an Adrenalin driver from August so I'm not sure what is going on. Maybe we do need that driver version check?

CC @BrianSavery @leesonw.

I thought that older AMD drivers don't even have the HIP library, so there would be no need to check the driver version, since there exists no older HIP driver. However I think 21.8.2 is an Adrenalin driver from August so I'm not sure what is going on. Maybe we do need that driver version check? CC @BrianSavery @leesonw.

Brian Savery (AMD) commented

2021-11-16 18:24:12 +01:00

Yes I think we do need to check unfortunately.

Brecht Van Lommel commented

2021-11-16 19:02:19 +01:00

Changed status from 'Needs User Info' to: 'Confirmed'

Brecht Van Lommel commented

2021-11-16 19:02:19 +01:00

Ok, I'll consider this a confirm to be fixed for 3.0 then.

It should be pretty simple to add a check using hipDriverGetVersion I guess.

Ok, I'll consider this a confirm to be fixed for 3.0 then. It should be pretty simple to add a check using `hipDriverGetVersion` I guess.

Brian Savery (AMD) self-assigned this 2021-11-16 19:27:20 +01:00

Brian Savery (AMD) commented

2021-11-16 19:27:20 +01:00

I'll make that fix right now.

brunnerh commented

2021-11-16 19:31:04 +01:00

In #93109#1254095, @deadpin wrote:
Are you using the very latest AMD driver - it seems your driver version is a little older? https://www.amd.com/en/support/kb/release-notes/rn-rad-win-21-40-beta-blender-3-0

I did an automatic driver update to v21.10.2 (as my card is not listed as supported for the drivers you linked) and rendering the default cube and some other scenes worked.

However, one of my complex scenes lead to this error:

Invalid value in hipTexObjectCreate(&cmem->texobject, &resDesc, &texDesc, 0) (C:\Users\blender\git\blender-vdev\blender.git\intern\cycles\device\hip\device_impl.cpp:1100)

I then tried installing the linked beta driver, but the error remained.

Should I try to track down what element is causing the error or is my GPU simply not really supported?

blender_system_info.txt
blender_debug_output.txt

> In #93109#1254095, @deadpin wrote: > Are you using the very latest AMD driver - it seems your driver version is a little older? https://www.amd.com/en/support/kb/release-notes/rn-rad-win-21-40-beta-blender-3-0 I did an automatic driver update to v21.10.2 (as my card is not listed as supported for the drivers you linked) and rendering the default cube and some other scenes worked. However, one of my complex scenes lead to this error: > Invalid value in hipTexObjectCreate(&cmem->texobject, &resDesc, &texDesc, 0) (C:\Users\blender\git\blender-vdev\blender.git\intern\cycles\device\hip\device_impl.cpp:1100) I then tried installing the linked beta driver, but the error remained. Should I try to track down what element is causing the error or is my GPU simply not really supported? [blender_system_info.txt](https://archive.blender.org/developer/F11816019/blender_system_info.txt) [blender_debug_output.txt](https://archive.blender.org/developer/F11816018/blender_debug_output.txt)

brunnerh commented

2021-11-16 19:56:49 +01:00

I was curious and tried to find the source, it looks like the issue is a little texture I made that has the dimensions 32,768 px x 864 px

book.blend

I was curious and tried to find the source, it looks like the issue is a little texture I made that has the dimensions 32,768 px x 864 px [book.blend](https://archive.blender.org/developer/F11816077/book.blend)

Jesse Yurkovich commented

2021-11-16 20:00:19 +01:00

Perhaps that exceeds current hardware capability. Per your system info file:

hipDeviceAttributeMaxTexture1DWidth			16384
hipDeviceAttributeMaxTexture2DWidth			16384
hipDeviceAttributeMaxTexture2DHeight			16384

Perhaps that exceeds current hardware capability. Per your system info file: ``` hipDeviceAttributeMaxTexture1DWidth 16384 hipDeviceAttributeMaxTexture2DWidth 16384 hipDeviceAttributeMaxTexture2DHeight 16384 ```

Brecht Van Lommel commented

2021-11-16 20:04:49 +01:00

With OpenCL we did our own texture filtering, with CUDA and HIP we use the textures and so are also limited by them.

With CUDA on a RTX A6000 I see this:

    CU_DEVICE_ATTRIBUTE_MAXIMUM_TEXTURE1D_WIDTH     131072
    CU_DEVICE_ATTRIBUTE_MAXIMUM_TEXTURE2D_WIDTH     131072
    CU_DEVICE_ATTRIBUTE_MAXIMUM_TEXTURE2D_HEIGHT      65536

I'm not sure if 16384 is an AMD hardware limitaton or if HIP is being too conservative?

With OpenCL we did our own texture filtering, with CUDA and HIP we use the textures and so are also limited by them. With CUDA on a RTX A6000 I see this: ``` CU_DEVICE_ATTRIBUTE_MAXIMUM_TEXTURE1D_WIDTH 131072 CU_DEVICE_ATTRIBUTE_MAXIMUM_TEXTURE2D_WIDTH 131072 CU_DEVICE_ATTRIBUTE_MAXIMUM_TEXTURE2D_HEIGHT 65536 ``` I'm not sure if 16384 is an AMD hardware limitaton or if HIP is being too conservative?

Brian Savery (AMD) commented

2021-11-16 20:11:12 +01:00

Actually, it turns out hipDriverGetVersion does not give the info we need. we'd have to do something here like looking up the driver version in the registry.

Actually, it turns out `hipDriverGetVersion` does not give the info we need. we'd have to do something here like looking up the driver version in the registry.

brunnerh commented

2021-11-16 20:16:27 +01:00

Incidentally 16384 is exactly half the size of the texture, so I tried scaling by 0.5 but it still error'd.
(Could there be an off-by-one error here that rejects the texture even though it should work in my case?).

After scaling by 0.5 again to 8192 x 216 it started working.

Incidentally 16384 is exactly half the size of the texture, so I tried scaling by 0.5 but it still error'd. (Could there be an off-by-one error here that rejects the texture even though it should work in my case?). After scaling by 0.5 again to 8192 x 216 it started working.

Jeroen Bakker commented

2021-11-16 22:26:41 +01:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker commented

2021-11-16 22:26:41 +01:00

Max texture size should not be seen as an exact number. It depends on type of texture and other attributes. If I recall correctly most textured allocations work from 12k and lower.

Brecht Van Lommel commented

2021-11-17 16:45:16 +01:00

I added the texture size issue to #91571. We should at a minimum give an error to the user, but could also resize since we already have code for that.

Brecht Van Lommel changed title from ~~Invalid value error for HIP device rendering~~ to Cycles HIP device missing driver version check

2021-11-17 16:46:45 +01:00

Thomas Dinges commented

2021-11-17 16:52:25 +01:00

Added subscriber: @ThomasDinges

Thomas Dinges commented

2021-11-17 16:52:25 +01:00

@BrianSavery Would hipRuntimeGetVersion give relevant info? https://rocm-developer-tools.github.io/HIP/group__Driver.html#gae8b7ba34d2e11e334650aa51a4dd87ee

@BrianSavery Would `hipRuntimeGetVersion `give relevant info? https://rocm-developer-tools.github.io/HIP/group__Driver.html#gae8b7ba34d2e11e334650aa51a4dd87ee

Brecht Van Lommel commented

2021-11-19 16:42:58 +01:00

Added subscriber: @Sayak-Biswas

Brecht Van Lommel commented

2021-11-19 16:42:58 +01:00

@BrianSavery, @Sayak-Biswas, is there any update on this from your side? We really like to have all high priority bugs fixed at least a week before the release, which means by next Wednesday.

We could probably figure out an appropriate driver check ourselves, but would like to know as soon as possible then if this is something we should work on.

@BrianSavery, @Sayak-Biswas, is there any update on this from your side? We really like to have all high priority bugs fixed at least a week before the release, which means by next Wednesday. We could probably figure out an appropriate driver check ourselves, but would like to know as soon as possible then if this is something we should work on.

Sayak Biswas commented

2021-11-19 18:19:17 +01:00

hipRuntimeGetVersion doesn't really provide the correct info. We can get the relevant driver version string from the Windows registry. I will add this to give out an error in case the driver < 21.40.

`hipRuntimeGetVersion` doesn't really provide the correct info. We can get the relevant driver version string from the Windows registry. I will add this to give out an error in case the driver < 21.40.

Ray molenkamp commented

2021-11-19 18:25:30 +01:00

Added subscriber: @LazyDodo

Ray molenkamp commented

2021-11-19 18:25:30 +01:00

Is there any chance we can trust the version info of the shared amdhip64.dll file? i'd rather query that than go rummage around in the registry, should be pretty straight forward, example in bli_windows_get_module_version

Is there any chance we can trust the version info of the shared `amdhip64.dll` file? i'd rather query that than go rummage around in the registry, should be pretty straight forward, example in `bli_windows_get_module_version`

Sayak Biswas commented

2021-11-22 20:06:50 +01:00

We should be able to use it, I am confirming with the driver packaging team. The drawback would be that this dll version info will not the same number as the Radeon Software package version (i.e not 21.40 etc) so we won't be able to provide a more user friendly message other than maybe "Please upgrade driver to 21.40 or later".

Brecht Van Lommel commented

2021-11-22 20:13:42 +01:00

That's already the only message we provide to users in the preferences. We don't use the detected driver version number in the message to users, only the debug logs have more detail. So it doesn't really matter.

Sayak Biswas commented

2021-11-23 03:20:10 +01:00

Submitted patch checking for file version of amdhip64.dll

周建峰 commented

2021-11-23 11:53:06 +01:00

Added subscriber: @2905710881

周建峰 commented

2021-11-23 11:53:06 +01:00

In #93109#1258377, @Sayak-Biswas wrote:
Submitted patch checking for file version of amdhip64.dll

Is there any built-in hip support in 21.Q3.1? Is there a chance for future Adrenalin to join as well?

> In #93109#1258377, @Sayak-Biswas wrote: > Submitted patch checking for file version of amdhip64.dll Is there any built-in hip support in 21.Q3.1? Is there a chance for future Adrenalin to join as well?

Thomas Dinges commented

2021-11-23 11:57:26 +01:00

You need the 21.40 driver. HIP will come to the Adrenalin driver in the future, see https://devtalk.blender.org/t/2021-11-9-blender-rendering-meeting/21326/14

Please don't use this tracker for user questions though!

You need the 21.40 driver. HIP will come to the Adrenalin driver in the future, see https://devtalk.blender.org/t/2021-11-9-blender-rendering-meeting/21326/14 Please don't use this tracker for user questions though!

blender-admin commented

2021-11-23 14:16:24 +01:00

This issue was referenced by blender/cycles@8f81c6dfd8

This issue was referenced by blender/cycles@8f81c6dfd87069e1b444734bc9d3e268cb163f34

blender-admin commented

2021-11-23 14:16:24 +01:00

This issue was referenced by 3bb8d173e7

This issue was referenced by 3bb8d173e70c1ec80612733c63efedc5e1d854e5

Brecht Van Lommel commented

2021-11-23 15:46:31 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Brecht Van Lommel closed this issue