Regression: Hiding all points of a spline in curve edit mode does not hide splines #93756

Open
opened 2021-12-06 16:01:36 +01:00 by Jan-Willem van Dronkelaar · 12 comments

System Information
Operating system: Windows-10-10.0.19042-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.12

Blender Version
Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: f1cca30557
Worked: version: 2.93.6, branch: master, commit date: 2021-11-16 14:54, hash: c842a90e2f

Caused by b9febb54a4

Short description of error
Hiding all points of a spline in bezier edit mode does not hide the related curve spline

Exact steps for others to reproduce the error

  1. Add a bezier object (like the squigle)
  2. Go into edit mode
  3. Select all the points
  4. Press H to hide
  5. Only the points are hidden but the curve (spline) remains visible

Expected behavior:
5) Both the points and the related curve spline are hidden (as they were in 2.93.6)

#93756.blend

**System Information** Operating system: Windows-10-10.0.19042-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.12 **Blender Version** Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: `f1cca30557` Worked: version: 2.93.6, branch: master, commit date: 2021-11-16 14:54, hash: `c842a90e2f` Caused by b9febb54a4 **Short description of error** Hiding all points of a spline in bezier edit mode does not hide the related curve spline **Exact steps for others to reproduce the error** 1) Add a bezier object (like the squigle) 2) Go into edit mode 3) Select all the points 4) Press H to hide 5) Only the points are hidden but the curve (spline) remains visible Expected behavior: 5) Both the points and the related curve spline are hidden (as they were in 2.93.6) [#93756.blend](https://archive.blender.org/developer/F12698369/T93756.blend)

Added subscriber: @jwvdronkelaar

Added subscriber: @jwvdronkelaar
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

We are talking about individual splines, right?
Blender was never hiding segments afaict.

But regarding the splines, yes, can confirm, will check

We are talking about individual splines, right? Blender was never hiding segments afaict. But regarding the splines, yes, can confirm, will check

@lichtwerk Yes we are talking about individual splines. Blender never did hide individual segments.

Admittedly it would be very nice if you could hide individual segments but lets not turn this into a feature request and fix the regression instead.

@lichtwerk Yes we are talking about individual splines. Blender never did hide individual segments. Admittedly it would be very nice if you could hide individual segments but lets not turn this into a feature request and fix the regression instead.
Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Member

Hmm, I think this might be another victim of the ongoing curve code transition. Since curves are drawn in the viewport with CurveEval, which doesn't contain the "hidden" data at all currently.

Hmm, I think this might be another victim of the ongoing curve code transition. Since curves are drawn in the viewport with `CurveEval`, which doesn't contain the "hidden" data at all currently.
Hans Goudey changed title from Hiding points in bezier edit mode does not hide the curve segments to Hiding points in curve edit mode does not hide splines 2021-12-06 16:33:00 +01:00
Member

This is also caused by b9febb54a4

It is in the same ballpark as #93573 (Regression: Selection outline of curves in edit mode)

Changing to High prio, since it is a 3.0 regression

CC @HooglyBoogly

This is also caused by b9febb54a4 It is in the same ballpark as #93573 (Regression: Selection outline of curves in edit mode) Changing to High prio, since it is a 3.0 regression CC @HooglyBoogly
Philipp Oeser changed title from Hiding points in curve edit mode does not hide splines to Hiding all points of a spline in curve edit mode does not hide splines 2021-12-06 16:35:14 +01:00
Member

I'm not sure if this is possible to fix without larger changes currently. The evaluated curve has no idea about which control points were hidden in the original curve. There also isn't any "original index" tracking to support some kind of lookup heuristic to figure out what to hide. There is also ongoing discussion about switching to a totally separate curve data structure (#94193), so I'm not sure it's worth the time to rethink the design for this case.

I'm not sure if this is possible to fix without larger changes currently. The evaluated curve has no idea about which control points were hidden in the original curve. There also isn't any "original index" tracking to support some kind of lookup heuristic to figure out what to hide. There is also ongoing discussion about switching to a totally separate curve data structure (#94193), so I'm not sure it's worth the time to rethink the design for this case.
Philipp Oeser changed title from Hiding all points of a spline in curve edit mode does not hide splines to Regression: Hiding all points of a spline in curve edit mode does not hide splines 2022-03-25 13:33:23 +01:00
Member

Added subscriber: @Jeroen-Bakker

Added subscriber: @Jeroen-Bakker
Member

Setting to normal priority as it might have never worked and would require design decisions to be made.

Setting to normal priority as it might have never worked and would require design decisions to be made.
Member

In #93756#1442429, @Jeroen-Bakker wrote:
... as it might have never worked...

Eh, agree on the other part but yes, it worked prior to b9febb54a4 :)

> In #93756#1442429, @Jeroen-Bakker wrote: > ... as it might have never worked... Eh, agree on the other part but yes, it worked prior to b9febb54a4 :)
Philipp Oeser removed the
Interest
EEVEE & Viewport
label 2023-02-09 15:13:01 +01:00
Philipp Oeser added the
Interest
Nodes & Physics
label 2023-02-10 11:20:20 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#93756
No description provided.