Clicking on empty space in editors creates undo step #94080
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
9 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#94080
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Blender Version
Broken: version: 3.0.0, branch: master (modified), commit date: 2021-12-02 18:35, hash:
f1cca30557Broken: version: 2.80
Worked: 2.79b
Short description of error
When clicking in certain Editors (doesn't matter if it's not selecting/doing anything) undo step is created. It does make sense to do in certain cases when selecting objects (for example, when selecting objects via outliner undo to previous selection is logical) but definitely not when there are nothing to select.
Affected Editors/modes:
3775615aea)SequencerandSequencer & Previewmodes (clicking on image) (5d30c3994e)Dope Sheet,Grease Pencil,Mask,Cache FileWhere to click:
Exact steps for others to reproduce the error
Added subscriber: @Garek
Added subscriber: @mano-wii
Thanks for the report.
This report cannot be resolved in a single commit, as each case mentioned involves a different operator.
Therefore, the ideal would be for them to be mentioned separately :\
Added subscriber: @deadpin
Changed status from 'Needs Triage' to: 'Confirmed'
Will mark as confirmed since I can reproduce and there's work being done for it already. I suppose this can be tagged UI for now?
This issue was referenced by
3775615aeaChanged status from 'Confirmed' to: 'Needs User Info'
The steps only mention the
Outlinercase, so I'm not sure how to replicate the other cases.They are the same, only change is affected area.
You can see where to click here:
Changed status from 'Needs User Info' to: 'Confirmed'
Added subscriber: @PratikPB2123
@mano-wii hi, can we can move this report under #good_first_issue if you're not planning for remaining changes?
A sample commit(
3775615aea) is already available for the reference so I guess it'd be a perfect candidate for new contributors :)Looks good to me.
Added subscriber: @Suyash-Sapkal
Hi, Can I take this up?
I am new to blender. Can someone guide me on this?
Hi, sure, feel free to submit the patch.
Similar to
3775615aeayou'd need to to do for other editors.If nothing is selected and state has not changed, then return
OPERATOR_CANCELLEDin the_execfunction (returning this doesn't create undo step).For example, for timeline editor, start by looking at the
actkeys_clickselect_execfunction, add breakpoint there. Particularly step intomouse_action_keys()function call.@lichtwerk @mano-wii can you update the description here?
I fixed the issue with the Sequencer and the Sequencer Preview in
5d30c3994eHello! I was wondering if I could contribute to this? I'm new to blender but I'm pretty sure I can figure things out from the previous commits!
@Melissa-Goon hi, feel free to work on this. Pick any editor from the list mentioned in the report description.
Hi! Sorry if I made any mistakes with how I did my pull request but I did this fix on the undo step created when clicking the timeline: 67bf4755c1. Any feedback would be appreciated!
@Melissa-Goon hi, you've commited changes to the main branch of remote repository.
For generating/submitting Pull request, create a branch locally and commit changes to the local branch then push these changes to remote repository.
Refer: https://wiki.blender.org/wiki/Tools/Pull_Requests
Hey @PratikPB2123, can I pick it up as my first issue if no one is working on it?
@Abhiyankar-Shakti hi, Melissa is working on
Timeline. You can choose any from the remaining :)