Primary buttons have a reddish :focus colour #94688

New Issue

Anna Sirota · 2022-01-06T14:41:30+01:00

Anna Sirota commented

2022-01-06 14:41:30 +01:00

This is currently reproducible in the navbar at id.blender.org.

Not sure if this is intentional, but all buttons with white text have a reddish/pinkish focus colour, for example:

(on the second screenshot button has btn-outline-secondary classes, at the moment of reporting this class wasn't part of BWA, so primary btn styles applied there too)

It might have something to do with how that colour is calculated in _utils.sass:

...
&:active, &:focus
	...
	color: hsl(hue($text-color), 100%, 85%)

This is currently reproducible in the navbar at id.blender.org. Not sure if this is intentional, but all buttons with white text have a reddish/pinkish focus colour, for example: ![2022-01-06-143418_619x983_scrot.png](https://archive.blender.org/developer/F12791545/2022-01-06-143418_619x983_scrot.png) ![2022-01-06-144341_501x1070_scrot.png](https://archive.blender.org/developer/F12791628/2022-01-06-144341_501x1070_scrot.png) (on the second screenshot button has `btn-outline-secondary` classes, at the moment of reporting this class wasn't part of BWA, so primary `btn` styles applied there too) It might have something to do with how that colour is calculated in `_utils.sass`: ``` ... &:active, &:focus ... color: hsl(hue($text-color), 100%, 85%) ```

Anna Sirota commented

2022-01-06 14:41:30 +01:00

Added subscriber: @railla

Philipp Oeser commented

2022-03-10 10:54:19 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-03-10 10:54:19 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2022-03-10 10:54:19 +01:00

@railla is this an #infrastructure:_blender_web_assets internal TODO?
If this should pass the #triaging queue, it would be better to have exact repro steps also (which URL/button to check specifically etc.).
If this should not pass the #triaging queue, it would be better to set subtype to TODO/DESIGN/... (default is REPORT which is associated with #triaging ) or set status to CONFIRMED

@railla is this an #infrastructure:_blender_web_assets internal TODO? If this should pass the #triaging queue, it would be better to have exact repro steps also (which URL/button to check specifically etc.). If this should not pass the #triaging queue, it would be better to set subtype to TODO/DESIGN/... (default is REPORT which is associated with #triaging ) or set status to CONFIRMED

Anna Sirota commented

2022-03-10 11:01:39 +01:00

@lichtwerk yes, this is an internal TODO, updated it (and others) to a relevant subtype.
my apologies, I keep forgetting that web-related tasks also end up in Triaging.

@lichtwerk yes, this is an internal TODO, updated it (and others) to a relevant subtype. my apologies, I keep forgetting that web-related tasks also end up in Triaging.

Pablo Vazquez commented

2022-07-14 16:36:08 +02:00

Added subscriber: @pablovazquez