Custom bone shape disappears if going to editmode on the custom shape object #94886

New Issue

Steven Baar · 2022-01-13T20:15:52+01:00

Steven Baar commented

2022-01-13 20:15:52 +01:00

System Information
Operating system: Windows 10
Graphics card: RTX 2070 GAMING OC

Blender Version
Broken: (example: 2.80, edbf15d3c0, master, 2018-11-28, as found on the splash screen)
3.0+ is broken or altered

Worked: (newest version of Blender that worked as expected)
2.9- old function works

Caused by 594656e7a3

Short description of error
Custom bone shape disappears if going to editmode on the custom shape object

Exact steps for others to reproduce the error
#94886.blend

open file
go to editmode on the Circle object
bone disappears

Original Report

note that the original file may crash on load due to #94726 (Segfault with GPU subdivision on a custom bone shape)

Short description of error

After I add a circle object to a shoulder bone, I'm going into edit mode for the circle object so that I can edit the custom bone shape.

But the custom bone shape disappears.

All of the other bones remain it's just when I go into edit mode for the object that the bone uses for its custom shape. Before 3.0 you could see both the bone and the custom shape you were using so that you could easily edit the object to position the bone in real-time. This seems to be broken now or possibly altered? Seems more like a bug since the only solution I've found on blenderartist is to use the navigation panel in the bone tab under the viewport display. This makes positioning and editing custom bones extremely tedious as compared to just moving around the custom object in edit mode to place your custom bone.

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

Attach circle as a custom object for the bone, then while in object mode select the circle object. Then enter edit mode for circle object and the custom bone disappears, in my supplied blend file the head, neck, left shoulder, and left arm have these. Under the shapes collection if you go into edit mode for any of the objects the corresponding bone will disappear. (FK bones with edited shapes will be on by default but they live in layer 2 of the skeleton)Rigging LEARNING.blend

**System Information** Operating system: Windows 10 Graphics card: RTX 2070 GAMING OC **Blender Version** Broken: (example: 2.80, edbf15d3c044, master, 2018-11-28, as found on the splash screen) 3.0+ is broken or altered Worked: (newest version of Blender that worked as expected) 2.9- old function works Caused by 594656e7a3 **Short description of error** Custom bone shape disappears if going to editmode on the custom shape object **Exact steps for others to reproduce the error** [#94886.blend](https://archive.blender.org/developer/F12805009/T94886.blend) - open file - go to editmode on the `Circle` object - bone disappears **Original Report** note that the original file may crash on load due to #94726 (Segfault with GPU subdivision on a custom bone shape) **Short description of error** After I add a circle object to a shoulder bone, I'm going into edit mode for the circle object so that I can edit the custom bone shape. ![1.png](https://archive.blender.org/developer/F12804131/1.png) But the custom bone shape disappears. ![2.png](https://archive.blender.org/developer/F12804133/2.png) All of the other bones remain it's just when I go into edit mode for the object that the bone uses for its custom shape. Before 3.0 you could see both the bone and the custom shape you were using so that you could easily edit the object to position the bone in real-time. This seems to be broken now or possibly altered? Seems more like a bug since the only solution I've found on blenderartist is to use the navigation panel in the bone tab under the viewport display. This makes positioning and editing custom bones extremely tedious as compared to just moving around the custom object in edit mode to place your custom bone. ![3.png](https://archive.blender.org/developer/F12804135/3.png) **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). Attach circle as a custom object for the bone, then while in object mode select the circle object. Then enter edit mode for circle object and the custom bone disappears, in my supplied blend file the head, neck, left shoulder, and left arm have these. Under the shapes collection if you go into edit mode for any of the objects the corresponding bone will disappear. (FK bones with edited shapes will be on by default but they live in layer 2 of the skeleton)[Rigging LEARNING.blend](https://archive.blender.org/developer/F12804089/Rigging_LEARNING.blend)

Steven Baar commented

2022-01-13 20:15:52 +01:00

Added subscriber: @Steven-Baar

Philipp Oeser commented

2022-01-14 08:59:17 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-01-14 08:59:17 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-01-14 08:59:17 +01:00

Can confirm, will check

Philipp Oeser commented

2022-01-14 09:50:21 +01:00

Added subscriber: @HooglyBoogly

Philipp Oeser commented

2022-01-14 09:50:21 +01:00

Caused by 594656e7a3

note that the original file may crash on load due to #94726 (Segfault with GPU subdivision on a custom bone shape), but can be reproduced in a much simpler file:
#94886.blend

CC @HooglyBoogly

Caused by 594656e7a3 note that the original file may crash on load due to #94726 (Segfault with GPU subdivision on a custom bone shape), but can be reproduced in a much simpler file: [#94886.blend](https://archive.blender.org/developer/F12805009/T94886.blend) CC @HooglyBoogly

Philipp Oeser changed title from ~~Custom bone object~~ to Custom bone shape disappears if going to editmode on the custom shape object

2022-01-14 09:51:33 +01:00

Hans Goudey commented

2022-01-17 20:57:27 +01:00

Thanks for the report. Unfortunately I don't have a great idea for how to solve this. Like I mentioned in that commit and a07089dcb1, I think the way this bone custom overlay works is quite bad and will necessitate hack after hack to keep things working as expected. Even before that change, the system didn't work with instances, for example.
Converting this to use the existing instancing system should handle all of this complexity automatically. I think the only thing we'd need to add is a "viewport only" flag for instances.
However, I don't foresee myself having the time to do that soon-- I already have plans for more refactoring in other areas.

BKE_object_get_evaluated_mesh just returns null when the object is in edit mode, so the existing code finds no mesh to draw.
The following change makes this work in another hacky way by retrieving the original mesh if there is no evaluated mesh. I don't like the change enough to propose it in a patch, though if someone things this is important enough to add another hack for, I can do that.

diff --git a/source/blender/draw/engines/overlay/overlay_armature.c b/source/blender/draw/engines/overlay/overlay_armature.c
index 6fdf410440d..76576af8edc 100644
--- a/source/blender/draw/engines/overlay/overlay_armature.c
+++ b/source/blender/draw/engines/overlay/overlay_armature.c
@@ -661,6 +661,9 @@ static void drw_shgroup_bone_custom_solid(ArmatureDrawContext *ctx,
    * other data type, but supporting all evaluated geometry components would require a much larger
    * refactor of this area. */
   Mesh *mesh = BKE_object_get_evaluated_mesh(custom);
+  if (mesh == NULL) {
+    mesh = BKE_object_get_original_mesh(custom);
+  }
   if (mesh == NULL) {
     return;
   }
@@ -710,6 +713,9 @@ static void drw_shgroup_bone_custom_wire(ArmatureDrawContext *ctx,
 {
   /* See comments in #drw_shgroup_bone_custom_solid. */
   Mesh *mesh = BKE_object_get_evaluated_mesh_no_subsurf(custom);
+  if (mesh == NULL) {
+    mesh = BKE_object_get_original_mesh(custom);
+  }
   if (mesh == NULL) {
     return;
   }
diff --git a/source/blender/draw/intern/draw_cache.c b/source/blender/draw/intern/draw_cache.c
index 1110658e3b2..ff5832f805e 100644
--- a/source/blender/draw/intern/draw_cache.c
+++ b/source/blender/draw/intern/draw_cache.c
@@ -3471,6 +3471,9 @@ void drw_batch_cache_generate_requested_evaluated_mesh(Object *ob)
                           ((mode == CTX_MODE_EDIT_MESH) && DRW_object_is_in_edit_mode(ob))));
 
   Mesh *mesh = BKE_object_get_evaluated_mesh_no_subsurf(ob);
+  if (mesh == NULL) {
+    mesh = BKE_object_get_original_mesh(ob);
+  }
   DRW_mesh_batch_cache_create_requested(DST.task_graph, ob, mesh, scene, is_paint_mode, use_hide);
 }

Thanks for the report. Unfortunately I don't have a great idea for how to solve this. Like I mentioned in that commit and a07089dcb1, I think the way this bone custom overlay works is quite bad and will necessitate hack after hack to keep things working as expected. Even before that change, the system didn't work with instances, for example. Converting this to use the existing instancing system should handle all of this complexity automatically. I think the only thing we'd need to add is a "viewport only" flag for instances. However, I don't foresee myself having the time to do that soon-- I already have plans for more refactoring in other areas. `BKE_object_get_evaluated_mesh` just returns null when the object is in edit mode, so the existing code finds no mesh to draw. The following change makes this work in another hacky way by retrieving the original mesh if there is no evaluated mesh. I don't like the change enough to propose it in a patch, though if someone things this is important enough to add another hack for, I can do that. ```lines=10 diff --git a/source/blender/draw/engines/overlay/overlay_armature.c b/source/blender/draw/engines/overlay/overlay_armature.c index 6fdf410440d..76576af8edc 100644 --- a/source/blender/draw/engines/overlay/overlay_armature.c +++ b/source/blender/draw/engines/overlay/overlay_armature.c @@ -661,6 +661,9 @@ static void drw_shgroup_bone_custom_solid(ArmatureDrawContext *ctx, * other data type, but supporting all evaluated geometry components would require a much larger * refactor of this area. */ Mesh *mesh = BKE_object_get_evaluated_mesh(custom); + if (mesh == NULL) { + mesh = BKE_object_get_original_mesh(custom); + } if (mesh == NULL) { return; } @@ -710,6 +713,9 @@ static void drw_shgroup_bone_custom_wire(ArmatureDrawContext *ctx, { /* See comments in #drw_shgroup_bone_custom_solid. */ Mesh *mesh = BKE_object_get_evaluated_mesh_no_subsurf(custom); + if (mesh == NULL) { + mesh = BKE_object_get_original_mesh(custom); + } if (mesh == NULL) { return; } diff --git a/source/blender/draw/intern/draw_cache.c b/source/blender/draw/intern/draw_cache.c index 1110658e3b2..ff5832f805e 100644 --- a/source/blender/draw/intern/draw_cache.c +++ b/source/blender/draw/intern/draw_cache.c @@ -3471,6 +3471,9 @@ void drw_batch_cache_generate_requested_evaluated_mesh(Object *ob) ((mode == CTX_MODE_EDIT_MESH) && DRW_object_is_in_edit_mode(ob)))); Mesh *mesh = BKE_object_get_evaluated_mesh_no_subsurf(ob); + if (mesh == NULL) { + mesh = BKE_object_get_original_mesh(ob); + } DRW_mesh_batch_cache_create_requested(DST.task_graph, ob, mesh, scene, is_paint_mode, use_hide); } ```

Philipp Oeser commented

2022-01-17 21:28:45 +01:00

Added subscriber: @dr.sybren

Philipp Oeser commented

2022-01-17 21:28:45 +01:00

@dr.sybren: thoughts?

Hans Goudey commented

2022-01-20 20:27:29 +01:00

Once D13824 is committed, this situation might be a bit better / this might work. I still think using the instancing system would be better though.

Once [D13824](https://archive.blender.org/developer/D13824) is committed, this situation might be a bit better / this might work. I still think using the instancing system would be better though.

Sybren A. Stüvel commented

2022-02-14 11:17:22 +01:00

Before 3.0 you could see both the bone and the custom shape you were using so that you could easily edit the object to position the bone in real-time.

I agree that this is the way to do things, having to go back & forth between different modes just to see what you're doing is quite the regression.

@HooglyBoogly now that D13824 has landed, do you think you could have time to find a nicer-than-the-above-hack solution for this?

> Before 3.0 you could see both the bone and the custom shape you were using so that you could easily edit the object to position the bone in real-time. I agree that this is the way to do things, having to go back & forth between different modes just to see what you're doing is quite the regression. @HooglyBoogly now that [D13824](https://archive.blender.org/developer/D13824) has landed, do you think you could have time to find a nicer-than-the-above-hack solution for this?

Hans Goudey commented

2022-02-15 04:36:06 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Hans Goudey closed this issue

2022-02-15 04:36:06 +01:00

Hans Goudey self-assigned this 2022-02-15 04:36:06 +01:00

Hans Goudey commented

2022-02-15 04:36:06 +01:00

Well, testing this now, the situation described in the report works. (I can go into edit mode on the custom bone shape mesh and see the changes on the bone's custom shape).
I wouldn't be surprised if we end up getting other bug reports relating to this situation. But, like I've said before on these tasks and commits, the way it works is just not ideal and misaligned with the way Blender works in other respects.

Well, testing this now, the situation described in the report works. (I can go into edit mode on the custom bone shape mesh and see the changes on the bone's custom shape). I wouldn't be surprised if we end up getting other bug reports relating to this situation. But, like I've said before on these tasks and commits, the way it works is just not ideal and misaligned with the way Blender works in other respects.

Steven Baar commented

2022-02-15 04:40:08 +01:00

Thank you guys for your hard work!!!

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Custom bone shape disappears if going to editmode on the custom shape object #94886