UI: Excessive cut-off while searching in keymap preferences #95045

New Issue

Garek · 2022-01-19T09:51:43+01:00

Garek commented

2022-01-19 09:51:43 +01:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: AMD Radeon HD 7800 Series ATI Technologies Inc. 4.5.14831 Core Profile Context 21.5.2 27.20.20903.8001

Blender Version
Broken: version: 3.1.0 Alpha, branch: master, commit date: 2022-01-16 23:26, hash: 34d424fd64
Broken: version: 2.50alpha1 (searchbox for input first appeared)
Worked: never

Short description of error
When searching in keymap text name of a category will be cut too much.
It does not happen with add-ons or properties editor search.

Exact steps for others to reproduce the error

Open Keymap in preferences.
Resize window. Notice that category name will be cut off only when it really doesn't have any spare space.
Start searching for anything, for example grease pencil.
Resize window. Now category name will be cut off way too easily, having spare space several times largen than it's full text.
Excessive cutoff2022-01-19 12-55-36.mp4

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: AMD Radeon HD 7800 Series ATI Technologies Inc. 4.5.14831 Core Profile Context 21.5.2 27.20.20903.8001 **Blender Version** Broken: version: 3.1.0 Alpha, branch: master, commit date: 2022-01-16 23:26, hash: `34d424fd64` Broken: version: 2.50alpha1 (searchbox for input first appeared) Worked: never **Short description of error** When searching in keymap text name of a category will be cut too much. It does not happen with add-ons or properties editor search. **Exact steps for others to reproduce the error** 1. Open Keymap in preferences. 2. Resize window. Notice that category name will be cut off only when it really doesn't have any spare space. 3. Start searching for anything, for example `grease pencil`. 4. Resize window. Now category name will be cut off way too easily, having spare space several times largen than it's full text. [Excessive cutoff2022-01-19 12-55-36.mp4](https://archive.blender.org/developer/F12811185/Excessive_cutoff2022-01-19_12-55-36.mp4)

Garek commented

2022-01-19 09:51:43 +01:00

Added subscriber: @Garek

Yevgeny Makarov commented

2022-01-19 16:04:34 +01:00

Added subscriber: @jenkm

Yevgeny Makarov commented

2022-01-19 16:04:34 +01:00

--- rna_keymap_ui.py
+++ rna_keymap_ui.py
@@ -340,27 +340,27 @@
         layout.context_pointer_set("keymap", km)
 
         filtered_items = [kmi for kmi in km.keymap_items if filter_func(kmi)]
 
         if filtered_items:
             col = layout.column()
 
             row = col.row()
             row.label(text=km.name, icon='DOT')
 
-            row.label()
-            row.label()
+            subrow = row.row()
+            subrow.alignment = 'RIGHT'
 
             if km.is_user_modified:
-                row.operator("preferences.keymap_restore", text="Restore")
+                subrow.operator("preferences.keymap_restore", text="Restore")
             else:
-                row.label()
+                subrow.label()
 
             for kmi in filtered_items:
                 draw_kmi(display_keymaps, kc, km, kmi, col, 1)
     return True
 
 
 def draw_hierarchy(display_keymaps, layout):
     from bl_keymap_utils import keymap_hierarchy
     for entry in keymap_hierarchy.generate():
         draw_entry(display_keymaps, entry, layout)

``` --- rna_keymap_ui.py +++ rna_keymap_ui.py @@ -340,27 +340,27 @@ layout.context_pointer_set("keymap", km) filtered_items = [kmi for kmi in km.keymap_items if filter_func(kmi)] if filtered_items: col = layout.column() row = col.row() row.label(text=km.name, icon='DOT') - row.label() - row.label() + subrow = row.row() + subrow.alignment = 'RIGHT' if km.is_user_modified: - row.operator("preferences.keymap_restore", text="Restore") + subrow.operator("preferences.keymap_restore", text="Restore") else: - row.label() + subrow.label() for kmi in filtered_items: draw_kmi(display_keymaps, kc, km, kmi, col, 1) return True def draw_hierarchy(display_keymaps, layout): from bl_keymap_utils import keymap_hierarchy for entry in keymap_hierarchy.generate(): draw_entry(display_keymaps, entry, layout) ```

Garek commented

2022-01-19 17:09:14 +01:00

@jenkm I tried to modify this file according to your suggestion but it gives me no keymap interface.

This might be because I didn't build Blender and just directly edited this file with MSVC and Blender text editor but I assumed that with python you don't necessary need to compile Blender.

@jenkm I tried to modify this file according to your suggestion but it gives me no keymap interface. ![image.png](https://archive.blender.org/developer/F12811653/image.png) This might be because I didn't build Blender and just directly edited this file with MSVC and Blender text editor but I assumed that with python you don't necessary need to compile Blender.

Garek commented

2022-01-19 17:25:01 +01:00

@jenkm actually there was problem when I copy-paste it. When I did it properly it worked and issue is gone, thanks, sorry for the noise. All that is left is making it through review...

Richard Antalik commented

2022-01-19 19:37:15 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

UI: Excessive cut-off while searching in keymap preferences #95045