Texture margin generation Adjacent faces - border lookup fails in some directions around 45 degrees. #95249

New Issue

Martijn Versteegh · 2022-01-27T13:05:59+01:00

Martijn Versteegh commented

2022-01-27 13:05:59 +01:00

Broken version: Blender 3.1 alpha 60bd6804db
Last Working Version: This is new code which wasn't available in previous versions.

When having multiple adjacent UV edges with angles between ~30 and ~60 degrees next to each other, some parts of the generated margin are not copied from th correct face. Also the outer edge of the margin is very jagged.

patch:
https://developer.blender.org/D13935

steps to reproduce.

Setup a material on the default cube with a noise texture on the base color and an unconnected empty image texture to bake to, Select the image texture.
Subdivide the cube (simple subdivision) so it has at least 16 squares on each side.
Go to the UV workspace.
Go to editmode.
Select all and rotate the UV mesh ~45 degrees.
Go to cycles -> baking and bake diffuse color with Adjacent faces as margin algorithm and a large margin ( > 16 pixels makes the effect more obvious)

Broken version: Blender 3.1 alpha 60bd6804dbd87b5f1907f208394b69610941fd1b Last Working Version: This is new code which wasn't available in previous versions. When having multiple adjacent UV edges with angles between ~30 and ~60 degrees next to each other, some parts of the generated margin are not copied from th correct face. Also the outer edge of the margin is very jagged. patch: https://developer.blender.org/D13935 steps to reproduce. - Setup a material on the default cube with a noise texture on the base color and an unconnected empty image texture to bake to, Select the image texture. - Subdivide the cube (simple subdivision) so it has at least 16 squares on each side. - Go to the UV workspace. - Go to editmode. - Select all and rotate the UV mesh ~45 degrees. - Go to cycles -> baking and bake diffuse color with Adjacent faces as margin algorithm and a large margin ( > 16 pixels makes the effect more obvious)

Martijn Versteegh commented

2022-01-27 13:05:59 +01:00

Added subscriber: @Baardaap

Martijn Versteegh self-assigned this 2022-01-27 13:06:27 +01:00

Martijn Versteegh commented

2022-01-27 13:06:27 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Bastien Montagne commented

2022-01-27 16:22:38 +01:00

Added subscriber: @mont29

Bastien Montagne commented

2022-01-27 16:22:38 +01:00

Changed status from 'Confirmed' to: 'Needs User Info'

Bastien Montagne commented

2022-01-27 16:22:38 +01:00

This report does not contain all the requested information, which is required for us to investigate the issue.

Please submit a new report and carefully follow the instructions. Be sure to provide system information, Blender version, the last Blender version which worked, and a .blend file with exact steps to reproduce the problem.

A guideline for making a good bug report can be found at https://wiki.blender.org/wiki/Process/Bug_Reports

This report does not contain all the requested information, which is required for us to investigate the issue. Please submit a new report and carefully follow the instructions. Be sure to provide system information, Blender version, the last Blender version which worked, and a .blend file with exact steps to reproduce the problem. A guideline for making a good bug report can be found at https://wiki.blender.org/wiki/Process/Bug_Reports

Martijn Versteegh commented

2022-01-27 23:14:14 +01:00

@mont29 Is there another way I should create a task for myself than report a bug and claim it myself? I don't see a 'create task ' option in Maniphest...

Martijn Versteegh commented

2022-01-27 23:14:55 +01:00

added patch
https://developer.blender.org/D13935

added patch https://developer.blender.org/D13935

Hans Goudey commented

2022-01-27 23:30:30 +01:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2022-01-27 23:30:32 +01:00

Removed subscriber: @HooglyBoogly

Bastien Montagne commented

2022-01-28 08:32:29 +01:00

@Baardaap Ah sorry, did not realize that this was a task for a patch you were working on yourself. But even then, adding a decent amount of info (reproducible steps and file, proper module tags, and so on) is still a better idea, one-liner tasks do not help anybody else to understand what is going on here.

Martijn Versteegh commented

2022-01-28 09:03:12 +01:00

@mont29 Is there a way I can mark a task as ' for myself'? I really only created the task to have it show up on the list of pre-3.1 things. The explanation of what it's about is written up a lot more clear on the associated diff. It feels a bit like busy-work to recreate all than info over here?

The whole creation of these tasks was probably overkill. But that's because with my sleepy head I had read the schedule as bcon4 on feb 2 instead of march 2. :-D

Had I read it correctly I wouldn't even have bothered to create the tasks. Or probably only created them in the same moment as uploading the diffs.

@mont29 Is there a way I can mark a task as ' for myself'? I really only created the task to have it show up on the list of pre-3.1 things. The explanation of what it's about is written up a lot more clear on the associated diff. It feels a bit like busy-work to recreate all than info over here? The whole creation of these tasks was probably overkill. But that's because with my sleepy head I had read the schedule as bcon4 on feb 2 instead of march 2. :-D Had I read it correctly I wouldn't even have bothered to create the tasks. Or probably only created them in the same moment as uploading the diffs.

Bastien Montagne commented

2022-01-28 09:32:28 +01:00

This is generally not a good idea to 'just' have place-holder tasks like that. Either create a proper complete report, or just only do the diff (but would always recommend to have a proper report with all required info).

In any case, assigning yourself to the task is the proper thing to do - but regular users also do that quite often by mistake or otherwise, so when triaging this is not a reliable info unless the triager actually knows the person who did the report is a dev. Would suggest to at least leave a comment (or note in the task itself) making it clear you are on top of it then.

This is generally not a good idea to 'just' have place-holder tasks like that. Either create a proper complete report, or just only do the diff (but would always recommend to have a proper report with all required info). In any case, assigning yourself to the task is the proper thing to do - but regular users also do that quite often by mistake or otherwise, so when triaging this is not a reliable info unless the triager actually knows the person who did the report is a dev. Would suggest to at least leave a comment (or note in the task itself) making it clear you are on top of it then.

Philipp Oeser commented

2022-01-28 09:46:06 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-01-28 09:46:06 +01:00

In #95249#1296768, @mont29 wrote:
This is generally not a good idea to 'just' have place-holder tasks like that. Either create a proper complete report, or just only do the diff (but would always recommend to have a proper report with all required info).

In any case, assigning yourself to the task is the proper thing to do - but regular users also do that quite often by mistake or otherwise, so when triaging this is not a reliable info unless the triager actually knows the person who did the report is a dev. Would suggest to at least leave a comment (or note in the task itself) making it clear you are on top of it then.

Same as #95250 (Texture border generation. Adjacent faces uses stale UV map when in edit mode.)

> In #95249#1296768, @mont29 wrote: > This is generally not a good idea to 'just' have place-holder tasks like that. Either create a proper complete report, or just only do the diff (but would always recommend to have a proper report with all required info). > > In any case, assigning yourself to the task is the proper thing to do - but regular users also do that quite often by mistake or otherwise, so when triaging this is not a reliable info unless the triager actually knows the person who did the report is a dev. Would suggest to at least leave a comment (or note in the task itself) making it clear you are on top of it then. Same as #95250 (Texture border generation. Adjacent faces uses stale UV map when in edit mode.)

Martijn Versteegh commented

2022-01-28 10:23:29 +01:00

Ok. I'll try to flesh out the reports a bit more this evening.

Would suggest to at least leave a comment (or note in the task itself) making it clear you are on top of it then.

Will do!

Ok. I'll try to flesh out the reports a bit more this evening. > Would suggest to at least leave a comment (or note in the task itself) making it clear you are on top of it then. Will do!

Martijn Versteegh commented

2022-01-28 19:56:37 +01:00

Changed status from 'Needs User Info' to: 'Confirmed'