Node link drag search in shader editor doesn't filter by render engine compatibility #96187

Open
opened 2022-03-05 23:05:44 +01:00 by Leon Schittek · 6 comments
Member

System Information
Operating system: macOS-11.6.2-x86_64-i386-64bit 64 Bits
Graphics card: Intel Iris OpenGL Engine Intel Inc. 4.1 INTEL-16.5.7

Blender Version
Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-03-04 16:11, hash: 295d5c6ef5
Worked: I don't think ever. The feature was introduced in 3.1: 11be151d58

Short description of error
Other than the default node search menu ( {nav Add > Search...} ) the link drag search doesn't filter out nodes that are not compatible with the current render engine.

node-link-drag-search-bug.mp4

Exact steps for others to reproduce the error
As shown in the video:

  • open the default blend scene with factory settings
  • switch to the shader editor
  • add a Value or RGB node
  • drag from the node's output and release the link on the canvas to activate the link drag search
  • look for the "Toon BSDF"
    Result: inputs from the node appear in the search despite the node not being supported by Eevee.

Here's the simple setup from the video.
node-drag-link-search-bug.blend

**System Information** Operating system: macOS-11.6.2-x86_64-i386-64bit 64 Bits Graphics card: Intel Iris OpenGL Engine Intel Inc. 4.1 INTEL-16.5.7 **Blender Version** Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-03-04 16:11, hash: `295d5c6ef5` Worked: I don't think ever. The feature was introduced in 3.1: 11be151d58 **Short description of error** Other than the default node search menu ( {nav Add > Search...} ) the link drag search doesn't filter out nodes that are not compatible with the current render engine. [node-link-drag-search-bug.mp4](https://archive.blender.org/developer/F12898655/node-link-drag-search-bug.mp4) **Exact steps for others to reproduce the error** As shown in the video: - open the default blend scene with factory settings - switch to the shader editor - add a *Value* or *RGB* node - drag from the node's output and release the link on the canvas to activate the link drag search - look for the "Toon BSDF" Result: inputs from the node appear in the search despite the node not being supported by Eevee. Here's the simple setup from the video. [node-drag-link-search-bug.blend](https://archive.blender.org/developer/F12898657/node-drag-link-search-bug.blend)
Author
Member

Added subscriber: @lone_noel

Added subscriber: @lone_noel
Leon Schittek changed title from Node link drag doesn't filter by render engine compatibility to Node link drag search in shader editor doesn't filter by render engine compatibility 2022-03-05 23:25:06 +01:00

Added subscriber: @Ethan-Hall

Added subscriber: @Ethan-Hall

I looked into this a little.

I think the only place that the rendering compatibility is defined is in the python file: nodeitems_builtins

I think that the link drag search filtering is done in C++. Commit Node Editor: Link Drag Search Menu

If I haven't overlooked something, then a decision needs to be made about how to best resolve this before the feature can be implemented.

I looked into this a little. I think the only place that the rendering compatibility is defined is in the python file: [nodeitems_builtins](https://developer.blender.org/diffusion/B/browse/master/release/scripts/startup/nodeitems_builtins.py$363) I think that the link drag search filtering is done in C++. [Commit Node Editor: Link Drag Search Menu](https://developer.blender.org/rB11be151d58ec0ca955f019b0eed738e3245110b8) If I haven't overlooked something, then a decision needs to be made about how to best resolve this before the feature can be implemented.
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

We also have #94815 (Drag to add node search prioritizes wrong node type)

We also have #94815 (Drag to add node search prioritizes wrong node type)
Philipp Oeser removed the
Interest
Nodes & Physics
label 2023-02-10 08:44:07 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#96187
No description provided.