Crashes with Intel GPUs - GPU shader compilation fails #96678

New Issue

Stefan Werner · 2022-03-21T14:54:38+01:00

Stefan Werner commented

2022-03-21 14:54:38 +01:00

System Information
Operating system: Windows 10
Graphics card: Intel i-9 12900K iGPU

Blender Version
Broken: 374cb32d4a
Worked: 2580869901

Short description of error
GLSL shader compilation fails with error message:

ERROR (gpu.shader): subdiv patch evaluation ComputeShader:
      |
    6 | #define OS_WIN
      |                                                                                                                                                                                                             ^
      | Error: 'array' : failed to expand macro

And then crash:

Error   : EXCEPTION_ACCESS_VIOLATION
Address : 0x00007FF6BFF0DABB
Module  : blender.exe
Thread  : 00004dbc
Writing: C:\Users\stefanwe\AppData\Local\Temp\cyclesx_classroom.crash.txt`

Exact steps for others to reproduce the error
Open Blender
Load classroom scene

**System Information** Operating system: Windows 10 Graphics card: Intel i-9 12900K iGPU **Blender Version** Broken: 374cb32d4a43b5f959f7fbd96074cfae5f265dab Worked: 2580869901f20d6563c633906245a59377322321 **Short description of error** GLSL shader compilation fails with error message: ``` ERROR (gpu.shader): subdiv patch evaluation ComputeShader: | 6 | #define OS_WIN | ^ | Error: 'array' : failed to expand macro ``` And then crash: ``` Error : EXCEPTION_ACCESS_VIOLATION Address : 0x00007FF6BFF0DABB Module : blender.exe Thread : 00004dbc Writing: C:\Users\stefanwe\AppData\Local\Temp\cyclesx_classroom.crash.txt` ``` **Exact steps for others to reproduce the error** Open Blender Load classroom scene

Stefan Werner commented

2022-03-21 14:54:38 +01:00

Added subscriber: @Stefan_Werner

Nikita Sirgienko commented

2022-03-21 14:57:07 +01:00

Added subscriber: @Sirgienko

Germano Cavalcante commented

2022-03-21 23:53:11 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2022-03-21 23:53:11 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Germano Cavalcante commented

2022-03-21 23:53:11 +01:00

Thanks for the report,

I suggest you use Help -> Report a Bug in Blender so there is complete information about the Blender version and graphics cards.
("Graphics card: Intel i-9 12900K iGPU" is not the information we would expect).

But this hardware is recent and should be supported.

Since there is an error message (and it appears to be related to 374cb32), I believe the report is valid and deserves to be forwarded to the #eevee_viewport team.

Thanks for the report, I suggest you use `Help -> Report a Bug` in Blender so there is complete information about the Blender version and graphics cards. (`"Graphics card: Intel i-9 12900K iGPU"` is not the information we would expect). But this hardware is recent and should be supported. Since there is an error message (and it appears to be related to 374cb32), I believe the report is valid and deserves to be forwarded to the #eevee_viewport team.

Anton Raves commented

2022-03-23 07:27:39 +01:00

Added subscriber: @Memento

Stefan Werner commented

2022-03-23 11:01:01 +01:00

system-info.txt

[system-info.txt](https://archive.blender.org/developer/F12940989/system-info.txt)

Stefan Werner commented

2022-04-08 11:15:02 +02:00

This should be addressed for the 3.2 release, otherwise the 3.2 release will crash on some machines with Intel graphics. (Blender dereferencing a NULL pointer from a failed shader compilation)

Germano Cavalcante commented

2022-04-08 17:23:28 +02:00

Looking at the code, all compute shaders have an array macro defined by default. See "#define array(_type) _type- [ ]\n" in {https://developer.blender.org/diffusion/B/browse/master/source/blender/gpu/opengl/gl_shader.cc$843}

And the shader named "subdiv patch evaluation" has some apparent "array" tokens in:
{https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl$251}
{https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl$254}
{https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl$260}
{https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl$276}
{https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl$282}

So... maybe if we undefine the macro array in the compute shader the problem is solved???

diff --git a/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl b/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl
index 65cf4ebb90f..e261e983113 100644
--- a/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl
+++ b/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl
@@ -1,3 +1,4 @@
+#undef array
 
 /* To be compiled with common_subdiv_lib.glsl */

Looking at the code, all compute shaders have an `array` macro defined by default. See `"#define array(_type) _type- [ ]\n"` in {https://developer.blender.org/diffusion/B/browse/master/source/blender/gpu/opengl/gl_shader.cc$843} And the shader named `"subdiv patch evaluation"` has some apparent "array" tokens in: {https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl$251} {https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl$254} {https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl$260} {https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl$276} {https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl$282} So... maybe if we undefine the macro `array` in the compute shader the problem is solved??? ``` diff --git a/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl b/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl index 65cf4ebb90f..e261e983113 100644 --- a/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl +++ b/source/blender/draw/intern/shaders/common_subdiv_patch_evaluation_comp.glsl @@ -1,3 +1,4 @@ +#undef array /* To be compiled with common_subdiv_lib.glsl */ ```

Pratik Borhade commented

2022-04-19 18:09:25 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-04-19 18:09:25 +02:00

Hi @Stefan_Werner, I'm also getting similar OpenGL error.
I've not loaded classroom scene on my system. But can you check if crash still occurs after turning Off the GPU subdivision?
Also check if you can reproduce crash as mentioned in #97449 (GPU subdivision: Crash on adding subdivision surface modifier)
I suspect both reports are identical :)

Hi @Stefan_Werner, I'm also getting similar OpenGL error. I've not loaded classroom scene on my system. But can you check if crash still occurs after turning Off the GPU subdivision? Also check if you can reproduce crash as mentioned in #97449 (GPU subdivision: Crash on adding subdivision surface modifier) I suspect both reports are identical :)

Clément Foucault commented

2022-04-20 14:42:58 +02:00

Closed as duplicate of #97449

Clément Foucault closed this issue

2022-04-20 14:42:58 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crashes with Intel GPUs - GPU shader compilation fails #96678