Edit mode normalize fails to respect locked groups #96787

New Issue

Daniel Salazar · 2022-03-25T23:07:51+01:00

Daniel Salazar commented

2022-03-25 23:07:51 +01:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.15

Blender Version
Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-03-24 00:35, hash: 98d4872d7f

Short description of error
This bug relates to object.vertex_weight_normalize_active_vertex()

As the tooltip says, normalization should completely ignore locked groups

Exact steps for others to reproduce the error
Normalize.blend

Check the L and R groups, these are locked groups. The L group looks like this:

Now hit the Normalize operator. The result is the L group looking like this:

Video overview
Normalize.mp4

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.15 **Blender Version** Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-03-24 00:35, hash: `98d4872d7f` **Short description of error** This bug relates to object.vertex_weight_normalize_active_vertex() As the tooltip says, normalization should completely ignore locked groups ![image.png](https://archive.blender.org/developer/F12946924/image.png) **Exact steps for others to reproduce the error** [Normalize.blend](https://archive.blender.org/developer/F12946912/Normalize.blend) Check the L and R groups, these are locked groups. The *L* group looks like this: ![image.png](https://archive.blender.org/developer/F12946936/image.png) Now hit the *Normalize* operator. The result is the *L* group looking like this: ![image.png](https://archive.blender.org/developer/F12946942/image.png) Video overview [Normalize.mp4](https://archive.blender.org/developer/F13061923/Normalize.mp4)

Daniel Salazar commented

2022-03-25 23:07:51 +01:00

Added subscriber: @zanqdo

Pratik Borhade commented

2022-03-26 11:46:53 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-03-26 11:46:57 +01:00

Added subscriber: @PratikPB2123

Ethan-Hall commented

2022-03-26 23:04:00 +01:00

Added subscriber: @Ethan-Hall

Ethan-Hall commented

2022-03-26 23:04:00 +01:00

First off normalization should only be applied to deforming bones. This is why the Normalize operator is only available when choosing the Deform listing options from the menu

This is not true.
The operator is only available when choosing the 'Deform' in your example since the set 'All' and 'Other' contain locked groups.

>First off normalization should only be applied to deforming bones. This is why the Normalize operator is only available when choosing the Deform listing options from the menu This is not true. The operator is only available when choosing the 'Deform' in your example since the set 'All' and 'Other' contain locked groups. ![image.png](https://archive.blender.org/developer/F12948572/image.png)

Daniel Salazar commented

2022-03-26 23:11:35 +01:00

You're right, it's only disabled if at least one of the groups is locked. Which is also wrong.

Ethan-Hall commented

2022-03-26 23:16:07 +01:00

This comment was removed by @Ethan-Hall

*This comment was removed by @Ethan-Hall*

Daniel Salazar commented

2022-03-26 23:19:58 +01:00

In #96787#1330492, @Ethan-Hall wrote:
I think the problem is that the 'Normalize' and 'Copy' are not disabled properly. They should not depend on the filter setting since they do not respect the filter setting.

The problem is, normalization on all groups even if they are non-deforming is absolutely wrong and destructive. Also, normalizing should respect locked groups, otherwise it's simply not following the normalization workflow design.

> In #96787#1330492, @Ethan-Hall wrote: > I think the problem is that the 'Normalize' and 'Copy' are not disabled properly. They should not depend on the filter setting since they do not respect the filter setting. The problem is, normalization on all groups even if they are non-deforming is absolutely wrong and destructive. Also, normalizing should respect locked groups, otherwise it's simply not following the normalization workflow design.

Ethan-Hall commented

2022-03-26 23:25:07 +01:00

In #96787#1330494, @zanqdo wrote:

In #96787#1330492, @Ethan-Hall wrote:
I think the problem is that the 'Normalize' and 'Copy' are not disabled properly. They should not depend on the filter setting since they do not respect the filter setting.

The problem is, normalization on all groups even if they are non-deforming is absolutely wrong and destructive. Also, normalizing should respect locked groups, otherwise it's simply not following the normalization workflow design.

You are right It should. I just checked and 'Normalize All' in the weight paint menu allows the user to filter for deform pose bones.

> In #96787#1330494, @zanqdo wrote: >> In #96787#1330492, @Ethan-Hall wrote: >> I think the problem is that the 'Normalize' and 'Copy' are not disabled properly. They should not depend on the filter setting since they do not respect the filter setting. > > The problem is, normalization on all groups even if they are non-deforming is absolutely wrong and destructive. Also, normalizing should respect locked groups, otherwise it's simply not following the normalization workflow design. You are right It should. I just checked and 'Normalize All' in the weight paint menu allows the user to filter for deform pose bones.

Ethan-Hall commented

2022-03-26 23:27:32 +01:00

From a UI perspective, the normalize and copy buttons should be attached to indicate that they respect the filter setting.

Brad Clark commented

2022-03-28 07:33:17 +02:00

Added subscriber: @BClark

Nate Rupsis commented

2022-05-11 18:33:13 +02:00

Added subscriber: @nrupsis

Nate Rupsis self-assigned this 2022-05-20 23:23:14 +02:00

Jer Bot commented

2022-07-08 07:05:02 +02:00

Added subscriber: @JerBot

Daniel Salazar commented

2022-07-24 21:55:56 +02:00

Added subscriber: @ideasman42

Daniel Salazar commented

2022-07-24 21:55:57 +02:00

Calling @ideasman42 as discussed in the meeting to see if he can give us a hand with this!

Campbell Barton commented

2022-07-28 04:54:47 +02:00

Replied to D15317.

Replied to [D15317](https://archive.blender.org/developer/D15317).

Daniel Salazar changed title from ~~Edit mode normalize fails to respect non deforming groups or locked groups~~ to Edit mode normalize fails to respect locked groups

2022-08-04 00:45:13 +02:00

Daniel Salazar commented

2022-08-04 00:51:51 +02:00

Separated the non deforming groups problem into a new task #100187