Bad offsets when dragging same object from asset browser multiple times, mixing Link and Append options #97320

New Issue

Bastien Montagne · 2022-04-14T10:00:05+02:00

Bastien Montagne commented

2022-04-14 10:00:05 +02:00

Affects current master (4fa3eadce9).

Drag (Link) an object from the asset browser into the 3DView.
Drag (Append (Re-use Data)) the same object, see how the linked object is moved to the same position as the last dragged one.

Frag (Append) the same object, see how each newly dragged object seems to be offset further away from its dropped (expected final) location.

Not exactly sure what is happening here, but looks like setting the location of the dragged objects is doing fairly bad things...

Affects current master (4fa3eadce9). - Drag (Link) an object from the asset browser into the 3DView. - Drag (Append (Re-use Data)) the same object, see how the linked object is moved to the same position as the last dragged one. # Frag (Append) the same object, see how each newly dragged object seems to be offset further away from its dropped (expected final) location. Not exactly sure what is happening here, but looks like setting the location of the dragged objects is doing fairly bad things...

Julian Eisel was assigned by Bastien Montagne

2022-04-14 10:00:05 +02:00

Bastien Montagne commented

2022-04-14 10:00:05 +02:00

Added subscriber: @mont29

Philipp Oeser commented

2022-04-14 10:17:10 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-04-14 10:17:10 +02:00

Following the policy "bug in recent feature = high prio" (feel free to lower again)

Philipp Oeser commented

2022-04-14 10:39:38 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Bastien Montagne changed title from ~~Bad offsets when dragging same object from asset browser multiple times, nixing Link and Append options~~ to Bad offsets when dragging same object from asset browser multiple times, mixing Link and Append options

2022-05-05 08:56:14 +02:00

blender-admin commented

2022-05-23 20:00:33 +02:00

This issue was referenced by 02c5ca2f22

This issue was referenced by 02c5ca2f2269b44cc56438847c55b8139a1c8dd2

blender-admin commented

2022-05-23 20:00:33 +02:00

This issue was referenced by 917c096be6

This issue was referenced by 917c096be6b93ce5ad1eb284d344da10000ab896

Julian Eisel commented

2022-05-23 20:12:08 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Julian Eisel closed this issue

2022-05-23 20:12:08 +02:00

Julian Eisel commented

2022-05-23 21:09:05 +02:00

Changed status from 'Resolved' to: 'Confirmed'

Julian Eisel reopened this issue

2022-05-23 21:09:05 +02:00

Julian Eisel commented

2022-05-23 21:09:05 +02:00

Common Phabricator, I said "partially fixes"... Reopening.

I was hoping 917c096be6 would be enough to fix this, and indeed the offsets are gone. However the newly appended objects aren't placed under the cursor as they should be. For some reason the dropping still uses the linked instance of the ID, so the operator doesn't transform the object: https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/object/object_add.cc$3986-3990
So I guess WM_drag_get_local_ID_or_import_from_asset() returns the wrong ID.

Common Phabricator, I said "partially fixes"... Reopening. I was hoping 917c096be6 would be enough to fix this, and indeed the offsets are gone. However the newly appended objects aren't placed under the cursor as they should be. For some reason the dropping still uses the linked instance of the ID, so the operator doesn't transform the object: https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/object/object_add.cc$3986-3990 So I guess `WM_drag_get_local_ID_or_import_from_asset()` returns the wrong ID.

Johannes Kollmer commented

2022-05-24 22:23:58 +02:00

Added subscriber: @Lumpengnom-3

Julian Eisel commented

2022-05-25 11:59:04 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Julian Eisel closed this issue

2022-05-25 11:59:04 +02:00

Julian Eisel commented

2022-05-25 11:59:04 +02:00

Alright! Bastien committed a4e7a5aa4f. With that last fix, it all seems to be working as it should now with regards to toggling between Link, Append and Append (Reuse Data).

Alright! Bastien committed a4e7a5aa4f. With that last fix, it all seems to be working as it should now with regards to toggling between *Link*, *Append* and *Append (Reuse Data)*.

Bastien Montagne added this to the Pipeline, Assets & IO project 2023-02-09 15:40:49 +01:00

Bastien Montagne removed this from the Pipeline, Assets & IO project 2023-02-10 12:49:29 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Bad offsets when dragging same object from asset browser multiple times, mixing Link and Append options #97320

Frag (Append) the same object, see how each newly dragged object seems to be offset further away from its dropped (expected final) location.