EEVEE Viewport Shading crash (3.2.0 Alpha) #97545

New Issue

Peter Green · 2022-04-22T13:01:29+02:00

Peter Green commented

2022-04-22 13:01:29 +02:00

System Information
Operating system: WIN10
Graphics card: Intel HD 4600

Blender Version
Broken: blender-3.2.0-alpha+daily.179100c02126

Short description of error
System crashes when switching to EEVEE Viewport Shading.

Exact steps for others to reproduce the error
Launch Blender, accept the splash screen, click on the Viewport Shading icon, system crashes.

blender_system_info.txt
blender_debug_output.txt

**System Information** Operating system: WIN10 Graphics card: Intel HD 4600 **Blender Version** Broken: blender-3.2.0-alpha+daily.179100c02126 **Short description of error** System crashes when switching to EEVEE Viewport Shading. **Exact steps for others to reproduce the error** Launch Blender, accept the splash screen, click on the Viewport Shading icon, system crashes. [blender_system_info.txt](https://archive.blender.org/developer/F13015815/blender_system_info.txt) [blender_debug_output.txt](https://archive.blender.org/developer/F13015813/blender_debug_output.txt)

Peter Green commented

2022-04-22 13:01:29 +02:00

Added subscriber: @snibber

Thomas Dinges commented

2022-04-22 15:47:54 +02:00

Added subscriber: @ThomasDinges

Thomas Dinges commented

2022-04-22 15:47:54 +02:00

No crash here with 048c769774 and a Radeon RX 5500 XT.

Are you on the latest GPU drivers?

No crash here with 048c769774 and a Radeon RX 5500 XT. Are you on the latest GPU drivers?

Peter Green commented

2022-04-22 16:09:39 +02:00

...latest GPU drivers?

GPU? I wish. I believe I am using the latest drivers for my graphics "card", which alas is only the onboard Intel chip. I do perform regular Windows updates, so I don't think the driver version is to blame, and Blender 3.1.2 is fine, and doesn't crash.

Edit: I installed the Intel Support assistant, which told me my graphics driver was out of date. Long story, short, I installed the new driver. The crash still happens.

>...latest GPU drivers? GPU? I wish. I *believe* I am using the latest drivers for my graphics "card", which alas is only the onboard Intel chip. I do perform regular Windows updates, so I don't think the driver version is to blame, and Blender 3.1.2 is fine, and doesn't crash. Edit: I installed the Intel Support assistant, which told me my graphics driver was out of date. Long story, short, I installed the new driver. The crash still happens.

Philipp Oeser commented

2022-04-25 11:50:06 +02:00

Added subscribers: @Jason-Fielder, @fclem, @lichtwerk

Philipp Oeser commented

2022-04-25 11:50:06 +02:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2022-04-25 11:50:06 +02:00

The Haswell HD 4600 is on the lower end of the spectrum, but should not crash.
From the log:

ERROR (gpu.shader): GPU_material_compile VertShader: 
      | 
   20 | /* Texture format tokens -- Type explictness required by other Graphics APIs. */
      |                                                                                                                                                                                                                                                                                                                                                                                                                                                                         ^
      | Error: '' :  illegal character (") (0x22)
      | Error: '' :  illegal character (") (0x22)

cant really make sense of the error message, maybe something wrong with {7c9e128bbf}?
@fclem, @Jason-Fielder : does this ring a bell?

The Haswell HD 4600 is on the lower end of the spectrum, but should not crash. From the log: ``` ERROR (gpu.shader): GPU_material_compile VertShader: | 20 | /* Texture format tokens -- Type explictness required by other Graphics APIs. */ | ^ | Error: '' : illegal character (") (0x22) | Error: '' : illegal character (") (0x22) ``` cant really make sense of the error message, maybe something wrong with {7c9e128bbf}? @fclem, @Jason-Fielder : does this ring a bell?

Jason Fielder commented

2022-04-25 11:55:19 +02:00

Added subscriber: @Michael-Parkin-White-Apple

Jason Fielder commented

2022-04-25 11:55:19 +02:00

@Michael-Parkin-White-Apple

Michael Parkin-White commented

2022-04-25 13:38:30 +02:00

The main change with this PR was the inclusion of source/blender/gpu/shaders/opengl/glsl_shader_defines.glsl as a common header file to support cross-API functionality translation.

Few possibilities that could be occurring:

Could insertion of the GLSL shader defines file into the patch be causing symbols to be inserted in-line in a way which throws off the intel compiler?

  /* GLSL Backend Lib. */
  STR_CONCAT(patch, slen, datatoc_glsl_shader_defines_glsl);

Or possible problem with windows-compatible line-endings/ascii symbols within the file? Running the file through an ASCII scanner reveals all line endings are CR-LF, all indents are with spaces, and there appear to be no other unexpected characters.
The compile error seems to focus in on the comment /* Texture format tokens -- Type explictness required by other Graphics APIs. */ Is there something about this which the compiler does not like? Perhaps the --?
Given the report here only states that this happens for EEVEE shaders, could the macro's themselves such as #define depth2D sampler2D be causing a problem?

One key difference between platforms could be whether the existing defines in the GLSL shader patch glsl_patch_default_get(..) are affected differently by the injection of the patch. As Intel HD 4600, in this case, may have differing GPU HW feature availability vs the tested macOS platforms and AMD/NVidia platforms.

The main change with this PR was the inclusion of `source/blender/gpu/shaders/opengl/glsl_shader_defines.glsl` as a common header file to support cross-API functionality translation. Few possibilities that could be occurring: - Could insertion of the GLSL shader defines file into the patch be causing symbols to be inserted in-line in a way which throws off the intel compiler? ``` /* GLSL Backend Lib. */ STR_CONCAT(patch, slen, datatoc_glsl_shader_defines_glsl); ``` - Or possible problem with windows-compatible line-endings/ascii symbols within the file? Running the file through an ASCII scanner reveals all line endings are CR-LF, all indents are with spaces, and there appear to be no other unexpected characters. - The compile error seems to focus in on the comment `/* Texture format tokens -- Type explictness required by other Graphics APIs. */` Is there something about this which the compiler does not like? Perhaps the `--`? - Given the report here only states that this happens for EEVEE shaders, could the macro's themselves such as `#define depth2D sampler2D` be causing a problem? One key difference between platforms could be whether the existing defines in the GLSL shader patch `glsl_patch_default_get(..)` are affected differently by the injection of the patch. As Intel HD 4600, in this case, may have differing GPU HW feature availability vs the tested macOS platforms and AMD/NVidia platforms.

Pratik Borhade commented

2022-04-25 13:40:36 +02:00

Added subscriber: @PratikPB2123

Clément Foucault commented

2022-04-27 16:04:00 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Needs User Info'

Clément Foucault commented

2022-04-27 16:04:00 +02:00

We internally diagnosed an issue with fa3bd17ae8 which resembles this one. This has been fixed by 478eb3a0e6 but I would like to know if this is the same issue or not.

We internally diagnosed an issue with fa3bd17ae8 which resembles this one. This has been fixed by 478eb3a0e6 but I would like to know if this is the same issue or not.

Peter Green commented

2022-05-01 13:11:07 +02:00

I'm not sure if this is useful information, but the latest version (blender-3.2.0-alpha+daily.12217714c717) crashes in the same way, but beforethe splash screen appears.

ERROR (gpu.shader): overlay_background VertShader: 
      | 
    8 | #extension GL_ARB_texture_cube_map_array : enable
      |                                                                         ^
      | Error: '' :  illegal character (") (0x22)
      | Error: '' :  illegal character (") (0x22)
      |

I'm not sure if this is useful information, but the latest version (blender-3.2.0-alpha+daily.12217714c717) crashes in the same way, but **before**the splash screen appears. ``` ERROR (gpu.shader): overlay_background VertShader: | 8 | #extension GL_ARB_texture_cube_map_array : enable | ^ | Error: '' : illegal character (") (0x22) | Error: '' : illegal character (") (0x22) | ```

Clément Foucault commented

2022-05-01 14:37:05 +02:00

@snibber this is indeed a useful information.

I have the feeling it is caused by #error preprocessor directive which is followed by a string. I added these to ease the development process.

I'll remove them for release builds.

@snibber this is indeed a useful information. I have the feeling it is caused by `#error` preprocessor directive which is followed by a string. I added these to ease the development process. I'll remove them for release builds.

Clément Foucault commented

2022-05-01 14:37:21 +02:00

Changed status from 'Needs User Info' to: 'Confirmed'

blender-admin commented

2022-05-01 22:42:07 +02:00

This issue was referenced by aa34706aac

This issue was referenced by aa34706aacdab45847d7c0e3987b1de4ff0b8760

Clément Foucault commented

2022-05-01 22:43:52 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Clément Foucault closed this issue

2022-05-01 22:43:52 +02:00

Clément Foucault self-assigned this 2022-05-01 22:43:52 +02:00

Peter Green commented

2022-05-03 10:31:53 +02:00

"For the avoidance of doubt", should this latest commit have made it into the 3.2.0 Beta which is now available (blender-3.2.0-beta+daily.62ef1c08af9a)? I've tried this, and the error is still there. (I was a software engineer for several decades, but I'm too lazy to delve into git and get my head round the branching structure of the Blender project.)

Thomas Dinges commented

2022-05-03 10:35:03 +02:00

Changed status from 'Resolved' to: 'Needs Developer To Reproduce'

Thomas Dinges reopened this issue

2022-05-03 10:35:03 +02:00

Thomas Dinges commented

2022-05-03 10:35:03 +02:00

The branching was done a day later, so the commit is part of Blender 3.2. As the error is still there guess this needs to be re-opened.

Peter Green commented

2022-05-03 10:54:57 +02:00

Sorry to be the bearer of bad news. I've been on the receiving end of many a bug report.

Peter Green commented

2022-05-09 11:44:52 +02:00

I ran blender_debug_gpu.cmd to see if that would shed any light on this issue. It provided slightlymore information (a few INFO and WARN lines), so I attach the debug output here for completeness.

blender_debug_output.txt

I also cloned the repo and dipped my toe into the waters - successfully building a new blender.exe...which crashes in exactly the same way! I guess that's something. But that's as far as my progress along the Blender development learning curve will currently allow me to go. I hope somebody will be able to get to the bottom of this one - I suspect it's a corner-case, and will only affect people with low-end graphics hardware, but I don't want my Blender journey to stop at 3.1.2.

I ran blender_debug_gpu.cmd to see if that would shed any light on this issue. It provided *slightly*more information (a few INFO and WARN lines), so I attach the debug output here for completeness. [blender_debug_output.txt](https://archive.blender.org/developer/F13060555/blender_debug_output.txt) I also cloned the repo and dipped my toe into the waters - successfully building a new blender.exe...which crashes in exactly the same way! I guess that's something. But that's as far as my progress along the Blender development learning curve will currently allow me to go. I hope somebody will be able to get to the bottom of this one - I suspect it's a corner-case, and will only affect people with low-end graphics hardware, but I don't want my Blender journey to stop at 3.1.2.

Clément Foucault commented

2022-05-10 00:05:02 +02:00

I think this is now caused by the C include directives that are in shared headers like in overlay_shader_shared.h. I'll write a patch that will replace all " char with something else for the drivers that needs this. At least we see progress! Thanks @snibber for the blender_debug_output.txt this was really helpful.

I think this is now caused by the C include directives that are in shared headers like in `overlay_shader_shared.h`. I'll write a patch that will replace all `"` char with something else for the drivers that needs this. At least we see progress! Thanks @snibber for the `blender_debug_output.txt` this was really helpful.

blender-admin commented

2022-05-10 00:47:44 +02:00

This issue was referenced by a4c2060b91

This issue was referenced by a4c2060b91467987c930e4dd77a6673acd072ced

Clément Foucault commented

2022-05-10 00:48:02 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'

Clément Foucault closed this issue

2022-05-10 00:48:02 +02:00

Peter Green commented

2022-05-10 10:12:06 +02:00

I've tried the latest 3.2.0 build (a4c2060b91) , and it's a mixed picture. Blender starts OK, I accept the splash screen, but when I then click the Viewport Shading icon, it crashes (log attached).

blender_debug_output.txt

The headlines from this log:

ERROR (gpu.shader): GPU_material_compile VertShader: 
      | 
   17 | #define DFDX_SIGN 1.0
      |                                                                                                                                                                             ^
      | Error: 'assign' : l-value required 
      | Error: 'Error' : constant value cannot be passed for 'inout' parameters. 
      | 
      | #define DFDX_SIGN 1.0
      |                                                                                                                                                                              ^
      | Error: 'assign' : l-value required 
      | Error: 'Error' : constant value cannot be passed for 'inout' parameters.

UPDATE
The very latest build (11aa237858) works! Merci beaucoup.

I've tried the latest 3.2.0 build (a4c2060b9146) , and it's a mixed picture. Blender starts OK, I accept the splash screen, but when I then click the Viewport Shading icon, it crashes (log attached). [blender_debug_output.txt](https://archive.blender.org/developer/F13064407/blender_debug_output.txt) The headlines from this log: ``` ERROR (gpu.shader): GPU_material_compile VertShader: | 17 | #define DFDX_SIGN 1.0 | ^ | Error: 'assign' : l-value required | Error: 'Error' : constant value cannot be passed for 'inout' parameters. | | #define DFDX_SIGN 1.0 | ^ | Error: 'assign' : l-value required | Error: 'Error' : constant value cannot be passed for 'inout' parameters. ``` **UPDATE** The very latest build (11aa237858d4) works! Merci beaucoup.

Clément Foucault commented

2022-05-10 11:29:47 +02:00

Yes this last error was in fact #97545 which has already been solved.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

EEVEE Viewport Shading crash (3.2.0 Alpha) #97545