NLA Action extrapolation display doesn't respond to the extrapolation settings always draws as if it was set to HOLD #97572

Closed
opened 2022-04-23 18:02:23 +02:00 by Brad Clark · 21 comments
Member

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: Quadro RTX 3000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.88

Blender Version
Broken: version: 3.1.2, branch: master, commit date: 2022-03-31 17:40, hash: cc66d1020c
Never worked in previous versions.

Short description of error
The NLA main Action display doesn't change to reflect the setting in Extrapolation list. It always displays as if it was set to HOLD, even when set to Nothing.

Exact steps for others to reproduce the error

  1. Create an object and keyframe it
  2. In the NLA select the Action and in the Sidepanel (N to show it) change extrapolation to Nothing.
  3. Notice the track still is showing orange in both directions as if it was still set to HOLD.
    image.png
**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: Quadro RTX 3000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.88 **Blender Version** Broken: version: 3.1.2, branch: master, commit date: 2022-03-31 17:40, hash: `cc66d1020c` Never worked in previous versions. **Short description of error** The NLA main Action display doesn't change to reflect the setting in Extrapolation list. It always displays as if it was set to HOLD, even when set to Nothing. **Exact steps for others to reproduce the error** 1. Create an object and keyframe it 2. In the NLA select the Action and in the Sidepanel (N to show it) change extrapolation to Nothing. 3. Notice the track still is showing orange in both directions as if it was still set to HOLD. ![image.png](https://archive.blender.org/developer/F13019038/image.png)
Author
Member

Added subscriber: @BClark

Added subscriber: @BClark
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

What does the setting in the Edited Action panel really do?

I think this only has an effect on actions which are ... edited.
Meaning this is only for NLA tweakmode? And actions not yet pushed to the NLA?

Which makes me wonder why we actually diaplay this panel when we are not in tweakmode?
One could argue we need the panel to select an action to be edited, in that case: Extrapolation / Blending / Influence be hidden/disabled when there is no action selected?

What does the setting in the `Edited Action` panel really do? I think this only has an effect on actions which are ... edited. Meaning this is only for NLA tweakmode? And actions not yet pushed to the NLA? Which makes me wonder why we actually diaplay this panel when we are not in tweakmode? One could argue we need the panel to select an action to be edited, in that case: `Extrapolation` / `Blending` / `Influence` be hidden/disabled when there is **no action** selected?
Member

Added subscribers: @cmbasnett, @dr.sybren

Added subscribers: @cmbasnett, @dr.sybren
Member

@cmbasnett, @dr.sybren: what is your understanding of this?
Should we do something like
P2906: T97572_snippet



diff --git a/source/blender/editors/space_nla/nla_buttons.c b/source/blender/editors/space_nla/nla_buttons.c
index 5e4389279eb..0e9560727df 100644
--- a/source/blender/editors/space_nla/nla_buttons.c
+++ b/source/blender/editors/space_nla/nla_buttons.c
@@ -317,16 +317,22 @@ static void nla_panel_animdata(const bContext *C, Panel *panel)
                false,
                NULL);
 
+  PointerRNA act_ptr = RNA_pointer_get(&adt_ptr, "action");
+  const bool has_act = !RNA_pointer_is_null(&act_ptr);
+
   /* extrapolation */
   row = uiLayoutRow(layout, true);
+  uiLayoutSetActive(row, has_act);
   uiItemR(row, &adt_ptr, "action_extrapolation", 0, IFACE_("Extrapolation"), ICON_NONE);
 
   /* blending */
   row = uiLayoutRow(layout, true);
+  uiLayoutSetActive(row, has_act);
   uiItemR(row, &adt_ptr, "action_blend_type", 0, IFACE_("Blending"), ICON_NONE);
 
   /* influence */
   row = uiLayoutRow(layout, true);
+  uiLayoutSetActive(row, has_act);
   uiItemR(row, &adt_ptr, "action_influence", 0, IFACE_("Influence"), ICON_NONE);
 }
 

note: but even for the edited action, the display of hold is wrong (it does have an effect here)
{F13024829 size=full}

@cmbasnett, @dr.sybren: what is your understanding of this? Should we do something like [P2906: T97572_snippet](https://archive.blender.org/developer/P2906.txt) ``` diff --git a/source/blender/editors/space_nla/nla_buttons.c b/source/blender/editors/space_nla/nla_buttons.c index 5e4389279eb..0e9560727df 100644 --- a/source/blender/editors/space_nla/nla_buttons.c +++ b/source/blender/editors/space_nla/nla_buttons.c @@ -317,16 +317,22 @@ static void nla_panel_animdata(const bContext *C, Panel *panel) false, NULL); + PointerRNA act_ptr = RNA_pointer_get(&adt_ptr, "action"); + const bool has_act = !RNA_pointer_is_null(&act_ptr); + /* extrapolation */ row = uiLayoutRow(layout, true); + uiLayoutSetActive(row, has_act); uiItemR(row, &adt_ptr, "action_extrapolation", 0, IFACE_("Extrapolation"), ICON_NONE); /* blending */ row = uiLayoutRow(layout, true); + uiLayoutSetActive(row, has_act); uiItemR(row, &adt_ptr, "action_blend_type", 0, IFACE_("Blending"), ICON_NONE); /* influence */ row = uiLayoutRow(layout, true); + uiLayoutSetActive(row, has_act); uiItemR(row, &adt_ptr, "action_influence", 0, IFACE_("Influence"), ICON_NONE); } ``` note: but even for the edited action, the display of hold is wrong (it does have an effect here) {[F13024829](https://archive.blender.org/developer/F13024829/image.png) size=full}
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Ah, just noticed that the original report was also about the edited action, so yeah, will confirm.

Ah, just noticed that the original report was **also** about the edited action, so yeah, will confirm.
Author
Member

What does the setting in the Edited Action panel really do?

Answer: It controls and sets up what happens WHEN the new action is created with the creation of a keyframe, meaning for an object with no action, I can set it to be combine and set the extrapolation to be nothing and now when the keyframe is created, that action will behave that way...same with influence. This is very important when working in layers, not as obvious when only creating one action but still important.

I think this only has an effect on actions which are ... edited.
Meaning this is only for NLA tweakmode? And actions not yet pushed to the NLA?

Answer: No it effects creation of actions and has nothing to do with tweak mode or after they are pushed.

Which makes me wonder why we actually diaplay this panel when we are not in tweakmode?
One could argue we need the panel to select an action to be edited, in that case: Extrapolation / Blending / Influence be hidden/disabled when there is no action selected?

Answer: The panel should refresh when object/armature is selected, right now for that to happen the user has to click on (either know they need to or do it by accident and discover the panel has information to control how the action is going to be created when keyframes are added.

What does the setting in the Edited Action panel really do? Answer: It controls and sets up what happens WHEN the new action is created with the creation of a keyframe, meaning for an object with no action, I can set it to be combine and set the extrapolation to be nothing and now when the keyframe is created, that action will behave that way...same with influence. This is very important when working in layers, not as obvious when only creating one action but still important. I think this only has an effect on actions which are ... edited. Meaning this is only for NLA tweakmode? And actions not yet pushed to the NLA? Answer: No it effects creation of actions and has nothing to do with tweak mode or after they are pushed. Which makes me wonder why we actually diaplay this panel when we are not in tweakmode? One could argue we need the panel to select an action to be edited, in that case: Extrapolation / Blending / Influence be hidden/disabled when there is no action selected? Answer: The panel should refresh when object/armature is selected, right now for that to happen the user has to click on (either know they need to or do it by accident and discover the panel has information to control how the action is going to be created when keyframes are added.
Member

Thx for clarification @BClark

No it effects creation of actions

the creation of strips you mean?

...the panel has information to control how the action is going to be created when keyframes are added

the creation of strips you mean?

Thx for clarification @BClark > No it effects creation of actions the creation of strips you mean? > ...the panel has information to control how the action is going to be created when keyframes are added the creation of strips you mean?
Author
Member

No, not strips, I mean of the action, before it is pushed to a strip.

Meaning I want to set up what happens when the new action is created, controlling what is going to do when it is created and when I add keyframes.

No, not strips, I mean of the action, before it is pushed to a strip. Meaning I want to set up what happens when the new action is created, controlling what is going to do when it is created and when I add keyframes.
Member

Will need to have another look tomorrow, but the action is already there before pushing down, and actions dont have these properties, it is the strips that do, no?

Will need to have another look tomorrow, but the action is already there before pushing down, and actions dont have these properties, it is the strips that do, no?
Author
Member

image.png

Once an object has had animation or an action created for it (for some reason it doesn't show before then ) the NO ACTION track is what those settings are prepping.

There can and could be better logic around all of this but that ends up being design issues instead of just refresh bugs but it sits very close to both.

So create a cube, key it, push the action down and delete the track, now you can see the NO action track and change /adjust those settings.

As for the Side panel when a key is set and the action is created, the non pushed action is still influenced by the settings that don't show up until you click on the action name, instead of on creation...like they do when an action is pushed.

![image.png](https://archive.blender.org/developer/F13026484/image.png) Once an object has had animation or an action created for it (for some reason it doesn't show before then ) the NO ACTION track is what those settings are prepping. There can and could be better logic around all of this but that ends up being design issues instead of just refresh bugs but it sits very close to both. So create a cube, key it, push the action down and delete the track, now you can see the NO action track and change /adjust those settings. As for the Side panel when a key is set and the action is created, the non pushed action is still influenced by the settings that don't show up until you click on the action name, instead of on creation...like they do when an action is pushed.
Member

OK, so Actions have these extrapolation settings (for the sole purpose of being used when in the NLA before being pushed down), got it
Once they are pushed down, the created strips inherit that property, got it.
The display is as if this would be HOLD, always, this is a bug, got it.

When in tweakmode, the Action being tweaked is actually also the "Edited Action", here though, the settings of the "Edited Action" panel have no effect (and the tweaked strips settings are used -- this might make sense, we should disable the settings in the UI then as well though, this could be added to P2906, do you agree @BClark ?)

OK, so Actions have these extrapolation settings (for the sole purpose of being used when in the NLA before being pushed down), got it Once they are pushed down, the created strips inherit that property, got it. The display is as if this would be HOLD, always, this is a bug, got it. When in tweakmode, the Action being tweaked is actually also the "Edited Action", here though, the settings of the "Edited Action" panel have no effect (and the tweaked strips settings are used -- this might make sense, we should disable the settings in the UI then as well though, this could be added to [P2906](https://archive.blender.org/developer/P2906.txt), do you agree @BClark ?)
Author
Member

Correct, in tweak mode, they don't do anything and could be disabled out like all the other settings in tweak mode (except for some reason fake user isn't? Renaming the action makes sense
image.png Fake user should be defaulted on for new actions shouldn't it?

Correct, in tweak mode, they don't do anything and could be disabled out like all the other settings in tweak mode (except for some reason fake user isn't? Renaming the action makes sense ![image.png](https://archive.blender.org/developer/F13030250/image.png) Fake user should be defaulted on for new actions shouldn't it?
Member

Added subscriber: @nrupsis

Added subscriber: @nrupsis
Author
Member

@lichtwerk so does this just now need someone to fix it or can you turn your snippet into the final patch?

@lichtwerk so does this just now need someone to fix it or can you turn your snippet into the final patch?
Nate Rupsis self-assigned this 2022-05-03 22:25:54 +02:00
Member

In #97572#1351191, @BClark wrote:
@lichtwerk so does this just now need someone to fix it or can you turn your snippet into the final patch?

Think @nrupsis is taking good care of this, P2906 we can handle separately.

> In #97572#1351191, @BClark wrote: > @lichtwerk so does this just now need someone to fix it or can you turn your snippet into the final patch? Think @nrupsis is taking good care of this, [P2906](https://archive.blender.org/developer/P2906.txt) we can handle separately.

This issue was referenced by 2310daed3a

This issue was referenced by 2310daed3a555cf49994524ba44c0be04d2ad8ff
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Member

Fixed as a result of 2310daed3a

Fixed as a result of 2310daed3a
Author
Member

Win!

Win!
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#97572
No description provided.