Crash using image resize operator with edit_image context override #97850

New Issue

Mysteryem · 2022-05-04T14:36:14+02:00

Mysteryem commented

2022-05-04 14:36:14 +02:00

System Information
Operating system: Windows 10

Blender Version
Broken: 2.91.0, 2.93.7, 3.0.0, 3.1.2

2.91.0 is the oldest version I have installed that has the image resize operator, I have not tested other versions in-between.

Short description of error
The bpy.ops.image.resize operator used with edit_image context override crashes Blender.

Expected behaviour
I would expect it to not crash Blender and that it would either:

Raise an error saying that the context is incorrect
or
Perform the resize operation on the image specified in the context override.

Possible cause
I'm a little out of my depth reading the Blender source, but it appears to happen because the resize operator (called 'scale' in image_ops.c) requires a SpaceImage (bpy.types.SpaceImageEditor in the Python API) in context.space_data, but its poll function returns True when context.edit_image is a valid image even if context.space_data is not a valid SpaceImageEditor.

I'm guessing the poll function is currently shared between the image operators that require a SpaceImage and other image operators that do not require a SpaceImage.

Exact steps for others to reproduce the error
In the python console, run:

bpy.ops.image.resize({'edit_image': bpy.data.images.new('test_image', 32, 32)}, size=(16, 16))

Or copy and paste into text editor and run:

import bpy

width = 64
height = 64
name = 'test_image'
# Create a new image
image = bpy.data.images.new(name, width, height)
# Create the context override
context_override = {'edit_image': image}
new_size = (32, 32)

if bpy.ops.image.resize.poll(context_override):
    bpy.ops.image.resize(context_override, size=new_size)

**System Information** Operating system: Windows 10 **Blender Version** Broken: 2.91.0, 2.93.7, 3.0.0, 3.1.2 2.91.0 is the oldest version I have installed that has the image resize operator, I have not tested other versions in-between. **Short description of error** The `bpy.ops.image.resize` operator used with `edit_image` context override crashes Blender. **Expected behaviour** I would expect it to not crash Blender and that it would either: - Raise an error saying that the context is incorrect or - Perform the resize operation on the image specified in the context override. **Possible cause** I'm a little out of my depth reading the Blender source, but it appears to happen because the resize operator (called 'scale' in `image_ops.c`) requires a `SpaceImage` (`bpy.types.SpaceImageEditor` in the Python API) in `context.space_data`, but its `poll` function returns `True` when `context.edit_image` is a valid image even if `context.space_data` is not a valid `SpaceImageEditor`. I'm guessing the poll function is currently shared between the image operators that require a `SpaceImage` and other image operators that do not require a `SpaceImage`. **Exact steps for others to reproduce the error** In the python console, run: ``` bpy.ops.image.resize({'edit_image': bpy.data.images.new('test_image', 32, 32)}, size=(16, 16)) ``` Or copy and paste into text editor and run: ``` import bpy width = 64 height = 64 name = 'test_image' # Create a new image image = bpy.data.images.new(name, width, height) # Create the context override context_override = {'edit_image': image} new_size = (32, 32) if bpy.ops.image.resize.poll(context_override): bpy.ops.image.resize(context_override, size=new_size) ```

Mysteryem commented

2022-05-04 14:36:14 +02:00

Added subscriber: @Mysteryem-2

Robert Guetzkow commented

2022-05-04 14:49:42 +02:00

Added subscriber: @rjg

Robert Guetzkow commented

2022-05-04 14:49:42 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Robert Guetzkow commented

2022-05-04 14:49:42 +02:00

The poll function could be modified, but image_scale_exec should definitely check if sima is NULL and cancel the operation if that is the case. This is already done for determining is_paint, but obviously needs to be the case whenever the pointer is dereferenced.

The poll function could be modified, but `image_scale_exec` should definitely check if `sima` is `NULL` and cancel the operation if that is the case. This is already done for determining `is_paint`, but obviously needs to be the case whenever the pointer is dereferenced.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash using image resize operator with edit_image context override #97850