VSE: Adjustment Layer create new image #98057

New Issue

hamza.SMA · 2022-05-12T00:18:13+02:00

hamza.SMA commented

2022-05-12 00:18:13 +02:00

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.39

Blender Version
Broken: version: 3.1.2, branch: master, commit date: 2022-03-31 17:40, hash: cc66d1020c
Worked: (newest version of Blender that worked as expected)

Short description of error
Adjustment Layer create new image that is moved and i think maybe many things is affected by the same bug if they use same principal of work
2022-05-11 23-00-34.mp4

(( i notice when we apply for example glow effect to sth it affect all chosen resolution and not the actual size of the image 'scaled or not' so also moving the image make the the effect reapplied more performance issue happen ......))
2022-05-11 23-07-18.mp4
i'm not a programmer but that maybe is due to a temporary image get created every time basic changes like position or others happen
this image has the resolution of output and not the image also the temporary image is fixed and deosn't transforme informations from original image .... maybe my thinking has no sens about how things is working in vse..
ADJUSTMENT LAYER .blend

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.39 **Blender Version** Broken: version: 3.1.2, branch: master, commit date: 2022-03-31 17:40, hash: `cc66d1020c` Worked: (newest version of Blender that worked as expected) **Short description of error** Adjustment Layer create new image that is moved and i think maybe many things is affected by the same bug if they use same principal of work [2022-05-11 23-00-34.mp4](https://archive.blender.org/developer/F13069512/2022-05-11_23-00-34.mp4) (( i notice when we apply for example glow effect to sth it affect all chosen resolution and not the actual size of the image 'scaled or not' so also moving the image make the the effect reapplied more performance issue happen ......)) [2022-05-11 23-07-18.mp4](https://archive.blender.org/developer/F13069527/2022-05-11_23-07-18.mp4) i'm not a programmer but that maybe is due to a temporary image get created every time basic changes like position or others happen this image has the resolution of output and not the image also the temporary image is fixed and deosn't transforme informations from original image .... maybe my thinking has no sens about how things is working in vse.. [ADJUSTMENT LAYER .blend](https://archive.blender.org/developer/F13069541/ADJUSTMENT_LAYER_.blend)

hamza.SMA commented

2022-05-12 00:18:13 +02:00

Added subscriber: @hamza-el-barmaki

Omar Emara commented

2022-05-12 09:29:13 +02:00

Added subscriber: @OmarEmaraDev

Omar Emara commented

2022-05-12 09:29:13 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Omar Emara commented

2022-05-12 09:29:13 +02:00

According to the documentation:

The Adjustment Layer strip works like a regular input file strip except for the fact, that it considers all strips below it as its input.

So you are correct in saying that the adjustment layer create a new image by compositing the strips under it. The newly created image is then considered as a normal imported image which can be used as a strip for processing and editing.
VSE can also skip transformations if they have no effect when rendering strips, so that's why there might be a performance difference.

Is this is the answer you were looking for?

According to the documentation: > The Adjustment Layer strip works like a regular input file strip except for the fact, that it considers all strips below it as its input. So you are correct in saying that the adjustment layer create a new image by compositing the strips under it. The newly created image is then considered as a normal imported image which can be used as a strip for processing and editing. VSE can also skip transformations if they have no effect when rendering strips, so that's why there might be a performance difference. Is this is the answer you were looking for?

hamza.SMA commented

2022-05-12 12:40:39 +02:00

I @OmarEmaraDev
as i now adjustment Layer change values options in strip (sidebar) to all strips below adjustment layer and not create a temporary image ( i 'm not a programmer and don't know how things work in the background but if Adjustment layer create image then the original images must be hidden and sidebar show only options of temporary image in order to play as we like )

I @OmarEmaraDev as i now adjustment Layer change values options in strip (sidebar) to all strips below adjustment layer and not create a temporary image ( i 'm not a programmer and don't know how things work in the background but if Adjustment layer create image then the original images must be hidden and sidebar show only options of temporary image in order to play as we like )

hamza.SMA commented

2022-05-12 12:43:37 +02:00

here a video show effect expected
https://www.youtube.com/watch?v=pIRkDheGsv8 starts 2.15
https://www.youtube.com/watch?v=RJOyzqahDow starts at 1:30

here a video show effect expected https://www.youtube.com/watch?v=pIRkDheGsv8 starts 2.15 https://www.youtube.com/watch?v=RJOyzqahDow starts at 1:30

Omar Emara commented

2022-05-12 12:48:14 +02:00

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Omar Emara commented

2022-05-12 12:48:14 +02:00

Added subscriber: @iss

Omar Emara commented

2022-05-12 12:48:14 +02:00

So the issue is that strips that were rendered into the input of the adjustment strip are still visible, but you expect them to no longer be rendered because they are now represented by the adjustment strip.
Not sure about this behavior, so tagging the module for more information. Maybe @iss can take over this report.

So the issue is that strips that were rendered into the input of the adjustment strip are still visible, but you expect them to no longer be rendered because they are now represented by the adjustment strip. Not sure about this behavior, so tagging the module for more information. Maybe @iss can take over this report.

Omar Emara commented

2022-05-12 12:55:25 +02:00

@hamza-el-barmaki Actually, can't you just change the blend mode of the adjustment strip to be Replace?

hamza.SMA commented

2022-05-12 13:01:25 +02:00

In #98057#1357410, @OmarEmaraDev wrote:
@hamza-el-barmaki Actually, can't you just change the blend mode of the adjustment strip to be Replace?

your right it works thank you very much.... helpful team..

> In #98057#1357410, @OmarEmaraDev wrote: > @hamza-el-barmaki Actually, can't you just change the blend mode of the adjustment strip to be Replace? your right it works thank you very much.... helpful team..

Omar Emara commented

2022-05-12 13:22:44 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Archived'

Omar Emara closed this issue

2022-05-12 13:22:44 +02:00

Omar Emara commented

2022-05-12 13:22:44 +02:00

Good to hear.
Since this have no performance implications and multiple options are given, we can archive this.

Good to hear. Since this have no performance implications and multiple options are given, we can archive this.

tintwotin commented

2022-05-14 07:35:42 +02:00

Added subscribers: @Sergey, @tintwotin

tintwotin commented

2022-05-14 07:35:42 +02:00

Though the issue here can be fixed by changing blend mode, it is very likely other users will encounter the same problem and report it again as a bug. If the ambition of the VSE is that "it should just work", then the default blend mode for Adjustment Layer should probably be Replace.

This problem was introduced when the default blend mode was recently changed for all strips, and the mentioned problem wasn't taken into account. Actually, more strips may be negatively be affected by this change of the default blend mode ex. Multicam strips should properly not be Alpha Over either.

When Blende Mode defaults were changed the specification of Adjustment Layer using Cross as Blend mode was removed - and it shouldn't: https://developer.blender.org/D12952

I would say that this is a regression. IMO, @Sergey or @iss should have a chance to reflect on this report before it is closed. @OmarEmaraDev could you open the report again?

Though the issue here can be fixed by changing blend mode, it is very likely other users will encounter the same problem and report it again as a bug. If the ambition of the VSE is that "it should just work", then the default blend mode for Adjustment Layer should probably be Replace. This problem was introduced when the default blend mode was recently changed for all strips, and the mentioned problem wasn't taken into account. Actually, more strips may be negatively be affected by this change of the default blend mode ex. Multicam strips should properly not be Alpha Over either. When Blende Mode defaults were changed the specification of Adjustment Layer using Cross as Blend mode was removed - and it shouldn't: https://developer.blender.org/D12952 ![image.png](https://archive.blender.org/developer/F13073588/image.png) I would say that this is a regression. IMO, @Sergey or @iss should have a chance to reflect on this report before it is closed. @OmarEmaraDev could you open the report again?

Omar Emara commented

2022-05-14 09:40:54 +02:00

Changed status from 'Archived' to: 'Needs Developer To Reproduce'

Omar Emara reopened this issue

2022-05-14 09:40:54 +02:00

Richard Antalik commented

2022-05-23 22:24:06 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'