Rotation value on preview sequencer view and the value in sidebar don't match #98141

New Issue

hamza.SMA · 2022-05-15T15:15:54+02:00

hamza.SMA commented

2022-05-15 15:15:54 +02:00

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.39

Blender Version
Broken: version: 3.1.2, branch: master, commit date: 2022-03-31 17:40, hash: cc66d1020c
Worked: (newest version of Blender that worked as expected)

Short description of error
when we do rotation in the preview view sequencer by numberpad for eg 90° it is stored as 270° in transform pannel in the sidebar see video .

  to be precise   when we increase rotation on preview  sequencer view  by starting from 0°  the value of the rotation in the sidebar shows that it start from 360° and it is decreasing ....

  also if we start from 0° on preview sequencer view and go negatively  the value of the rotation in the sidebar shows that it start from 0° and go positively ....

  that happen also if we use the numberpad in sequencer view

maybe the issue is orientation of the rotation and there is some modulo math applied when we rotate in the preview more than +360° or -360° so
i don't know is it important to have modulo for the preview? i don't know?
Exact steps for others to reproduce the error
see the video
0001-0500.mp4
also more clear
2022-05-17 00-19-19.mp4

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.39 **Blender Version** Broken: version: 3.1.2, branch: master, commit date: 2022-03-31 17:40, hash: `cc66d1020c` Worked: (newest version of Blender that worked as expected) **Short description of error** when we do rotation in the preview view sequencer by numberpad for eg 90° it is stored as 270° in transform pannel in the sidebar see video . ``` to be precise when we increase rotation on preview sequencer view by starting from 0° the value of the rotation in the sidebar shows that it start from 360° and it is decreasing .... ``` ![1.png](https://archive.blender.org/developer/F13080514/1.png) ``` also if we start from 0° on preview sequencer view and go negatively the value of the rotation in the sidebar shows that it start from 0° and go positively .... ``` ![2.png](https://archive.blender.org/developer/F13080516/2.png) ``` that happen also if we use the numberpad in sequencer view ``` maybe the issue is orientation of the rotation and there is some modulo math applied when we rotate in the preview more than +360° or -360° so i don't know is it important to have modulo for the preview? i don't know? **Exact steps for others to reproduce the error** see the video [0001-0500.mp4](https://archive.blender.org/developer/F13075802/0001-0500.mp4) also more clear [2022-05-17 00-19-19.mp4](https://archive.blender.org/developer/F13080525/2022-05-17_00-19-19.mp4)

hamza.SMA commented

2022-05-15 15:15:54 +02:00

Added subscriber: @hamza-el-barmaki

hamza.SMA changed title from ~~rotation on preview sequencer view don't match to rotation value in the sidebar~~ to Rotation on preview sequencer view don't match to rotation value in the sidebar

2022-05-15 15:17:40 +02:00

hamza.SMA changed title from ~~Rotation on preview sequencer view don't match to rotation value in the sidebar~~ to Rotation value on preview sequencer view and the value in sidebar don't match

2022-05-16 21:22:34 +02:00

Germano Cavalcante commented

2022-05-19 22:04:07 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2022-05-19 22:04:07 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2022-05-19 22:04:08 +02:00

I can confirm.
Although the header and transform values are inverted, maybe they could match a little better.

Here a code I used to test:

diff --git a/source/blender/editors/transform/transform_convert_sequencer_image.c b/source/blender/editors/transform/transform_convert_sequencer_image.c
index cbc2cab0a7a..deae51a1149 100644
--- a/source/blender/editors/transform/transform_convert_sequencer_image.c
+++ b/source/blender/editors/transform/transform_convert_sequencer_image.c
@@ -197,11 +197,7 @@ void recalcData_sequencer_image(TransInfo *t)
 
     /* Rotation. Scaling can cause negative rotation. */
     if (t->mode == TFM_ROTATION) {
-      const float orig_dir[2] = {cosf(tdseq->orig_rotation), sinf(tdseq->orig_rotation)};
-      float rotation = angle_signed_v2v2(handle_x, orig_dir) * mirror[0] * mirror[1];
-      transform->rotation = tdseq->orig_rotation + rotation;
-      transform->rotation += DEG2RAD(360.0);
-      transform->rotation = fmod(transform->rotation, DEG2RAD(360.0));
+      transform->rotation = tdseq->orig_rotation - t->values_final[0];
     }
     SEQ_relations_invalidate_cache_preprocessed(t->scene, seq);
   }
@@ -209,9 +205,6 @@ void recalcData_sequencer_image(TransInfo *t)
 
 void special_aftertrans_update__sequencer_image(bContext *UNUSED(C), TransInfo *t)
 {
-  if (t->state == TRANS_CANCEL) {
-    return;
-  }
 
   TransDataContainer *tc = TRANS_DATA_CONTAINER_FIRST_SINGLE(t);
   TransData *td = NULL;
@@ -225,8 +218,14 @@ void special_aftertrans_update__sequencer_image(bContext *UNUSED(C), TransInfo *
     TransDataSeq *tdseq = td->extra;
     Sequence *seq = tdseq->seq;
     StripTransform *transform = seq->strip->transform;
-    Scene *scene = t->scene;
+    if (t->state == TRANS_CANCEL) {
+      if (t->mode == TFM_ROTATION) {
+        transform->rotation = tdseq->orig_rotation;
+      }
+      continue;
+    }
 
+    Scene *scene = t->scene;
     RNA_pointer_create(&scene->id, &RNA_SequenceTransform, transform, &ptr);
 
     if (t->mode == TFM_ROTATION) {

I can confirm. Although the header and transform values are inverted, maybe they could match a little better. Here a code I used to test: ```lines=15 diff --git a/source/blender/editors/transform/transform_convert_sequencer_image.c b/source/blender/editors/transform/transform_convert_sequencer_image.c index cbc2cab0a7a..deae51a1149 100644 --- a/source/blender/editors/transform/transform_convert_sequencer_image.c +++ b/source/blender/editors/transform/transform_convert_sequencer_image.c @@ -197,11 +197,7 @@ void recalcData_sequencer_image(TransInfo *t) /* Rotation. Scaling can cause negative rotation. */ if (t->mode == TFM_ROTATION) { - const float orig_dir[2] = {cosf(tdseq->orig_rotation), sinf(tdseq->orig_rotation)}; - float rotation = angle_signed_v2v2(handle_x, orig_dir) * mirror[0] * mirror[1]; - transform->rotation = tdseq->orig_rotation + rotation; - transform->rotation += DEG2RAD(360.0); - transform->rotation = fmod(transform->rotation, DEG2RAD(360.0)); + transform->rotation = tdseq->orig_rotation - t->values_final[0]; } SEQ_relations_invalidate_cache_preprocessed(t->scene, seq); } @@ -209,9 +205,6 @@ void recalcData_sequencer_image(TransInfo *t) void special_aftertrans_update__sequencer_image(bContext *UNUSED(C), TransInfo *t) { - if (t->state == TRANS_CANCEL) { - return; - } TransDataContainer *tc = TRANS_DATA_CONTAINER_FIRST_SINGLE(t); TransData *td = NULL; @@ -225,8 +218,14 @@ void special_aftertrans_update__sequencer_image(bContext *UNUSED(C), TransInfo * TransDataSeq *tdseq = td->extra; Sequence *seq = tdseq->seq; StripTransform *transform = seq->strip->transform; - Scene *scene = t->scene; + if (t->state == TRANS_CANCEL) { + if (t->mode == TFM_ROTATION) { + transform->rotation = tdseq->orig_rotation; + } + continue; + } + Scene *scene = t->scene; RNA_pointer_create(&scene->id, &RNA_SequenceTransform, transform, &ptr); if (t->mode == TFM_ROTATION) { ```

hamza.SMA commented

2022-05-20 00:26:20 +02:00

i noticed also that if we set rotation 600° as preset then rotate using shortcut 'R' 'without any change'we can notice that the value will go to between 0° and 360°.
so there is a modulo by 360° which it will miss with any animation that was done .....
SO i propose to make addition instead of modulo '-360......360'

i noticed also that if we set rotation 600° as preset then rotate using shortcut 'R' 'without any change'we can notice that the value will go to between 0° and 360°. so there is a modulo by 360° which it will miss with any animation that was done ..... SO i propose to make addition instead of modulo '-360......360'

blender-admin commented

2022-05-23 23:28:21 +02:00

This issue was referenced by c968dae054

This issue was referenced by c968dae05441b8d2c68916260d728c4a8d01c464

Richard Antalik commented

2022-05-23 23:37:46 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Richard Antalik closed this issue

2022-05-23 23:37:46 +02:00

Richard Antalik self-assigned this 2022-05-23 23:37:46 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Rotation value on preview sequencer view and the value in sidebar don't match #98141