Blender 3.2.0 Beta crashes on startup #98365

New Issue

Amy Moo · 2022-05-25T13:27:45+02:00

Amy Moo commented

2022-05-25 13:27:45 +02:00

After the issue #98194 is fixed, I downloaded the build bc3dbf109c. Another startup crash occurred.

ERROR (gpu.shader): overlay_outline_detect FragShader:
      |
  923 |   vec3 ofs = vec3(0.5, 0.5, -0.5) * drw_view.viewport_size_inversey;
      |
      | outline_detect_frag.glsl:39:0: Error: C1009: "viewport_size_inversey" is not member of struct "ViewInfos"

Error   : EXCEPTION_ACCESS_VIOLATION
Address : 0x00007FF6ADA56160
Module  : blender.exe
Thread  : 000011ec

blender.crash.txt

After the issue #98194 is fixed, I downloaded the build bc3dbf109c67. Another startup crash occurred. ``` ERROR (gpu.shader): overlay_outline_detect FragShader: | 923 | vec3 ofs = vec3(0.5, 0.5, -0.5) * drw_view.viewport_size_inversey; | | outline_detect_frag.glsl:39:0: Error: C1009: "viewport_size_inversey" is not member of struct "ViewInfos" Error : EXCEPTION_ACCESS_VIOLATION Address : 0x00007FF6ADA56160 Module : blender.exe Thread : 000011ec ``` [blender.crash.txt](https://archive.blender.org/developer/F13104294/blender.crash.txt)

Amy Moo commented

2022-05-25 13:27:45 +02:00

Added subscriber: @amy_aimei

Amy Moo commented

2022-05-25 13:28:41 +02:00

Same hardware as reported in #98194

Amy Moo commented

2022-05-25 13:42:53 +02:00

source/blender/draw/intern/draw_shader_shared.h
Lines 25 to 46:

struct ViewInfos {
	  /* View matrices */
	  float4x4 persmat;
	  float4x4 persinv;
	  float4x4 viewmat;
	  float4x4 viewinv;
	  float4x4 winmat;
	  float4x4 wininv;
	
	  float4 clip_planes[6];
	  float4 viewvecs[2];
	  /* Should not be here. Not view dependent (only main view). */
	  float4 viewcamtexcofac;
	
	  float2 viewport_size;
	  float2 viewport_size_inverse;
	
	  /** Frustum culling data. */
	  /** NOTE: vec3 arrays are padded to vec4. */
	  float4 frustum_corners[8];
	  float4 frustum_planes[6];
	};

There is no viewport_size_inversey. The only occurrence of "viewport_size_inversey" found in source/blender/draw/engines/overlay/shaders/outline_detect_frag.glsl
Line 39: vec3 ofs = vec3(0.5, 0.5, -0.5) * drw_view.viewport_size_inversey;

source/blender/draw/intern/draw_shader_shared.h Lines 25 to 46: ``` struct ViewInfos { /* View matrices */ float4x4 persmat; float4x4 persinv; float4x4 viewmat; float4x4 viewinv; float4x4 winmat; float4x4 wininv; float4 clip_planes[6]; float4 viewvecs[2]; /* Should not be here. Not view dependent (only main view). */ float4 viewcamtexcofac; float2 viewport_size; float2 viewport_size_inverse; /** Frustum culling data. */ /** NOTE: vec3 arrays are padded to vec4. */ float4 frustum_corners[8]; float4 frustum_planes[6]; }; ``` There is no viewport_size_inversey. The only occurrence of "viewport_size_inversey" found in source/blender/draw/engines/overlay/shaders/outline_detect_frag.glsl Line 39: vec3 ofs = vec3(0.5, 0.5, -0.5) * drw_view.viewport_size_inversey;

Omar Emara commented

2022-05-25 13:44:02 +02:00

Added subscriber: @OmarEmaraDev

Omar Emara commented

2022-05-25 13:44:02 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Omar Emara commented

2022-05-25 13:44:02 +02:00

Looks like a straight forward typo, so I will confirm.

Amy Moo commented

2022-05-25 13:45:45 +02:00

It seems to be a typo in the code in source/blender/draw/engines/overlay/shaders/outline_detect_frag.glsl
Line 39: vec3 ofs = vec3(0.5, 0.5, -0.5) * drw_view.viewport_size_inversey;
Should it be: vec3 ofs = vec3(0.5, 0.5, -0.5) * drw_view.viewport_size_inverse;

It seems to be a typo in the code in source/blender/draw/engines/overlay/shaders/outline_detect_frag.glsl Line 39: vec3 ofs = vec3(0.5, 0.5, -0.5) * drw_view.**viewport_size_inversey**; Should it be: vec3 ofs = vec3(0.5, 0.5, -0.5) * drw_view.**viewport_size_inverse**;

Omar Emara commented

2022-05-25 13:49:52 +02:00

If you are willing to submit a patch, you can try that. https://wiki.blender.org/wiki/Process/Contributing_Code

However, note that drw_view.viewport_size_inverse; is probably wrong as viewport_size_inverse is a vec2. It is best to consult the original code before the typo here 6e5877c189.

If you are willing to submit a patch, you can try that. https://wiki.blender.org/wiki/Process/Contributing_Code However, note that `drw_view.viewport_size_inverse;` is probably wrong as `viewport_size_inverse` is a `vec2`. It is best to consult the original code before the typo here 6e5877c189.

Jeroen Bakker commented

2022-05-25 14:22:12 +02:00

Added subscribers: @fclem, @Jeroen-Bakker