GPU: Share GPU Textures when using the same file path. #98375

New Issue

Jeroen Bakker · 2022-05-25T17:28:34+02:00

Jeroen Bakker commented

2022-05-25 17:28:34 +02:00

Currently the GPU textures that Workbench and Eevee uses are cached inside the image data-block.
In productions scenes were textures are reused by different materials sourcing from different blend files the GPU textures are not shared, although they might use the same file on disk.

The idea is to share the GPU textures between those image data-blocks.

Corner cases

GPU textures can only be shared when data-block isn't modifier. This could mean that GPU textures could be shared, until the user starts modify-ing one.
GPU textures for movies and sequences can only be shared when they reflect the same frame number. Currently a eevee cannot handle drawing multiple frames from the same image data-block. A work around for this is to duplicate the image block. For the short term we could also not support sharing GPU textures for movies and sequences at all as this isn't used that much to our knowledge.
Both single tiled and multi-tiled images should be supported.

Implementation

Use a single GPUTexture cache. Store GPU textures with a key. Key could be some values stored as a string. Per key a group of GPU Textures can be retrieved (Tiled, TileIndex, Image, left/right) etc.
Additional benefit is that usage tagging can be done faster as we don't need to go over all the image data-blocks in the scene. (although don't think this would be noticeable to users)
Key could contain:
Type of image filename
** Optional the IDBlock name+library for when images are modified.

eImageTextureResolution isn't used anymore and could be removed. There is no need anymore to support multiple texture resolutions at the same time. Will reduce some code complexity and nano improvement in performance. {f41c7723c93b}
IMA_NOCOLLECT can be removed aswell

NOTE: Request made by the Heist project.

Currently the GPU textures that Workbench and Eevee uses are cached inside the image data-block. In productions scenes were textures are reused by different materials sourcing from different blend files the GPU textures are not shared, although they might use the same file on disk. The idea is to share the GPU textures between those image data-blocks. ## Corner cases * GPU textures can only be shared when data-block isn't modifier. This could mean that GPU textures could be shared, until the user starts modify-ing one. * GPU textures for movies and sequences can only be shared when they reflect the same frame number. Currently a eevee cannot handle drawing multiple frames from the same image data-block. A work around for this is to duplicate the image block. For the short term we could also not support sharing GPU textures for movies and sequences at all as this isn't used that much to our knowledge. * Both single tiled and multi-tiled images should be supported. ## Implementation * Use a single GPUTexture cache. Store GPU textures with a key. Key could be some values stored as a string. Per key a group of GPU Textures can be retrieved (Tiled, TileIndex, Image, left/right) etc. * Additional benefit is that usage tagging can be done faster as we don't need to go over all the image data-blocks in the scene. (although don't think this would be noticeable to users) * Key could contain: **Type of image** filename ** Optional the IDBlock name+library for when images are modified. ## Related changes * `eImageTextureResolution` isn't used anymore and could be removed. There is no need anymore to support multiple texture resolutions at the same time. Will reduce some code complexity and nano improvement in performance. {f41c7723c93b} * `IMA_NOCOLLECT` can be removed aswell NOTE: Request made by the Heist project.

Jeroen Bakker self-assigned this 2022-05-25 17:28:34 +02:00

Jeroen Bakker commented

2022-05-25 17:28:34 +02:00

Added subscribers: @Jeroen-Bakker, @SimonThommes