VSE unkeyed transforms in preview persist in cache #98432

New Issue

Philipp Oeser · 2022-05-27T10:30:21+02:00

Philipp Oeser commented

2022-05-27 10:30:21 +02:00

System Information
Operating system: Linux-5.13.0-0.rc6.45.fc35.x86_64-x86_64-with-glibc2.34.9000 64 Bits
Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 495.44

Blender Version
Broken: version: 3.3.0 Alpha, branch: master, commit date: 2022-05-22 18:26, hash: d095fcd6b4
Worked: never

Short description of error
VSE unkeyed transforms in preview persist in cache.
If transforms occur on a property that has an fcurve already (but no keyframe is actually created on that frame), this transform will remain in the cache for that frame.
This does not get invalidated on timeline scrubbing / frame change.

(this report was split from #98015 (VSE strip transforms do not animate correctly and persist after clearing the animation) since multiple issues came up in that report)

Exact steps for others to reproduce the error
VSE_keyframing.blend

open .blend
create a keyframes for rotation on frame 1
go to frame 10
rotate in the Preview again and confirm the rotation (but dont create a keyframe)
scrub the timeline
since this change on frame 10 was not keyed, it should vanish, but it doesnt, it remains in the cache
note: when the strip in the Sequencer view gets moved, the issue goes away (assume the whole cache gets invalidated then)

**System Information** Operating system: Linux-5.13.0-0.rc6.45.fc35.x86_64-x86_64-with-glibc2.34.9000 64 Bits Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 495.44 **Blender Version** Broken: version: 3.3.0 Alpha, branch: master, commit date: 2022-05-22 18:26, hash: `d095fcd6b4` Worked: never **Short description of error** VSE unkeyed transforms in preview persist in cache. If transforms occur on a property that has an fcurve already (but no keyframe is actually created on that frame), this transform will remain in the cache for that frame. This does not get invalidated on timeline scrubbing / frame change. (this report was split from #98015 (VSE strip transforms do not animate correctly and persist after clearing the animation) since multiple issues came up in that report) **Exact steps for others to reproduce the error** [VSE_keyframing.blend](https://archive.blender.org/developer/F13113208/VSE_keyframing.blend) - open .blend - create a keyframes for rotation on frame 1 - go to frame 10 - rotate in the `Preview` again and confirm the rotation (but dont create a keyframe) - scrub the timeline - since this change on frame 10 was not keyed, it should vanish, but it doesnt, it remains in the cache - note: when the strip in the `Sequencer` view gets moved, the issue goes away (assume the whole cache gets invalidated then)

Philipp Oeser commented

2022-05-27 10:30:21 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-05-27 10:33:29 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-05-27 10:33:29 +02:00

Added subscribers: @iss, @OmarEmaraDev

Philipp Oeser commented

2022-05-27 10:33:29 +02:00

CC @iss
CC @OmarEmaraDev

CC @iss CC @OmarEmaraDev

Philipp Oeser commented

2022-05-30 09:14:24 +02:00

Just pasting the previous relevant quotes from #98015:

In #98015#1366040, @iss wrote:

In #98015#1365188, @lichtwerk wrote:
I think it makes sense to split this report up in multiple reports (will do that).

In #98015#1364993, @iss wrote:
Ah right that's correct. Not sure what would be good solution. Sounds to me that in case when property is animated, cache entry should be created only when keyframe is inserted, but even that is not quite enough - it would have to check if all properties that were changed were keyed. Looks quite complicated to handle this.

Havent looked at cache internals (where the entries are made, when/how exactly this get invalidated), could check if you give me a hint, but looks like this is essential funtionality that is just behaving wrong (by design?)

Most modal operators would invalidate cache right after strip data is modified(here recalcData_sequencer) along with sending notifiers to redraw/re-render. Images are cached during rendering(seq_cache_put). So technically this is behaving wrong by design. Sequencer would have to know that property is not keyframed yet and not cache any image in such case, which is quite a bit outside of its scope IMO.

There is mechanism in cache for discarding images that are stored recently, but this is due to memory limits and fact that all images within same frame must be stored (size of all images is known only after they are stored and possibly over the limit). So technically this could be solved, but not sure how to signal this situation to sequencer. Even depsgraph does not care about data you have manually tweaked and not keyed when you change frame - it just discards everything and calculates animation from ground up.

Just pasting the previous relevant quotes from #98015: > In #98015#1366040, @iss wrote: >> In #98015#1365188, @lichtwerk wrote: >> I think it makes sense to split this report up in multiple reports (will do that). >> >> >>> In #98015#1364993, @iss wrote: >>> Ah right that's correct. Not sure what would be good solution. Sounds to me that in case when property is animated, cache entry should be created only when keyframe is inserted, but even that is not quite enough - it would have to check if all properties that were changed were keyed. Looks quite complicated to handle this. >> Havent looked at cache internals (where the entries are made, when/how exactly this get invalidated), could check if you give me a hint, but looks like this is essential funtionality that is just behaving wrong (by design?) > > Most modal operators would invalidate cache right after strip data is modified(here `recalcData_sequencer`) along with sending notifiers to redraw/re-render. Images are cached during rendering(`seq_cache_put`). So technically this is behaving wrong by design. Sequencer would have to know that property is not keyframed yet and not cache any image in such case, which is quite a bit outside of its scope IMO. > > There is mechanism in cache for discarding images that are stored recently, but this is due to memory limits and fact that all images within same frame must be stored (size of all images is known only after they are stored and possibly over the limit). So technically this could be solved, but not sure how to signal this situation to sequencer. Even depsgraph does not care about data you have manually tweaked and not keyed when you change frame - it just discards everything and calculates animation from ground up.

Richard Antalik commented

2022-06-14 20:19:55 +02:00

Since solution for this is not trivial, will classify as known issue.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

VSE unkeyed transforms in preview persist in cache #98432